emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* `#+author:' stopped setting the author to empty string
@ 2020-05-18 13:57 Kaushal Modi
  2020-05-18 14:30 ` Julius Müller
  2020-05-18 23:30 ` Kyle Meyer
  0 siblings, 2 replies; 7+ messages in thread
From: Kaushal Modi @ 2020-05-18 13:57 UTC (permalink / raw)
  To: emacs-org list

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

Hello,

At some point in the past month or so, I have noticed that on Org master,
#+author: does not set the author to empty in the exports.

Simply example to reproduce:

=====
#+author:
Test
=====

Run C-c C-e t A

Expected output:

=====
Table of Contents
_________________




Test
=====

Observed output:


=====
<value of user-full-name>

Table of Contents
_________________




Test
=====

I looked through the commits on master in the past month, but I don't see
any author-specific change that would affect *all* the exporter backends.

Can anyone else reproduce this issue?

--
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1207 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: `#+author:' stopped setting the author to empty string
  2020-05-18 13:57 `#+author:' stopped setting the author to empty string Kaushal Modi
@ 2020-05-18 14:30 ` Julius Müller
  2020-05-18 23:30 ` Kyle Meyer
  1 sibling, 0 replies; 7+ messages in thread
From: Julius Müller @ 2020-05-18 14:30 UTC (permalink / raw)
  To: emacs-orgmode

Am 18.05.20 um 15:57 schrieb Kaushal Modi:
> I looked through the commits on master in the past month, but I don't
> see any author-specific change that would affect *all* the exporter
> backends.
>
> Can anyone else reproduce this issue?

Same observation here (org master from about a week ago, GNU emacs 26.3,
ubuntu 18.4)

I solved the problem by using

#+author: \nbsp

and forgot to report.

Julius


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: `#+author:' stopped setting the author to empty string
  2020-05-18 13:57 `#+author:' stopped setting the author to empty string Kaushal Modi
  2020-05-18 14:30 ` Julius Müller
@ 2020-05-18 23:30 ` Kyle Meyer
  2020-05-19  8:04   ` Nicolas Goaziou
  2020-05-19 15:08   ` Kaushal Modi
  1 sibling, 2 replies; 7+ messages in thread
From: Kyle Meyer @ 2020-05-18 23:30 UTC (permalink / raw)
  To: Kaushal Modi, emacs-org list

Kaushal Modi writes:

> At some point in the past month or so, I have noticed that on Org master,
> #+author: does not set the author to empty in the exports.
>
> Simply example to reproduce:

Thanks for the minimal example.

> I looked through the commits on master in the past month, but I don't see
> any author-specific change that would affect *all* the exporter backends.

It bisects to b4e91b7e9 (New function: org-collect-keywords,
2020-04-26).  I haven't done much digging, but I was able to restore the
behavior with the change below, which may be a bad idea for other
reasons.

diff --git a/lisp/org.el b/lisp/org.el
index 0e1e05239..a8db4c2bf 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -4501,7 +4501,6 @@ (defun org--collect-keywords-1 (keywords uniques files alist)
 			  (push (cons key value) alist)
 			  (setq keywords (remove key keywords))
 			  (setq regexp (org-make-options-regexp keywords)))
-			 ((not (org-string-nw-p value)) nil)
 			 ((null entry) (push (list key value) alist))
 			 (t (push value (cdr entry)))))))))))
       alist)))


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: `#+author:' stopped setting the author to empty string
  2020-05-18 23:30 ` Kyle Meyer
@ 2020-05-19  8:04   ` Nicolas Goaziou
  2020-05-20  0:38     ` Kyle Meyer
  2020-05-19 15:08   ` Kaushal Modi
  1 sibling, 1 reply; 7+ messages in thread
From: Nicolas Goaziou @ 2020-05-19  8:04 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-org list, Kaushal Modi

Hello,

Kyle Meyer <kyle@kyleam.com> writes:

> It bisects to b4e91b7e9 (New function: org-collect-keywords,
> 2020-04-26).  I haven't done much digging, but I was able to restore the
> behavior with the change below, which may be a bad idea for other
> reasons.
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 0e1e05239..a8db4c2bf 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -4501,7 +4501,6 @@ (defun org--collect-keywords-1 (keywords uniques files alist)
>  			  (push (cons key value) alist)
>  			  (setq keywords (remove key keywords))
>  			  (setq regexp (org-make-options-regexp keywords)))
> -			 ((not (org-string-nw-p value)) nil)
>  			 ((null entry) (push (list key value) alist))
>  			 (t (push value (cdr entry)))))))))))

At first glance, it looks harmless. If the test suite passes, we can
apply it.

Thank you.

Regards,

-- 
Nicolas Goaziou


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: `#+author:' stopped setting the author to empty string
  2020-05-18 23:30 ` Kyle Meyer
  2020-05-19  8:04   ` Nicolas Goaziou
@ 2020-05-19 15:08   ` Kaushal Modi
  1 sibling, 0 replies; 7+ messages in thread
From: Kaushal Modi @ 2020-05-19 15:08 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-org list

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

On Mon, May 18, 2020 at 7:30 PM Kyle Meyer <kyle@kyleam.com> wrote:

>
> It bisects to b4e91b7e9 (New function: org-collect-keywords,
> 2020-04-26).  I haven't done much digging, but I was able to restore the
> behavior with the change below, which may be a bad idea for other
> reasons.
>

Thanks for that bisect!

If the current tests (and the new test with blank author "#+author:") pass,
then we should be good :)

[-- Attachment #2: Type: text/html, Size: 770 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: `#+author:' stopped setting the author to empty string
  2020-05-19  8:04   ` Nicolas Goaziou
@ 2020-05-20  0:38     ` Kyle Meyer
  2020-05-20 14:08       ` Kaushal Modi
  0 siblings, 1 reply; 7+ messages in thread
From: Kyle Meyer @ 2020-05-20  0:38 UTC (permalink / raw)
  To: emacs-org list; +Cc: Kaushal Modi

Nicolas Goaziou writes:

> At first glance, it looks harmless. If the test suite passes, we can
> apply it.

The test suite does pass with the change.  Pushed, along with a
regression test (962b8e765).

Thanks.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: `#+author:' stopped setting the author to empty string
  2020-05-20  0:38     ` Kyle Meyer
@ 2020-05-20 14:08       ` Kaushal Modi
  0 siblings, 0 replies; 7+ messages in thread
From: Kaushal Modi @ 2020-05-20 14:08 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-org list

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

On Tue, May 19, 2020 at 8:38 PM Kyle Meyer <kyle@kyleam.com> wrote:

> Nicolas Goaziou writes:
>
> > At first glance, it looks harmless. If the test suite passes, we can
> > apply it.
>
> The test suite does pass with the change.  Pushed, along with a
> regression test (962b8e765).
>

Thank you for the debug and quick fix! I confirm the fix.

[-- Attachment #2: Type: text/html, Size: 696 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-05-20 14:18 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-18 13:57 `#+author:' stopped setting the author to empty string Kaushal Modi
2020-05-18 14:30 ` Julius Müller
2020-05-18 23:30 ` Kyle Meyer
2020-05-19  8:04   ` Nicolas Goaziou
2020-05-20  0:38     ` Kyle Meyer
2020-05-20 14:08       ` Kaushal Modi
2020-05-19 15:08   ` Kaushal Modi

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).