From: Max Nikulin <manikulin@gmail.com>
To: Ken Mankoff <mankoff@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] lisp/ob-screen.el: Support ~:var~ header args for babel blocks
Date: Sat, 25 Feb 2023 23:05:09 +0700 [thread overview]
Message-ID: <d52df549-e144-4c22-029f-318469e062a6@gmail.com> (raw)
In-Reply-To: <877cw5aiab.fsf@t480.home>
On 25/02/2023 22:14, Ken Mankoff wrote:
> On 2023-02-24 at 19:51 -08, Max Nikulin wrote:
>> The code still depends on on ob-shell. Is there a reason why calling
>> `org-babel-variable-assignments:shell' is a worse variant than copy of
>> the whole function body?
>
> I didn't realize that was a dependency. I now use that function. This
> also means that arrays/tables/etc. are all supported by :var, although
> not in the default screen ":cmd sh" because sh doesn't support
> "declare", but it works with ":cmd bash".
> + (var-lines (org-babel-variable-assignments:shell params))
> (socket (org-babel-screen-session-socketname session)))
I believe, it is safer to define `org-babel-variable-assignments:screen'
some way: alias, substitution, function that calls
`org-babel-variable-assignments:shell'. I am unsure which variant is
better. I see a couple of callers for specific language in ob-core.el.
I can not suggest anything specific concerning sh vs. bash. I have never
tried to pass tables to sh src blocks.
next prev parent reply other threads:[~2023-02-25 16:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 17:03 [PATCH] lisp/ob-screen.el: Support ~:var~ header args for babel blocks Ken Mankoff
2023-02-24 18:33 ` Ken Mankoff
2023-02-25 3:51 ` Max Nikulin
2023-02-25 15:14 ` Ken Mankoff
2023-02-25 15:19 ` Ken Mankoff
2023-02-25 16:05 ` Max Nikulin [this message]
2023-02-25 16:47 ` Ken Mankoff
2023-02-26 10:11 ` Max Nikulin
2023-02-27 1:59 ` Ken Mankoff
2023-02-28 10:40 ` Ihor Radchenko
2023-03-16 4:12 ` Ken Mankoff
2023-03-16 10:22 ` Ihor Radchenko
2023-03-16 15:09 ` [PATCH v4] " Max Nikulin
2023-03-17 11:41 ` Max Nikulin
2023-03-18 12:08 ` Ihor Radchenko
2023-03-19 14:42 ` Ken Mankoff
2023-03-21 14:12 ` Max Nikulin
2023-03-02 13:38 ` [PATCH] " Max Nikulin
2023-02-26 12:18 ` Ihor Radchenko
2023-02-27 1:59 ` Ken Mankoff
2023-02-27 19:43 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d52df549-e144-4c22-029f-318469e062a6@gmail.com \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mankoff@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).