From: Daniel Ziltener <dziltener@lyrion.ch>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option
Date: Fri, 28 Oct 2022 10:09:04 +0200 [thread overview]
Message-ID: <cc8e92bf-39b3-aaf1-8bf9-fa7bc8724a7f@lyrion.ch> (raw)
In-Reply-To: <87o7twn101.fsf@localhost>
[-- Attachment #1.1.1: Type: text/plain, Size: 2266 bytes --]
Am 28.10.22 um 04:19 schrieb Ihor Radchenko:
> dziltener@lyrion.ch writes:
>
>> From: Daniel Ziltener <dziltener@lyrion.ch>
>>
>> * ob-tangle.el, ob-core.el, test-ob-tangle.el, org-manual.org: Add a
>> "strip-tangle" noweb option to strip the noweb tags when tangling, but
>> keep and expand them otherwise.
> Thanks for the patch!
>
> If I understand correctly, you are suggesting
>
> Could you please follow
> https://orgmode.org/worg/org-contribute.html#commit-messages for the
> commit log entries?
I tried to follow that. To follow it "more" I guess I have to make one
commit per file I changed? There isn't an example for multiple files, so
I was not sure how exactly to follow it.
> Also, do you have FSF copyright assignment? If no, you also need to add
> TINYCHANGE cookie to the commit message. See
> https://orgmode.org/worg/org-contribute.html#first-patch
I do, yes, I sent in the signed form on Wednesday as requested by the FSF.
>> +- =strip-tangle= ::
>> +
>> + Expansion of noweb syntax references in the body of the code block
>> + when evaluating or exporting. Removes noweb syntax references
>> + when tangling.
> This is a new feature and thus should also be mentioned in etc/NEWS.
>
> Also, please use double space between sentences. See
> doc/Documentation_Standards.org.
Noted, I'll do both of these.
>> (let ((allowed-values (cl-case context
>> - (:tangle '("yes" "tangle" "no-export" "strip-export"))
>> - (:eval '("yes" "no-export" "strip-export" "eval"))
>> - (:export '("yes")))))
>> + (:tangle '("yes" "tangle" "no-export" "strip-export" "strip-tangle"))
>> + (:eval '("yes" "no-export" "strip-export" "eval" "strip-tangle"))
>> + (:export '("yes" "strip-tangle")))))
> AFAIU, you are suggesting a new value for :noweb header argument.
> But this function has nothing to do with :noweb. This change will check
> for :tangle strip-tangle, :eval strip-tangle, and :export strip-tangle.
> What is the purpose?
I suppose then I made a mistake there. My intention was what you mention
next:
> Also, the allowed values of standard header args are defined in
> org-babel-common-header-args-w-values, which you did not change.
I will adjust that one instead.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 1205 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-10-28 8:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 19:37 [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option dziltener
2022-10-28 2:19 ` Ihor Radchenko
2022-10-28 8:09 ` Daniel Ziltener [this message]
2022-10-29 3:49 ` Ihor Radchenko
2022-10-29 23:34 ` Daniel Ziltener
2022-10-30 4:12 ` Ihor Radchenko
2022-10-30 10:42 ` Daniel Ziltener
2022-11-02 6:17 ` Ihor Radchenko
2022-12-27 10:59 ` Ihor Radchenko
2022-10-30 4:17 ` Timothy
2022-10-31 3:24 ` Ihor Radchenko
2022-10-31 3:31 ` Timothy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc8e92bf-39b3-aaf1-8bf9-fa7bc8724a7f@lyrion.ch \
--to=dziltener@lyrion.ch \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).