From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id qGrVOsVR52RLYAAASxT56A (envelope-from ) for ; Thu, 24 Aug 2023 14:49:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id YHHBOsVR52S7AgEA9RJhRA (envelope-from ) for ; Thu, 24 Aug 2023 14:49:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6FEB94E2FB for ; Thu, 24 Aug 2023 14:49:09 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=vodafonemail.de header.s=vfde-mb-mr2-21dec header.b=FWFeb4GX; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=vodafonemail.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692881349; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=fdsYKjNE/vvcEnYEieySCjlY95apoHS9kpD19TNkKFU=; b=lFL9oLvrtEyKsBSE/UROMw7atyhxkou1JB7VDj3243gkxEygj3BOEgRDOtemNK4F2vA59u m4IDf8qlxLi086KKeHIAUXPF9VUjTpenbmfqsgoKb/cdhXcMUkI3CIDfyDxvlV0HLa0RvV 3AYK0cZAPsh9D8SqXOHRfFlXOZDa2TkU4RuW8/+/0Qf83UrN/0UXHfjMAh36BrGlwe3czs Iwal3hl+7dssFJBysRnv4w3WyQTYogRwcHP3GahA0AN6MjfejoeC/5BD/51lnik966UMjx 8jR4Qxaumv7nnMdMyMBb2EZDf8+eRs8LN4NyZXJLnqLn8NNBmj78hqoNzbsDug== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692881349; a=rsa-sha256; cv=none; b=S94nUA5+NAE5y/ILSDc8+4u6L4KbVaJ0frW5Y2op2nHHPeCKIn7f2F7mp2xdDXk7DVsSvQ g2GymFSTfkcCKQ/pAAB3Tj6BPdywIgQwBaFYXoK91RZ4ad0OT8pvu6i6znuXFwQ3Ezudjf D/iblFH0lwtVqziyTFpPoDgEwjIg97AHtGew1aQxQ/gXiHzfWLvKt0E/mbZAXiWBV4A2+v EN0yGq7WPxinwWDK3NpkYgIrvFFWOwnauLho69EZIlTKI9bOGI3Z0sVUyP2qrETOx8Ksfa 8vaU/l3EQzVu68L3bjUX8AzDHcqUVjZImZC9LNufn54JWs8ULvt9HTLZYxs4ew== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=vodafonemail.de header.s=vfde-mb-mr2-21dec header.b=FWFeb4GX; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=vodafonemail.de Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZ9li-0000aL-Vl; Thu, 24 Aug 2023 08:48:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ9lg-0000Zy-Vq for emacs-orgmode@gnu.org; Thu, 24 Aug 2023 08:48:57 -0400 Received: from mr3.vodafonemail.de ([145.253.228.163]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ9le-0005Ge-CC for emacs-orgmode@gnu.org; Thu, 24 Aug 2023 08:48:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1692881331; bh=fdsYKjNE/vvcEnYEieySCjlY95apoHS9kpD19TNkKFU=; h=Message-ID:Date:User-Agent:Subject:Content-Language:To:References: From:In-Reply-To:Content-Type:From; b=FWFeb4GXaO1BB2DuxwbOjvJ/DN8CS0m1vjvEfymWcLmS4LQD4hHVzJFWA5tQVy2yw sP4kxUSLecNOkox6d8k6t7CnuFPOcnXeKJUDCK6hQAqeUjINg5pnNfiaWxP/vzwYby CfFPXNVc+D/YXS7ZsJ4g4HJtiYfBbZOJry8PwMrk= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr3.vodafonemail.de (Postfix) with ESMTPS id 4RWjZC6ykrz1yjw; Thu, 24 Aug 2023 12:48:51 +0000 (UTC) Received: from [192.168.0.138] (unknown [86.33.87.7]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4RWjZ36tMtzMks9; Thu, 24 Aug 2023 12:48:40 +0000 (UTC) Message-ID: Date: Thu, 24 Aug 2023 14:48:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [BUG] "make check" reports a failure on test-org/insert-heading @ d5ee33f (this time with Emacs 29) Content-Language: de-DE-frami, en-US To: Ihor Radchenko Cc: Org-mode References: <87v8d4d5vz.fsf@localhost> <87y1i01vci.fsf@localhost> From: Jens Schmidt In-Reply-To: <87y1i01vci.fsf@localhost> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 2888 X-purgate-ID: 155817::1692881327-D4FF7E6D-5BBB1323/0/0 Received-SPF: pass client-ip=145.253.228.163; envelope-from=jschmidt4gnu@vodafonemail.de; helo=mr3.vodafonemail.de X-Spam_score_int: -56 X-Spam_score: -5.7 X-Spam_bar: ----- X-Spam_report: (-5.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.919, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.81 X-Spam-Score: -9.81 X-Migadu-Queue-Id: 6FEB94E2FB X-Migadu-Scanner: mx1.migadu.com X-TUID: Kyx0fRNCOly8 On 2023-08-24 14:24, Ihor Radchenko wrote: > Jens Schmidt writes: > >> Would you mind if I added a test that explicitly and with some nice >> error message tests for that condition? I.e. if some unwary user >> strips off trailing whitespace in test-org.el, that test would fail >> with a reasonable message. > > There is no universal rule when and when not to add trailing spaces in > the tests. Not sure what you mean by that, but some tests rely on trailing spaces and fail when these are not present. An explicit test on that would make the issue more visible. See below for what I mean. The only (?) downside is that this catches such errors in test-org.el only, and not in all the other tests, many of which also contain (on purpose or inadvertently) trailing whitespace: [org-mode]$ grep -l $'[ \t]$' testing/lisp/* testing/lisp/test-ob-C.el testing/lisp/test-ob-R.el testing/lisp/test-ob-fortran.el testing/lisp/test-org-agenda.el testing/lisp/test-org-element.el testing/lisp/test-org-fold.el testing/lisp/test-org-footnote.el testing/lisp/test-org.el ---------------------------------------- diff --git a/testing/lisp/test-org.el b/testing/lisp/test-org.el index e33f500a3..e49c2f957 100644 --- a/testing/lisp/test-org.el +++ b/testing/lisp/test-org.el @@ -9363,6 +9363,16 @@ two (string-match-p "\\`Invalid format.*%2" err-text)) err))))) + +;;; Meta-test on Trailing Whitespace not Being Deleted + +(ert-deftest test-org/trailing-whitespace-deleted () + "Ensure trailing whitespace did not get deleted in this file." + (should + (equal "Do not delete trailing whitespace --> + in this file." + "Do not delete trailing whitespace --> \n in this file."))) + (provide 'test-org) ;;; test-org.el ends here ---------------------------------------- If the blank after the arrow gets removed, this test fails as: ---------------------------------------- Test test-org/trailing-whitespace-deleted condition: (ert-test-failed ((should (equal "Do not delete trailing whitespace --> in this file." "Do not delete trailing whitespace --> in this file.")) :form (equal "Do not delete trailing whitespace --> in this file." "Do not delete trailing whitespace --> in this file.") :value nil :explanation (arrays-of-different-length 62 63 "Do not delete trailing whitespace --> in this file." "Do not delete trailing whitespace --> in this file." first-mismatch-at 37))) FAILED 1068/1095 test-org/trailing-whitespace-deleted (0.000193 sec) [...] 1 unexpected results: FAILED test-org/trailing-whitespace-deleted ----------------------------------------