From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uKTEJCinAGRgPAEAbAwnHQ (envelope-from ) for ; Thu, 02 Mar 2023 14:39:52 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id uN9SJCinAGT3oQAA9RJhRA (envelope-from ) for ; Thu, 02 Mar 2023 14:39:52 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 209E815C33 for ; Thu, 2 Mar 2023 14:39:52 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=HwkiJqpd; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677764392; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=PyPgLPBRP7VClk57Yv5bAzY1i/wSAMS0GGoqQIl/L5c=; b=s2bFLNEmm8H1/7ereo4CHy7oylPX0Cv4aiOzvYVvSFDf//vEhXtCllFILOVQNGNTnCYXOF PqYM8p9nFmqOtCREds9X3C+muXeofNMVAzSvaeXwcR7EXpAqNncpWkGTn/kU0nUfYKLGpv 8ANCNPmB1WilrLJWEfGUk8Z/hb7XYX6QGFt4lz7HloyWQZwHrQRfoq20nFmXGPW6MPa/P5 hKqgZH6admSwGHo2/UvVO+v8TITPa6JKG25jczMNPMX2d3qIzF5LsIgBtdNzOFNToJgAAh O65/LusIw15GLXwdI47iZyKLm5V43YreEZl1aMOerANeA1Bep9X6fceWoB8YZg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=HwkiJqpd; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677764392; a=rsa-sha256; cv=none; b=pNtTP6mKpFjs2Nevt/erU8FXf7vgKUAC1rtTfkMwhXb8xd0QD34dWqKndjabf7+KGbLSvH btN3xQRPNTSrE6BJfeQ5g5wluyDzh7/kIrkIeNu20i24Xtqcy+gEApZYjUYTbbNbDhmzOY gsvI/IcVXmcNweKXqqPAYJVWVyZXvnntugo/vv/A3/wX1QOgKwgBNzQzMhWcv6cGK9Ya9A j/e9n/Nn3WZzmzAM8HpCDmJt3gRtRhhuQrTpDIgHrjXCoNCrdOYeqqhWEAh96NIfhiCL2H MlqwjEJNKLULeOrL4d7l2U04zYnY/Bi15qXZLwBrXFSvKA+AcqK6S+KgpCT+sw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXj9D-0004UP-Io; Thu, 02 Mar 2023 08:39:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXj9B-0004PB-Qr for emacs-orgmode@gnu.org; Thu, 02 Mar 2023 08:39:01 -0500 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXj99-0002N0-NB for emacs-orgmode@gnu.org; Thu, 02 Mar 2023 08:39:01 -0500 Received: by mail-lj1-x22c.google.com with SMTP id a32so2741030ljr.9 for ; Thu, 02 Mar 2023 05:38:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677764337; h=content-transfer-encoding:in-reply-to:mail-followup-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=PyPgLPBRP7VClk57Yv5bAzY1i/wSAMS0GGoqQIl/L5c=; b=HwkiJqpd+RTUZ+7zPBX4MecQRqzaBFzxMwcsR3e28qSD2iS0LVsLJJgDJQM2cCMyYc 8pSUzYtoYrXZQE2WUkuvBSR51YF5mrOJ95CBaRr/q+bR+jediRNgm5mOCso5VkQqTjpZ yEZK5BFfM06llGemrdljEsQ53DrIuIRimkKoabQmK+WDAfxo+BOo3FKZHk9gfRH1aSyB BIAF5g28CihU7ddyDz00I03wO/mi1/5JCSI3qw4r7b7C6KxEpb/Vx2kqUgNQsoarBh9z 85uMTPNpyJ7tPn3b/vxyRA7e1uIdV7pgpuDJy9y+kOslF+p295CvdWCG9ZhaP7sl3L/c CMow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677764337; h=content-transfer-encoding:in-reply-to:mail-followup-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PyPgLPBRP7VClk57Yv5bAzY1i/wSAMS0GGoqQIl/L5c=; b=54JzajmyWmZ0mLZVp10JAzBqVu4DsoQOoQL/gERYA1gDb/cwKpiLm80Y4ycyR7krKE 74ErPyPQWC5nDp1+PmkytMxwPrT+bnEyWzhrh1j+O7I47gUiSU/Ga5ervBfqaeXZEn13 zcCpbu4h7ABcMWx2EIZ0/HE3SJNPnO/zwE61EF1pFkvCldkmVgfGFyOyCf7CnVT2eOim aWJbK9IECC6d5JwGD/zsffFRo8uyqA8nbsWsnniYuh4MHKIKX88WZYeETbzDwMxHOtrS hdQdYYnuLXyGvQxAzsDs98AzOc6kxOlGUfa/IpagygbF9WjV8q/gOHxxB6pbyrNMTfIB lOWQ== X-Gm-Message-State: AO0yUKVRn8KND+T6Ak40lvmXzfG0X+mG5MiLBhnp6Ju75gDbykfK2VgS Xj9vH3c806knrjNQniaE7Os= X-Google-Smtp-Source: AK7set8MQ7nb757pRmC5Pb3vJrKbay8ImaZlfRJ0dycS/tffPYpsUprWV45nvKKw9aSsByrvEv5MWA== X-Received: by 2002:a2e:80ce:0:b0:295:945d:dbac with SMTP id r14-20020a2e80ce000000b00295945ddbacmr3182258ljg.34.1677764337535; Thu, 02 Mar 2023 05:38:57 -0800 (PST) Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id l13-20020ac2430d000000b004d85f2acd8esm2118048lfh.295.2023.03.02.05.38.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Mar 2023 05:38:57 -0800 (PST) Message-ID: Date: Thu, 2 Mar 2023 20:38:55 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] lisp/ob-screen.el: Support ~:var~ header args for babel blocks Content-Language: en-US To: Ken Mankoff Cc: emacs-orgmode@gnu.org References: <87pm9z8089.fsf@t480.home> <87y1om7w23.fsf@t480.home> <96a91a35-eeb6-55d3-683d-5d51ff6d496e@gmail.com> <877cw5aiab.fsf@t480.home> <87sfet7kul.fsf@t480.home> <0e841ec9-f770-4f4f-a5e6-eb15290ab8a7@gmail.com> <87k003swax.fsf@t480.home> From: Max Nikulin Mail-Followup-To: Ken Mankoff , emacs-orgmode@gnu.org In-Reply-To: <87k003swax.fsf@t480.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::22c; envelope-from=manikulin@gmail.com; helo=mail-lj1-x22c.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.092, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Spam-Score: -1.89 X-Spam-Score: -1.89 X-Migadu-Scanner: scn0.migadu.com X-Migadu-Queue-Id: 209E815C33 List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: 8r1Zx5mEty+K On 27/02/2023 08:59, Ken Mankoff wrote: >> Have you tried to compile using make? I expect a warning due to missed >> (require 'ob-shell). > > Make did not complain about this, but did suggest mapcar -> mapc. I did not expect it. However I still think, it is better to add such require. It should not be an error if a user is going to use ob-screen without explicitly loading ob-shell. > Both fixed. Should these be separate patches (3 total), or two - one for > the new feature, and one 'cleanup'? I do not think it really matters if 2 minor fixes will be committed separately or as a single patch. >> I noticed that ob-core besides org-babel-default-header-args:LANG uses >> org-babel-header-args:LANG. The latter is not defined in ob-screen, >> however I am unsure concerning its effect (completion?). > > I don't understand this either. Anyway it is unrelated to the patch we are currently discussing. It is an option for the future. As to calling org-babel-variable-assignments: for specific shell, as Ihor suggests, it should be something like (untested) (funcall (intern (concat "org-babel-variable-assignments:" (plist-get params :cmd)) params)