From: Max Nikulin <manikulin@gmail.com>
To: Ken Mankoff <mankoff@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] lisp/ob-screen.el: Support ~:var~ header args for babel blocks
Date: Thu, 2 Mar 2023 20:38:55 +0700 [thread overview]
Message-ID: <b3b8715e-dbbc-e6a4-ba04-fb025035dcc7@gmail.com> (raw)
In-Reply-To: <87k003swax.fsf@t480.home>
On 27/02/2023 08:59, Ken Mankoff wrote:
>> Have you tried to compile using make? I expect a warning due to missed
>> (require 'ob-shell).
>
> Make did not complain about this, but did suggest mapcar -> mapc.
I did not expect it. However I still think, it is better to add such
require. It should not be an error if a user is going to use ob-screen
without explicitly loading ob-shell.
> Both fixed. Should these be separate patches (3 total), or two - one for
> the new feature, and one 'cleanup'?
I do not think it really matters if 2 minor fixes will be committed
separately or as a single patch.
>> I noticed that ob-core besides org-babel-default-header-args:LANG uses
>> org-babel-header-args:LANG. The latter is not defined in ob-screen,
>> however I am unsure concerning its effect (completion?).
>
> I don't understand this either.
Anyway it is unrelated to the patch we are currently discussing. It is
an option for the future.
As to calling org-babel-variable-assignments: for specific shell, as
Ihor suggests, it should be something like (untested)
(funcall (intern (concat "org-babel-variable-assignments:"
(plist-get params :cmd))
params)
next prev parent reply other threads:[~2023-03-02 13:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 17:03 [PATCH] lisp/ob-screen.el: Support ~:var~ header args for babel blocks Ken Mankoff
2023-02-24 18:33 ` Ken Mankoff
2023-02-25 3:51 ` Max Nikulin
2023-02-25 15:14 ` Ken Mankoff
2023-02-25 15:19 ` Ken Mankoff
2023-02-25 16:05 ` Max Nikulin
2023-02-25 16:47 ` Ken Mankoff
2023-02-26 10:11 ` Max Nikulin
2023-02-27 1:59 ` Ken Mankoff
2023-02-28 10:40 ` Ihor Radchenko
2023-03-16 4:12 ` Ken Mankoff
2023-03-16 10:22 ` Ihor Radchenko
2023-03-16 15:09 ` [PATCH v4] " Max Nikulin
2023-03-17 11:41 ` Max Nikulin
2023-03-18 12:08 ` Ihor Radchenko
2023-03-19 14:42 ` Ken Mankoff
2023-03-21 14:12 ` Max Nikulin
2023-03-02 13:38 ` Max Nikulin [this message]
2023-02-26 12:18 ` [PATCH] " Ihor Radchenko
2023-02-27 1:59 ` Ken Mankoff
2023-02-27 19:43 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3b8715e-dbbc-e6a4-ba04-fb025035dcc7@gmail.com \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mankoff@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).