From: "Charles C. Berry" <ccberry@ucsd.edu>
To: Aaron Ecay <aaronecay@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: New patches WAS Re: [PATCH] inline src block results can be removed
Date: Sat, 24 Jan 2015 21:01:05 -0800 [thread overview]
Message-ID: <alpine.OSX.2.00.1501242042130.4500@charles-berrys-macbook.local> (raw)
In-Reply-To: <87a917hd9u.fsf@gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1461 bytes --]
On Sat, 24 Jan 2015, Aaron Ecay wrote:
> Hi Chuck,
>
> 2015ko urtarrilak 24an, "Charles C. Berry"-ek idatzi zuen:
>> All tests passed (modulo a few shell and fortran issues unique to my setup
>> which also failed for master).
>>
>> Then I did an update and `git merge master' and got a pile of errors due to
>>
>> commit fda70440f49292197d76ce4c2727dbf426bc65f3
>> Author: Aaron Ecay <aaronecay@gmail.com>
>> Date: Thu Jan 22 00:59:04 2015 -0500
>>
>> which explicitly tests for conformity to the old inline regime or
>> at least depends on it.
>
> By “pile of errors” do you mean test failures or merge conflicts?
> AFAICS the patches you sent to the list did not touch the test suite, so
> there should not be merge conflicts. But maybe you had a patch for the
> tests that you didn’t send. (If I somehow caused merge conflicts for
> your patches, I would offer to help fix them.)
>
> The test suite depends on the specific way in which inline results
> are inserted, so it will need to be updated to take account of your
> change.
`test failures' is what I meant - sorry for being vague.
No merge issues.
I will mostly have to edit in the `{{{results(' `)}}}' wrappers in the
places where the expected results are specified or specify [:results ...]
to make the result agree with the specification, I guess.
Thanks for your commit, BTW. I was feeling guilty about not having any
tests, so my conscience is off the hook now.
Chuck
next prev parent reply other threads:[~2015-01-25 5:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 0:49 [PATCH] inline src block results can be removed Charles C. Berry
2014-11-12 1:10 ` Andreas Leha
2014-11-12 6:58 ` Charles C. Berry
2014-11-12 19:34 ` Aaron Ecay
2014-11-12 23:47 ` Charles C. Berry
2014-11-13 17:48 ` Nicolas Goaziou
2014-11-13 19:06 ` Andreas Leha
2014-11-14 17:43 ` Charles C. Berry
2014-11-14 20:39 ` Nicolas Goaziou
2014-11-14 23:04 ` Aaron Ecay
2014-11-16 0:10 ` Nicolas Goaziou
2014-11-15 20:22 ` Charles C. Berry
2014-11-16 23:23 ` Nicolas Goaziou
2014-11-24 9:48 ` Daniele Pizzolli
2014-11-24 10:18 ` Andreas Leha
2015-01-13 0:48 ` New patches WAS " Charles C. Berry
2015-01-16 22:41 ` Nicolas Goaziou
2015-01-19 3:22 ` Charles C. Berry
2015-01-19 17:53 ` Nicolas Goaziou
2015-01-19 19:31 ` Charles C. Berry
2015-01-20 23:30 ` Nicolas Goaziou
2015-01-22 3:07 ` Charles C. Berry
2015-01-22 23:08 ` Nicolas Goaziou
2015-01-24 22:47 ` Charles C. Berry
2015-01-25 1:14 ` Aaron Ecay
2015-01-25 5:01 ` Charles C. Berry [this message]
2015-01-29 20:31 ` Charles C. Berry
2015-01-17 3:22 ` Aaron Ecay
2015-01-17 22:20 ` Nicolas Goaziou
2015-01-18 19:13 ` Aaron Ecay
2015-01-18 22:34 ` Nicolas Goaziou
2015-01-18 22:55 ` Aaron Ecay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.OSX.2.00.1501242042130.4500@charles-berrys-macbook.local \
--to=ccberry@ucsd.edu \
--cc=aaronecay@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).