emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: gerard.vermeulen@posteo.net
To: Emacs orgmode <emacs-orgmode@gnu.org>
Subject: [BUG]: unexpected behavior related to org-indent-block
Date: Thu, 11 Jan 2024 11:33:23 +0000	[thread overview]
Message-ID: <abc9e25cebcba21d941435e5f39e72d9@posteo.net> (raw)

Below, I show 2 commands to be run with point on a source block.
I expect that those commands modify an Org file identically, but
they do not.  It fails when `org-indent-block' is called in a
loop after each `(insert (org-element-interpret-data copy))' and
it works when `org-indent-block' is called in a separate loop
after insertion of all `(org-element-interpret-data copy)'s:

#+begin_src emacs-lisp :results silent
(defun make-2-indent-fails ()
   "Make 2 modified blocks, but fails."
   (interactive)
   (let ((copy (org-element-copy (org-element-at-point)))
         (n 0))
     (delete-region (org-element-begin copy) (org-element-end copy))
     (while (< n 2)
       (cl-incf n)
       (org-element-put-property copy :value (format "copy %s" n))
       (insert (org-element-interpret-data copy))
       (org-indent-block))))

(defun make-2-indent-works ()
   "Make 2 modified blocks, and works."
   (interactive)
   (let ((copy (org-element-copy (org-element-at-point)))
         (n 0))
     (delete-region (org-element-begin copy) (org-element-end copy))
     (while (< n 2)
       (cl-incf n)
       (org-element-put-property copy :value (format "copy %s" n))
       (insert (org-element-interpret-data copy)))
     (org-previous-block n)
     (while (> n 0)
       (cl-decf n)
       (org-indent-block))))
#+end_src

Example block:
---
#+begin_src emacs-lisp
<point>
#+end_src
---
make-2-indent-fails results in
---
#+begin_src emacs-lisp
copy 1
#+end_src
---
make-2-indent-works results in
---
#+begin_src emacs-lisp
copy 1
#+end_src
#+begin_src emacs-lisp
copy 2
#+end_src
---

I think that it is also weird that this bug does not show up in
this ERT test while it does outside ERT:
#+begin_src emacs-lisp :results silent
(ert-deftest test-make-2-indent-fails ()
   "Test unfolded `make-2-indent-fails'."
   (org-test-with-temp-text "
,#+begin_src emacs-lisp
<point>
,#+end_src
"
     (let ((copy (org-element-copy (org-element-at-point)))
           (word "copy")
           (n 0))
       (delete-region (org-element-begin copy) (org-element-end copy))
       (while (< n 2)
         (cl-incf n)
         (org-element-put-property copy :value (format "%s %s" word n))
         ;; Why does this work inside ERT and not outside ERT?
         (insert (org-element-interpret-data copy))
         (org-indent-block))
       (message "`%s'" (buffer-substring (point-min) (point-max)))
       (goto-char (point-min))
       (while (> n 0)
         (cl-decf n)
         (should (re-search-forward word)))
       (should-not (re-search-forward word nil 'noerror)))))
#+end_src

Regards -- Gerard

next             reply	other threads:[~2024-01-11 11:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-11 11:33 gerard.vermeulen [this message]
2024-01-11 12:37 ` [BUG]: unexpected behavior related to org-indent-block Ihor Radchenko
2024-01-11 14:14   ` gerard.vermeulen
2024-01-11 15:04     ` Ihor Radchenko
2024-01-11 15:48       ` gerard.vermeulen
2024-01-11 16:01         ` Ihor Radchenko
2024-01-11 16:41           ` gerard.vermeulen
2024-01-11 17:28             ` Ihor Radchenko
2024-01-11 18:06               ` gerard.vermeulen
2024-01-11 18:18                 ` Ihor Radchenko
2024-01-12 19:19   ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abc9e25cebcba21d941435e5f39e72d9@posteo.net \
    --to=gerard.vermeulen@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).