Re: Not archiving incompletes TODOs by accident with org-archive-subtree

From: Carsten Dominik <dominik@science.uva.nl>
To: matiyam <matiyam@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Not archiving incompletes TODOs by accident with org-archive-subtree
Date: Thu, 29 Mar 2007 16:38:22 +0200	[thread overview]
Message-ID: <a7d025b500046cdc5a1445fb7a7d0805@science.uva.nl> (raw)
In-Reply-To: <eug66q$sf3$2@sea.gmane.org>

On Mar 29, 2007, at 12:59, matiyam wrote:

> Hi!
>
> I have sometimes archives some headings with incompleted TODOs by 
> accident.
> I find that calling C-u C-c C-x C-s (org-archive-subtree with 
> finde-done =
> t) is a lot of typing that C-c $ .

Not sure if I understand this.  The problem you describe is, as
far as I can see, that you accidently archive trees that still
contain unfinished subtrees.  The solution it seems would be a
warning that the tree contains unfinished entries.

The prefix argument to the archiving function serves a
completely different purpose.  It finds *subtrees* of the
current tree that are completely done, and archives those
subtrees.

So while I can see that someone would want to do what you propose,
I cannot see how that is the solution to the problem you describe.

- Carsten

>
> So, to avoid this, i have introduced a new variable,
> org-archive-subtree-always-call-find-done, so that when it's set to 't 
> ,
> org-archive-subtree will always behave as if called with find-done set
> to 't.
> (By default is set to nil, so org-archive-subtree will behave as 
> always for
> the rest of the world)
>
> Maybe it's interesting to somebody, and it's a really small patch:
>
> (Against 4.69 version)
>
> === modified file 'org.el'
> --- org.el      2007-03-29 10:29:19 +0000
> +++ org.el      2007-03-29 10:48:40 +0000
> @@ -618,6 +618,12 @@
>    :group 'org-archive
>    :type 'boolean)
>
> +(defcustom org-archive-subtree-always-call-find-done nil
> +  "Non-nil will make that calling org-archive-subtree behaves as if 
> called
> with param find-done=t."
> +  :group 'org-archive
> +  :type 'boolean)
> +
> +
>  (defgroup org-table nil
>    "Options concerning tables in Org-mode."
>    :tag "Org Table"
> @@ -5566,7 +5572,7 @@
>  1 trees.  If the cursor is on a headline, only try the direct 
> children of
>  this heading. "
>    (interactive "P")
> -  (if find-done
> +  (if (or find-done org-archive-subtree-always-call-find-done)
>        (org-archive-all-done)
>      ;; Save all relevant TODO keyword-relatex variables
>
>
> Thanks a lot for org-mode, it's great!!
>
> -- M
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
>

--
Carsten Dominik
Sterrenkundig Instituut "Anton Pannekoek"
Universiteit van Amsterdam
Kruislaan 403
NL-1098SJ Amsterdam
phone: +31 20 525 7477