From mboxrd@z Thu Jan 1 00:00:00 1970 From: stardiviner Subject: Re: [PATCH] contrib: ob-sclang: Fix compilation issue. Date: Mon, 26 Mar 2018 20:22:42 +0800 Message-ID: References: <878tahvytr.fsf@gmail.com> <5c112467-9e76-4e2f-6c29-05e2fa04f6a5@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------096B0B07CCD25EE8BC4C9266" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0R9I-0004Zb-Qw for emacs-orgmode@gnu.org; Mon, 26 Mar 2018 08:22:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0R9E-0002VS-Qc for emacs-orgmode@gnu.org; Mon, 26 Mar 2018 08:22:52 -0400 Received: from mail-pf0-x229.google.com ([2607:f8b0:400e:c00::229]:42903) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f0R9E-0002Uw-Ia for emacs-orgmode@gnu.org; Mon, 26 Mar 2018 08:22:48 -0400 Received: by mail-pf0-x229.google.com with SMTP id a16so7433646pfn.9 for ; Mon, 26 Mar 2018 05:22:48 -0700 (PDT) Received: from [0.0.0.0] ([119.28.89.243]) by smtp.gmail.com with ESMTPSA id m9sm32242240pff.143.2018.03.26.05.22.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Mar 2018 05:22:45 -0700 (PDT) In-Reply-To: <5c112467-9e76-4e2f-6c29-05e2fa04f6a5@gmail.com> Content-Language: en-US List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org This is a multi-part message in MIME format. --------------096B0B07CCD25EE8BC4C9266 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit After dive into scel source code, I use cmake build fix. This seems an old problem. Now fixed. On 03/26/2018 07:38 PM, stardiviner wrote: > > You `(require 'sclang)` cause error on `(require 'sclang-vars)` > failed. Because there is no file `sclang-vars.el`. Only file > `sclang-vars.el.in` for built-time defaults. When user load sclang > from source code of `scel`. This will cause error. > > Really don't understand why you have to `(require 'sclang)` instead of > `(require 'sclang-interp)`? Can you tell me why? > > > On 03/25/2018 07:27 AM, Maxim Cournoyer wrote: >> Hello! >> >> The attached patch fixes a byte compilation issue in ob-sclang.el. >> >> Thank you! >> >> Maxim >> > --------------096B0B07CCD25EE8BC4C9266 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

After dive into scel source code, I use cmake build fix. This seems an old problem. Now fixed.


On 03/26/2018 07:38 PM, stardiviner wrote:

You `(require 'sclang)` cause error on `(require 'sclang-vars)` failed. Because there is no file `sclang-vars.el`. Only file `sclang-vars.el.in` for built-time defaults. When user load sclang from source code of `scel`. This will cause error.

Really don't understand why you have to `(require 'sclang)` instead of `(require 'sclang-interp)`? Can you tell me why?


On 03/25/2018 07:27 AM, Maxim Cournoyer wrote:
Hello!

The attached patch fixes a byte compilation issue in ob-sclang.el.

Thank you!

Maxim


--------------096B0B07CCD25EE8BC4C9266--