emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Clemens <clemens.radermacher@posteo.de>
To: Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Use completing-read-multiple for org-set-tags-command
Date: Mon, 20 Jul 2020 08:03:04 +0200	[thread overview]
Message-ID: <a568b237-fb57-297a-4316-a58f1320a946@posteo.de> (raw)
In-Reply-To: <87blkaeuor.fsf@kyleam.com>

 > Note, though, that org-set-tags-command already supports completing
 > multiple tags through org-tags-completion-function, which it passes as
 > the COLLECTION argument to completing-read.  In order to see that in
 > action, you may need to tell the completion library you use to fall back
 > to the built-in completing-read.  As an example, I use Helm and have
 > this in my configuration:
 >
 >      (add-to-list 'helm-completing-read-handlers-alist
 >                   '(org-set-tags-command))
 >

I looked and helm-org does include a similar adjustment to make it work
correctly:


https://github.com/emacs-helm/helm-org/blob/b7a18dfc17e8b933956d61d68c435eee03a96c24/helm-org.el#L490-L523

My patch aims to get you completion with the default completion and also
for any framework that complies to it out of the box. Without my patch
(and without helm-org) you don't get completion after the first tag I think.


  reply	other threads:[~2020-07-20  6:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-19 12:49 Clemens
2020-07-19 14:26 ` Clemens
2020-07-19 14:58   ` Clemens
2020-07-19 14:59   ` Clemens
2020-07-20  3:23 ` Kyle Meyer
2020-07-20  6:03   ` Clemens [this message]
2020-07-22  4:26     ` Kyle Meyer
2020-07-22  7:04       ` Clemens
2020-07-22  7:16       ` Clemens
2020-07-22 12:37         ` Clemens
2020-07-23  4:37           ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a568b237-fb57-297a-4316-a58f1320a946@posteo.de \
    --to=clemens.radermacher@posteo.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    --subject='Re: [PATCH] Use completing-read-multiple for org-set-tags-command' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).