emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] org-compat.el (org-mode-flyspell-verify): Do not spell check code in headline
@ 2021-03-07 16:27 Sébastien Miquel
  2021-03-15  2:56 ` Kyle Meyer
  0 siblings, 1 reply; 3+ messages in thread
From: Sébastien Miquel @ 2021-03-07 16:27 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

Hi,

Currently code and verbatim snippets, and LaTeX fragments are spell
checked by `flyspell` if they're in a headline.

The attached patch fixes that.

-- 
Sébastien Miquel

[-- Attachment #2: 0001-org-compat.el-org-mode-flyspell-verify-Do-not-check-.patch --]
[-- Type: text/x-patch, Size: 1625 bytes --]

From b4291ce0ea455af499e75d3c9313183a0e8f46ec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Miquel?= <sebastien.miquel@posteo.eu>
Date: Sun, 7 Mar 2021 17:06:34 +0100
Subject: [PATCH] org-compat.el (org-mode-flyspell-verify): Do not check code
 in headline

* lisp/org-compat.el (org-mode-flyspell-verify): Do not spell check
code, verbatim and LaTeX fragments in headline title.
---
 lisp/org-compat.el | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/lisp/org-compat.el b/lisp/org-compat.el
index 8cbf33137..3d45bed7f 100644
--- a/lisp/org-compat.el
+++ b/lisp/org-compat.el
@@ -1025,8 +1025,7 @@ ELEMENT is the element at point."
 (defun org-mode-flyspell-verify ()
   "Function used for `flyspell-generic-check-word-predicate'."
   (if (org-at-heading-p)
-      ;; At a headline or an inlinetask, check title only.  This is
-      ;; faster than relying on `org-element-at-point'.
+      ;; At a headline or an inlinetask, check title only.
       (and (save-excursion (beginning-of-line)
 			   (and (let ((case-fold-search t))
 				  (not (looking-at-p "\\*+ END[ \t]*$")))
@@ -1035,7 +1034,9 @@ ELEMENT is the element at point."
 	   (match-beginning 4)
 	   (>= (point) (match-beginning 4))
 	   (or (not (match-beginning 5))
-	       (< (point) (match-beginning 5))))
+	       (< (point) (match-beginning 5)))
+           ;; Ignore checks in code, verbatim and others.
+           (org--flyspell-object-check-p (org-element-at-point)))
     (let* ((element (org-element-at-point))
 	   (post-affiliated (org-element-property :post-affiliated element)))
       (cond
-- 
2.30.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] org-compat.el (org-mode-flyspell-verify): Do not spell check code in headline
  2021-03-07 16:27 [PATCH] org-compat.el (org-mode-flyspell-verify): Do not spell check code in headline Sébastien Miquel
@ 2021-03-15  2:56 ` Kyle Meyer
  2021-03-15  6:40   ` Sébastien Miquel
  0 siblings, 1 reply; 3+ messages in thread
From: Kyle Meyer @ 2021-03-15  2:56 UTC (permalink / raw)
  To: sebastien.miquel; +Cc: emacs-orgmode

Sébastien Miquel writes:

> Subject: [PATCH] org-compat.el (org-mode-flyspell-verify): Do not check code
>  in headline
>
> * lisp/org-compat.el (org-mode-flyspell-verify): Do not spell check
> code, verbatim and LaTeX fragments in headline title.

Makes sense.  Hopefully the cost of the org-element-at-point call isn't
too noticeable.

Applied to master (7c4d057cd), adding a TINYCHANGE cookie to the commit
message.  You're bumping up against the cumulative number of changes
allowed without assigning copyright, so please consider completing the
copyright paperwork (or, if you've already done so, please let me know
I'll update your status listed at
<https://orgmode.org/worg/org-contribute.html>).

Thanks.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] org-compat.el (org-mode-flyspell-verify): Do not spell check code in headline
  2021-03-15  2:56 ` Kyle Meyer
@ 2021-03-15  6:40   ` Sébastien Miquel
  0 siblings, 0 replies; 3+ messages in thread
From: Sébastien Miquel @ 2021-03-15  6:40 UTC (permalink / raw)
  To: kyle; +Cc: emacs-orgmode

Kyle Meyer writes:
> Applied to master (7c4d057cd), adding a TINYCHANGE cookie to the commit
> message.  You're bumping up against the cumulative number of changes
> allowed without assigning copyright, so please consider completing the
> copyright paperwork (or, if you've already done so, please let me know
> I'll update your status listed at
> <https://orgmode.org/worg/org-contribute.html>).

Thanks. I have completed the paperwork.

-- 
Sébastien Miquel



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-15  6:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-07 16:27 [PATCH] org-compat.el (org-mode-flyspell-verify): Do not spell check code in headline Sébastien Miquel
2021-03-15  2:56 ` Kyle Meyer
2021-03-15  6:40   ` Sébastien Miquel

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).