From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id cKj0OK4h9mXQUQAAqHPOHw:P1 (envelope-from ) for ; Sat, 16 Mar 2024 23:48:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id cKj0OK4h9mXQUQAAqHPOHw (envelope-from ) for ; Sat, 16 Mar 2024 23:48:15 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=ricklupton.name header.s=fm3 header.b=c5bvWOhU; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="O 2PVvHh"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=ricklupton.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1710629294; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=PcaR9QGxlOpZEPUVVbH/6YI9hjyZq8Ak0WKSjy7jUuU=; b=UlRpvwcfApi3s1lRq1msrtUisMiM3goIOUtmChqZ7249WJOKYYMCQo1AeVaP2IoxcWE+6L yh3kfqa156MWaiSPafXrzBvk5/hkoSZ+UsMmdaaKYpjmYf73EHdWKENUyuV47HfbGODXri sV6R4oeePqztpCUdtMSOAvoJ8MConwYUF4pbYlb2k0mPE/KSEeJWJCuOBSCw+NRwLPzGFD MYxIdP7TPJ7FcVLAWglwwk0zhf2ErUov1OyI+2o1yF8E3Y6RXIOk+lgg5ssbdpHEzuW/Kv 36LkALQp0hyCAdXj98RgWN5GmN52Wp3wDEVEt9dsKF3T4UJ8OHIraK5AbB8t1g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=ricklupton.name header.s=fm3 header.b=c5bvWOhU; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="O 2PVvHh"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=ricklupton.name ARC-Seal: i=1; s=key1; d=yhetil.org; t=1710629294; a=rsa-sha256; cv=none; b=kTT2b0IOm/DLuTTFctDs0f+SXVfr57L2KXSu5recJknnHkOmg1SssedtRUO11gujuMIlCy wzIWSyotLnqjLyBAvcH+S8luxzmskiIoUwcvRQGu8n22ZzmNyK/9KT3KeXbhZlfa95RnWd jzoUmZztacZnGd+3Fh5oQx14gEM0KERNTmWuAwAlOqUH3aNlmntYSsOHdWI4EJVvSTF5aE Rlp63tHh+MhviN7hy0vUwV/1i+HicznQ68pfXH8ZkpXsjPpQUXb3N4qSz2202S/Jo0FFx5 NrsznVongthZUoOM5dj0QM8SCX3xp/myUWhmzIQXP7C8N1q4EZemxR4qgW+FLg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3281F181A5 for ; Sat, 16 Mar 2024 23:48:13 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlcoD-0004Cy-Pu; Sat, 16 Mar 2024 18:47:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlcoA-0004Co-Pa for emacs-orgmode@gnu.org; Sat, 16 Mar 2024 18:47:20 -0400 Received: from wfhigh3-smtp.messagingengine.com ([64.147.123.154]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlco8-0006F9-HT for emacs-orgmode@gnu.org; Sat, 16 Mar 2024 18:47:18 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfhigh.west.internal (Postfix) with ESMTP id 173DC180006E; Sat, 16 Mar 2024 18:47:12 -0400 (EDT) Received: from imap50 ([10.202.2.100]) by compute2.internal (MEProxy); Sat, 16 Mar 2024 18:47:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ricklupton.name; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm3; t=1710629231; x=1710715631; bh=PcaR9QGxlOpZEPUVVbH/6YI9hjyZq8Ak 0WKSjy7jUuU=; b=c5bvWOhUIXjQATSEk/V/wFkUF78RTRBOgPsWqCWS2/0h3ImQ nH77YDMG48a5dGoW47oZ113bjaqpVwP8rdNNm3sGcS4AKmMMWLo9i4qlDMr3QeMj 0JbskGZ5C9mygJgWwWYw21V/EPdqz8U+ltE1jfpM5Gh0HEAUfp7zUPTpkg8xy7bO hIy56i9jukka+fktRNxN5v3LLpvlqPbyodwNVUku0WYUT+57r8s8hXLKOvkhpX8j Zpl87KOIVZ1rkAa2TDU7wnLvvvHyPFhXCZXZ+3TM/VRcF466zq8tYg9udiuiab9t EgpEPrIMMeM+5Eb+oVBb5wTc3fPsXpdji33CPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1710629231; x= 1710715631; bh=PcaR9QGxlOpZEPUVVbH/6YI9hjyZq8Ak0WKSjy7jUuU=; b=O 2PVvHhXAp5Kqi+UASc+bce8N8PLe4mnHC8OruG2Td8xhrKeqkomB6eG2V34u/ZpK fRpWAGhJkGEm/BQkIcvrSzUoJEYgXipMcXh2V6zuOKg80wCfoG6obezYngcKvGSy 0SxehIKIOLlGN7mUmrrc3+n8n9ZNnvUW8XLjUV9Llb+VxzaZGInbnD1N4IH6EvT/ 8VgwP+AZcs1rp1dupn3Z4zpUn5UcQSeupU733U4IhQuyulL1SrFAaATCx0qhw0C1 fJGvaAtu/F099VoNvUXWaJiFTNwCGVmL3oZPCSC5+TiC7l+IQHG04uG2BkquU74o vHUUHi3miTxLhMA7V5DSA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrkeefgddtfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvfevufgtgfesth hqredtreerjeenucfhrhhomhepfdftihgtkhcunfhuphhtohhnfdcuoehmrghilhesrhhi tghklhhuphhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnheptdevgeefudekgedtte fggfdttdduueeihfeljefffedtffejheeivdeikeeuheejnecuffhomhgrihhnpehgnhhu rdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrihhlsehrihgtkhhluhhpthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i0143436f:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1EE4A1700096; Sat, 16 Mar 2024 18:47:11 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-300-gdee1775a43-fm-20240315.001-gdee1775a MIME-Version: 1.0 Message-Id: In-Reply-To: <87zfv2wbyq.fsf@localhost> References: <715e7a79-2107-4c61-8b7c-26b68e680451@app.fastmail.com> <87zfv2wbyq.fsf@localhost> Date: Sat, 16 Mar 2024 22:46:42 +0000 From: "Rick Lupton" To: "Ihor Radchenko" Cc: "Y. E." Subject: Re: [PATCH] Allow external libraries (org-roam) to supply org-id locations Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=64.147.123.154; envelope-from=mail@ricklupton.name; helo=wfhigh3-smtp.messagingengine.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -8.85 X-Spam-Score: -8.85 X-Migadu-Queue-Id: 3281F181A5 X-TUID: Ayzw21o4z25T On Wed, 13 Mar 2024, at 12:30 PM, Ihor Radchenko wrote: > I think that we can do it simpler. [...] > The idea is to use Emacs' advice machinery to allow third-party code > alter the functions stored in link parameters. I was avoiding this because I thought it was only recommended (in the el= isp manual) to use advice directly by users, not in libraries (like, I a= ssume, org-roam): > If you are writing code for release, for others to use, try to avoid i= ncluding advice in it. If the function you want to advise has no hook to= do the job, please talk with the Emacs developers about adding a suitab= le hook. Especially, Emacs=E2=80=99s own source files should not put adv= ice on functions in Emacs. (There are currently a few exceptions to this= convention, but we aim to correct them.) It is generally cleaner to cre= ate a new hook in foo, and make bar use the hook, than to have bar put a= dvice in foo. (https://www.gnu.org/software/emacs/manual/html_node/elisp/Advising-Name= d-Functions.html) But I don't mind either way. I agree your approach is simpler if it's a= reasonable way for a third party library like org-roam to extend the or= g id functions. Thanks, Rick