From: Phillip Lord <phillip.lord@newcastle.ac.uk>
To: "Christoffer Stjernlöf" <a@xkqr.org>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: Bug: org-drill-entry-empty-p should use outline-forward-same-level and not outline-next-heading [9.1.6 (9.1.6-48-gfe7619-elpaplus @ /Users/christoffer/.emacs.d/elpa/org-plus-contrib-20180212/)]
Date: Mon, 22 Jul 2019 13:02:07 +0000 [thread overview]
Message-ID: <WM!b82e335e182d2fdaa9924646cd0bc2de17260ebcaad8ba02784270c42e850babc5c55c97cdf11f9ae1e1c7d6c05e9615!@mailhub-mx3.ncl.ac.uk> (raw)
In-Reply-To: <WM!6459e2a8e0f34a4538738dadf66f2587cc46f8eb3ba97abfa40c92bbc5a1c3edc0be21c82dc04dbc95c8871ec704862a!@mailhub-mx3.ncl.ac.uk> ("Christoffer Stjernlöf"'s message of "Fri, 19 Jul 2019 12:56:50 +0200")
Indeed, org-drill-entry-empty-p returns t and considers this entry
empty. But why is this wrong? How are you using this kind of entry? Do
you put the question in the title?
BTW, I am maintaining org-drill at:
https://gitlab.com/phillord/org-drill/
now, so you might be better raising issues there.
Phil
a@xkqr.org (Christoffer Stjernlöf) writes:
> Remember to cover the basics, that is, what you expected to happen and
> what in fact did happen. You don't know how to make a good report? See
>
> https://orgmode.org/manual/Feedback.html#Feedback
>
> Your bug report will be posted to the Org mailing list.
> ------------------------------------------------------------------------
>
> I have noticed that some of my drill entries are skipped by org-drill,
> and only
> recently took the time to try to troubleshoot why – apparently
> org-drill-entry-empty-p returns t for my entries, because they look like
> the
> following:
>
> -----
> * Entry question? :drill:
> SCHEDULED: <2019-04-05 Fri>
> :PROPERTIES:
> ...
> :END:
>
> ** The Answer
>
> Some text
> ----
>
> Since org-drill-entry-empty-p only looks from the end of the
> metadata/properties
> and until outline-next-heading, it will consider this drill entry empty
> – even
> though this is not at all my intention. This would be fixed by replacing
> (outline-next-heading) with (outline-forward-same-level 1) in
> org-entry-empty-p.
> I'm not sure whether this has any other adverse effect, but I can't see
> how it
> would make things worse, at least.
>
> Emacs : GNU Emacs 26.2 (build 1, x86_64-apple-darwin18.6.0, Carbon
> Version 158 AppKit 1671.5)
> of 2019-06-15
> Package: Org mode version 9.1.6 (9.1.6-48-gfe7619-elpaplus @
> /Users/christoffer/.emacs.d/elpa/org-plus-contrib-20180212/)
>
--
Phillip Lord, Phone: +44 (0) 191 208 7827
Biology, Medicine, Computing Email: phillip.lord@newcastle.ac.uk
School of Computing, http://homepages.cs.ncl.ac.uk/phillip.lord
Room 5.012 Urban Sciences Building, skype: russet_apples
Newcastle University, twitter: phillord
NE4 5TG
next prev parent reply other threads:[~2019-07-22 13:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 10:56 Bug: org-drill-entry-empty-p should use outline-forward-same-level and not outline-next-heading [9.1.6 (9.1.6-48-gfe7619-elpaplus @ /Users/christoffer/.emacs.d/elpa/org-plus-contrib-20180212/)] Christoffer Stjernlöf
[not found] ` <WM!6459e2a8e0f34a4538738dadf66f2587cc46f8eb3ba97abfa40c92bbc5a1c3edc0be21c82dc04dbc95c8871ec704862a!@mailhub-mx3.ncl.ac.uk>
[not found] ` <87h87eb4tt.fsf@newcastle.ac.uk>
2019-07-22 13:02 ` Phillip Lord [this message]
2020-02-03 20:56 ` Bastien
2020-02-03 20:55 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='WM'\!'b82e335e182d2fdaa9924646cd0bc2de17260ebcaad8ba02784270c42e850babc5c55c97cdf11f9ae1e1c7d6c05e9615'\!'@mailhub-mx3.ncl.ac.uk' \
--to=phillip.lord@newcastle.ac.uk \
--cc=a@xkqr.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).