emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Gustav Wikström" <gustav@whil.se>
To: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Minor fix for org-attach-dir
Date: Mon, 2 Sep 2019 21:26:59 +0000	[thread overview]
Message-ID: <VI1PR02MB303975CA7CDC9400162D1962DABE0@VI1PR02MB3039.eurprd02.prod.outlook.com> (raw)

For full transparency: An issue was found in org-brain [1] due to a
change in functionality of org-attach-dir in commit ae9cd4370.

I've given it some thought and figured that particular change in
functionality wasn't really needed and not obviously correct either.
So org-attach-dir will now check the filesystem (again) to see if the
attachment folder from DIR or ID property exist or not. The check can
be skipped with a new optional flag.

See commit 4b7eda1a2 for the fix.

[1] https://github.com/Kungsgeten/org-brain/pull/203

Regards
Gustav

             reply	other threads:[~2019-09-02 21:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-02 21:26 Gustav Wikström [this message]
2019-09-02 21:57 ` Minor fix for org-attach-dir Kyle Meyer
2019-09-03 20:20   ` Gustav Wikström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR02MB303975CA7CDC9400162D1962DABE0@VI1PR02MB3039.eurprd02.prod.outlook.com \
    --to=gustav@whil.se \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).