From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mFr6DT6282GlFQEAgWs5BA (envelope-from ) for ; Fri, 28 Jan 2022 10:24:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mJTHBj6282EL1wAAG6o9tA (envelope-from ) for ; Fri, 28 Jan 2022 10:24:14 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 832EC3621C for ; Fri, 28 Jan 2022 10:24:13 +0100 (CET) Received: from localhost ([::1]:41098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDNUK-0002hN-Lm for larch@yhetil.org; Fri, 28 Jan 2022 04:24:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDNTi-0002h1-MF for emacs-orgmode@gnu.org; Fri, 28 Jan 2022 04:23:34 -0500 Received: from mail-oln040092067010.outbound.protection.outlook.com ([40.92.67.10]:20939 helo=EUR02-AM5-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDNTg-0006g7-CQ for emacs-orgmode@gnu.org; Fri, 28 Jan 2022 04:23:33 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VYYjoh24hHmhHv4tNVqXqNvHY/uBLBao7Ykvfzoojjy1U4DMAe6bruE9MYtkJ9g1lDbxMcgt0jvlZdTKUFLZLgpYqZ3wNXq1kyy4w7bG0gCIDTRRNENBgSG5Wi0G9CPep0ePOR7oB9FShzb9BdwE6SaAimAmiM557W5qFTB5kkKTfTXD+QkBsVYxDwxtw87DH5WWdm0353504wyFG1Utz6J2ptSwWr4xeatMgI7Zy94QGdSiflQL9CJtWlfTdgQm5SLWhlKNs/jZgxOdPJ9rZh4HKzNk61yzOZfVy6CAMJJJSoYwNKrDUS123/zUsKVuGgRgMtOVXzq05VMm4b0u+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c2agahuj1LV/uqsV2EAbDIkt7DVspVjvQ1mdj0u5tMg=; b=Z4x+CLJBfJhGTCB7Un1Fi2dykHLfbuUvHo5UILoSFjqI7oll/eo84kWuy8HFIMmLjlpqZUZr+dRWycSYqNq+bGVZJfa/rXht5v4zVPduujnexvXgj4mc3NSGq4e3I4bXlEazEQ5UQjN+wsjxuCLec42JvVs+AAaVxjiNF/y7oaapBhga/dI19EFHnkiEjCC1BhsORtzJYX0tAxmXnumqEG2iRiPnPFIaHL98DqEckc/JhyptNt07s432so9LlQ64q9pXl94l1VJvnAH7uXhgMeniewRSwWKnq4y5Mnf5Wx+QDCOO/9v+qglLiQux9Bro4HazBeG576828NvFgawRyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c2agahuj1LV/uqsV2EAbDIkt7DVspVjvQ1mdj0u5tMg=; b=hkVsMeytW0s6lfmQUuIoVe3d9+JNRNDZmQwx505KAfrkv6FOu5SbE2LdSpEz14wX35oVzY9uursJUxMZHL5ViYxtUAIe/5mE7XPsAZs1fhAvIFP2HhmenP6vGzLgUwkvYF+oetM2Dn8/yFqUD2Y1xKmE8cZGk39/eSXiSFHzLXZgqUiHlw8gFos1Ize8mzeHmbP8ayazlWskFDCwRM7kSRtTqggr/sYRpP7CR7sDS+obyTFGGkuaTAz9Ix3438Vocbo2EnOtQZ0FKCTtS60ao2u5aJkirPowEyu1Zv+XSjG06VucYt2en10hvoxnuo3fTTMf3e8ubbXglusGdISQzw== Received: from PAXPR08MB6640.eurprd08.prod.outlook.com (2603:10a6:102:dd::5) by AM0PR08MB4001.eurprd08.prod.outlook.com (2603:10a6:208:129::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Fri, 28 Jan 2022 09:02:46 +0000 Received: from PAXPR08MB6640.eurprd08.prod.outlook.com ([fe80::30ca:c8bc:8796:adbd]) by PAXPR08MB6640.eurprd08.prod.outlook.com ([fe80::30ca:c8bc:8796:adbd%3]) with mapi id 15.20.4930.017; Fri, 28 Jan 2022 09:02:46 +0000 References: <875yqdtmb1.fsf@nicolasgoaziou.fr> User-agent: mu4e 1.7.0; emacs 29.0.50 From: "Christopher M. Miles" To: Samim Pezeshki Subject: [ISSUE] Re: [PATCH] lisp/org-agenda.el: Add header to agenda clock report table Date: Fri, 28 Jan 2022 17:01:36 +0800 In-reply-to: Message-ID: Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-TMN: [NTu4O4Rmn122LCK/aUCa0NhCK5qyDFDQ] X-ClientProxiedBy: HK2PR02CA0202.apcprd02.prod.outlook.com (2603:1096:201:20::14) To PAXPR08MB6640.eurprd08.prod.outlook.com (2603:10a6:102:dd::5) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 2 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9d666d20-aa8a-4fb3-2103-08d9e23cf384 X-MS-TrafficTypeDiagnostic: AM0PR08MB4001:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R+RvQ4j0GltEy0mUyon0qIIfEE1ZhQKk4U5YGGOKN0V50Njo4ZVxjlcHv0LRDnX0PPOiqiMWt/v1AYS7BgAmd5V2r+lbsrTgZvvN7RKLhRCtb7oPO2KvZqrjVr69P2t2zWA7Xxs8OnzcH/M2EpZBDHwz6DToS9HM5+WJYQWLucTsrCGt/c+C82k1+c2sXF1qAlmHbtT3WqoJepNtHMsyxTD9VeR8kZKdpqVg3ITSGK7BA78IKmH8x634QJ6N7AaNxzjGFFqS+qMZezUl1nSH9b2S99FHZBMr/+AN6kIsS6eVOZJfeMc+z9byuBXFVlXeBSJylRbqZol4rWakMQobrDgLYEAbSBIxichurWQYnzR5y/hrhMjGG0GUF3Gi9wkmCc4/O4e3ximNEOIaGl5bXlhJtf3W+zHqY8zuoxNnLvxV6NJaqROxO5baGStd40G371s7ZDx4Ctgy2F8NtMotO0CYlmCej92CUBdn9aziGCIqYQX91Q+L1D+LN+uYBNkAEyU86dzZVhhuhoElUy9yTvAXDrWlKGpTIWUeCkNNIhNz0IPSOZTacCQLm7kv2guBE66+jtwbmwwQeeTgmDwRN330XWi3393mKZItAZV6TH1ThvqVCWdjL6Hq92N9u/UA X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vQBzsb2wZ2MkFKG5u9uiyYbOupUSnLez0aBJMQR5vNdOks2BafR/5nPM9WXp?= =?us-ascii?Q?XPkcKGtpJR2VNZdkEAotaFAdStdeki1WPuJDhZzqLwrcKwS+LyJ5g/rfoTIe?= =?us-ascii?Q?hwTSHKm3ODZvIW8BQTHojqTntY0K15rgQbYMLkUIJqBRXeP7dqD0tNR/Z0It?= =?us-ascii?Q?OAmGgW3EfxM/F9NwOsszNqHFG21G3P0aZfcFfyWSoLqO+bDhVx4fCy7eqC2y?= =?us-ascii?Q?sX9tdK/VTLHrnU3PLD9QR21dIEsKH3I8wMZCeyIrZJCZ3dopVNZAWQfFjkFD?= =?us-ascii?Q?wkSDJb9kC9OqlyGzAw38uNDYi2KvlzJGu39bqpTZXOL0HVz6ZHZFJJwOI9Jo?= =?us-ascii?Q?2i9OBR+zvx+Fsc14ABQt3EPDhSSBa0MBSKJycwVtLiUgmnB8B7uiNvTu0N/e?= =?us-ascii?Q?7mi/eRqOD9DqdXMEWjMj/9XwzOEtId9LwSYHAQSr4TZOUg3v82PA95Poi4gK?= =?us-ascii?Q?0tcYd8MkaI6Hnp1VGw4r7gJRIFabBJj34bCvS5BR4nFL2JABkabj+pPuiSMY?= =?us-ascii?Q?WgbmneZTsE1hr/Jz5D/mvxUC92IVyz6b/oP0zh700k19KMIgpvqiX2l9V2Fo?= =?us-ascii?Q?XEVanLaQIy3Ybb8OPPQlCIt0Jempjr4CvU0pkZ7K8rvSIfNPFQb/NS6Ab5gk?= =?us-ascii?Q?CS09LcC2/cNWZW/aYDivDFGd42MqqiX3Y6g3fBgxhi1xinUj+J96Xni2yKmN?= =?us-ascii?Q?pWzoJpLQ210FtrGkwy53FP1z2W38z3aKdBHscIzVYkI/RDF3PPw2y52DO6xf?= =?us-ascii?Q?GCs8zVgXlBl0WxO83CqTAPUyzv9RAVhi3zzJHyIAM8dIoKJFF0XLHa7KYwS0?= =?us-ascii?Q?MrkGHMxwnuURnPNrisUI47gN58V9koDsjDGgeFGuiXaqRMhf/UV8n8/g0/XX?= =?us-ascii?Q?9wZ7S6casGefn26OzNL3gMm7JA9addd59pltFS7Nf05B8m7I2BlroWEjECEY?= =?us-ascii?Q?Z1S7qw6fvC8HkpPoQPaFdw=3D=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d666d20-aa8a-4fb3-2103-08d9e23cf384 X-MS-Exchange-CrossTenant-AuthSource: PAXPR08MB6640.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2022 09:02:46.4578 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4001 Received-SPF: pass client-ip=40.92.67.10; envelope-from=stardiviner@outlook.com; helo=EUR02-AM5-obe.outbound.protection.outlook.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: numbchild@gmail.com Cc: emacs-orgmode@gnu.org, Nicolas Goaziou Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643361853; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=c2agahuj1LV/uqsV2EAbDIkt7DVspVjvQ1mdj0u5tMg=; b=Y7Zh70L8orZb4rXin4kLLv2c3F6pv0qeOydilx8N7BtBelP9eIZ1VkTCd9o76MWnyPehJz Aq2292qk9/bDKaVFOMOVuNutff2GJ5FsCOZnvg4Wbyhep0fCrVaLL1peYqafb42R62kvxc 5JaTD8gcLK1jbSkQrZ/gE89sl656qV+DT8+IWyp5naL5dABDb9uskyrnBVVVtLxTksJn7M UxJ8HWwxZGvid7V+Bp9Rq9wjs7mC/VHGhDmehwGj+eR0cK3+qaFqm3i9wph93lxp2XYO+A bLe7TLr5Oqpk+Jj5r5BCREDJnnB+wUTGcORYgZdz4plM+0lYYmjHNo4X4NENjg== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1643361853; a=rsa-sha256; cv=pass; b=Aaop+hfNu8LAcuRMyvpdzFMz8VinlJEM6mGs/eNqS8qWIUopjwR7e5wd/kubs7dXUFYubo /Y0Iy8tjElbp54vSDT96/zp8tcRDovVKnNamKsTjbYSzKfj2k1bS8EPrzRAzONOXz1jrMg xW+mgSp6D14VSuJGhq0mBAJhZTevL76caKBJ8FBJApKac6Zr2Z1o2qlPaAT/0wiSFlEGKe 0+Z4Z4XJjz3aue+J7b63u+Md+bSmBej9wkHTGZGkcCJDU4G7xfsvwliOtrL8u5NsZDRStq 6eMerBi/qJRiPxzF3loiAQVqTiR5BymYbK0dnfCyJCAZlYAflzSmoNCGwNQVBg== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=outlook.com header.s=selector1 header.b=hkVsMeyt; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.33 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=outlook.com header.s=selector1 header.b=hkVsMeyt; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 832EC3621C X-Spam-Score: -6.33 X-Migadu-Scanner: scn1.migadu.com X-TUID: vMToxrRrOGv5 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I tested this commit, it should auto append a newline character after ~org-agenda-clock-report-header~. Otherwise the header line will in same li= ne with table first line. Samim Pezeshki writes: > Thanks Nicolas for reviewing the changes! > > I applied the changes. > Attached is the updated patch. > > On Fri, Jan 21, 2022 at 1:58 PM Nicolas Goaziou = wrote: > > Hello, > > Samim Pezeshki writes: > > > +(defcustom org-agenda-clock-report-header nil > > + "Header for org agenda clock report mode" > > + :group 'org-agenda > > + :type 'string) > > Please add :package-version and :safe keywords to the definition. > > Also, type does not match the default value. You probably mean > > (choice > (string :tag "Header") > (const :tag "No header" nil)) > > > + > > (defun org-agenda-time-of-day-to-ampm (time) > > "Convert TIME of a string like \"13:45\" to an AM/PM style time str= ing." > > (let* ((hour-number (string-to-number (substring time 0 -3))) > > @@ -4473,6 +4478,10 @@ items if they have an hour specification like [= h]h:mm." > > (setq p (plist-put p :tend clocktable-end)) > > (setq p (plist-put p :scope 'agenda)) > > (setq tbl (apply #'org-clock-get-clocktable p)) > > + (when org-agenda-clock-report-header > > + (put-text-property 0 (length org-agenda-clock-report-header) 'f= ace 'org-agenda-structure > > + org-agenda-clock-report-header) > > + (insert org-agenda-clock-report-header)) > > Maybe: > > (insert (propertize org-agenda-clock-report-header 'face 'org-agenda-s= tructure)) > > Could you send an updated patch? > > Regards, > --=20 > Nicolas Goaziou > > [4. text/x-patch; 0001-lisp-org-agenda.el-Add-header-to-agenda-clock-repo= rt.patch]... =2D-=20 [ stardiviner ] I try to make every word tell the meaning that I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAmHzsSsACgkQG13xyVro msMg/AgAwGnE5kXyjCt/jDatPu2V/Q4rGkRacBolyOtsou3lznzq6baCRCkhDO6P Z1Jwjh7csXIwizJvlB6Fm3GJpcDgJ+BNrfPCceHFSGs8EIkx9mHkpJ7Im0XE/SEC 7kSclg0A8mKG8W6HUyFRImUHwxnZvanPUgHzLlYExZjgsHgDDGlS5zU0AA5xcXY4 0z7OU7ujipoORthFtvfQP12HCWnMfBf2WnpqSSNC5SF0ptbaGLW6K8Q5XgPJHya4 rd/CCSvePhfl0ilmDtxjxpT3xYvLcFbVL7h0+nGMgwtJODV3QN2ZEEW9KpeVFXQH /ATa8K1QcoXDpQhWiDfWR/BLka8c9A== =AR7L -----END PGP SIGNATURE----- --=-=-=--