emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Christopher Miles <numbchild@gmail.com>
To: Tim Cross <theophilusx@gmail.com>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: patch: ob-clojure improvements
Date: Wed, 3 Feb 2021 00:13:25 +0000	[thread overview]
Message-ID: <PAXPR08MB6640204082AF8F6E25AD1F4AA3B49@PAXPR08MB6640.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <87tuqu1bys.fsf@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 2947 bytes --]

<#secure method=pgpmime mode=sign>

I checked this thread, seems the original first email of thread contains the patch. And it's not merged into Org git yet.

Tim Cross <theophilusx@gmail.com> writes:

OK, will push it up the todo list. Where can I get the latest version of the patch or has it been added into the org git repo?

Christopher Miles <numbchild@gmail.com> writes:

<#!secure method=pgpmime mode=sign>

Hi, Tim, popup this thread to request review. 😄

Tim Cross <theophilusx@gmail.com> writes:

I am also interested in ob-clojure and ob-clojurescript improvements. However, right now, I'm a tad busy and haven't had time to review what has been done. Hopefully, can make some time in the next month or so.


stardiviner <numbchild@gmail.com> writes:

agzam.ibragimov@gmail.com writes:

There seems to be a bit of lack of interest for these things. But I'm sure some people (myself included) would love to see these kinds of improvements.

Yes, I rarely saw Clojurians in this mailing list.

As I said before, I have never participated in contributing to Org source, some guidance would be appreciated.

Org Mode has contribution guide here http://orgmode.org/worg/org-contribute.html#patches

Should I keep building it and posting patches? Should I try to go incrementally, one small change at a time, or should I just get everything working first? If it turns out to be a bigger work, should I ask for permission to work in a branch and get access to pushing things to it? Maybe things just move slowly, because obviously you can't force maintainers to drop everything and concentrate effort to get your things in. Maybe I just have to be a little bit more patient?

I think a complete work contains many patches should be better, Also write testing if necessary.

I remember ob-clojure.el code are mostly reviewed by Bastien Guerry. I included him in Cc: in this email.

On Sat, Jun 20, 2020 at 1:23 AM stardiviner <numbchild@gmail.com> wrote:

Glad to see your patch, really useful in some cases. Thanks.

Ag Ibragimov <agzam.ibragimov@gmail.com> writes:

Hi everyone, here's my attempt to add clojure CLI and babashka support for ob-clojure.el - Adds a header parameter to override org-babel-clojure-backend - Adds :args param (right now only used for clojure-cli)

I have tested it with these minimal cases:

#+beginsrc clojure :backend clj-cli :args "-Sdeps '{:deps {inflections {:mvn/version \"0.13.2\"}}}'" (use 'inflections.core) (plural "word") #+endsrc

#+beginsrc clojure :backend babashka :results output (range 10) #+endsrc

Please let me know what you think. Any advice is appreciated, since I have never contributed before. Thank you.

– [ stardiviner ] I try to make every word tell the meaning that I want to express.

Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3

[-- Attachment #1.2: Type: text/html, Size: 4299 bytes --]

[-- Attachment #2: ATT00001.txt --]
[-- Type: text/plain, Size: 253 bytes --]

[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3

  reply	other threads:[~2021-02-03  0:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-20  6:55 patch: ob-clojure improvements Ag Ibragimov
2020-06-20  8:23 ` stardiviner
2020-07-02 22:43   ` agzam.ibragimov
2020-07-03  3:10     ` stardiviner
2020-07-03  3:53       ` Tim Cross
2021-02-02 12:11         ` Christopher Miles
2021-02-02 19:52           ` Tim Cross
2021-02-03  0:13             ` Christopher Miles [this message]
2021-02-03  6:36               ` Tim Cross
2021-02-03 11:59                 ` Christopher Miles
2020-09-04 15:24     ` Bastien
2020-10-09 21:17 ` joseph.corneli.orgmode--- via General discussions about Org-mode.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PAXPR08MB6640204082AF8F6E25AD1F4AA3B49@PAXPR08MB6640.eurprd08.prod.outlook.com \
    --to=numbchild@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=theophilusx@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).