emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Emily Bourke <undergroundquizscene@protonmail.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing
Date: Wed, 06 Jan 2021 20:58:56 +0000	[thread overview]
Message-ID: <J1sBspsasXyFOFV3343q4ncANvrd2CE0dVJExZZseZdLsM3gKcFenmfjb-Xix30RbgoU2te7WczcNPWyK2Md75V_ponyXWV-uhR3InFKTbo=@protonmail.com> (raw)
In-Reply-To: <87y2h9bctq.fsf@kyleam.com>

Thanks for the feedback!

> Nothing jumps out to me. For large files that are already visited, I
> suppose find-file-noselect returning an existing buffer can be faster,
> so relevant factors would include how many Org files a project has, how
> large they are, and how many of those are visited in the current
> session. My guess is that using with-temp-buffer and
> insert-file-contents would be a net gain, though that gain would be
> narrowed some if the temporary buffer was put into org-mode rather than
> kept in fundamental-mode (more below).

I'll do some testing with some large org files and see how things compare – it might be worth switching to the buffer for the file if there is one already.

> This reads to me like after-find-file is the hook itself. Perhaps
> something like this would be clearer: "... avoids calling
> after-find-file and running find-file-hook, ...".

Ah yes, I had misunderstood – I'll rephrase it.

> The goto-char call can be dropped now because insert-file-contents inserts
> after point.

I follow, will remove.

> Unlike the previous code, this doesn't activate org-mode in the buffer.
> That gives a speedup. And I don't spot any code downstream that depends
> on the major mode being org-mode, so it's probably safe, though perhaps
> there's a subtle change in behavior here (e.g., related to syntax
> table).
> If org-mode isn't called, the org-inhibit-startup binding above could be
> dropped.

Yeah, if you're worried about it I could try manually activating org mode in the temp buffer – I'm not confident I could predict any problems there might be from not activating it.

> This introduces a regression. With the previous code, the
> find-file-noselect call led to default-directory being set to the Org
> file's directory, and then this expand-file call on the included file
> was relative to that. With the new code, default-directory isn't
> changed, so it points to a non-existing or incorrect file unless the
> current default-directory and the Org file's happen to match.

Ah, I hadn't noticed this – I'll change it to set default-directory manually.

  reply	other threads:[~2021-01-06 20:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-01 19:58 [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing Emily Bourke
2021-01-04  3:28 ` Kyle Meyer
2021-01-06 20:58   ` Emily Bourke [this message]
2021-05-01 10:22     ` Bastien
2021-05-05 18:55       ` Emily Bourke
2021-09-26 10:26         ` Bastien
2021-09-26 11:58           ` Emily Bourke
2021-09-26 13:22             ` Bastien
2021-09-26 15:14               ` Emily Bourke
2021-09-27  8:33                 ` Emily Bourke
2021-09-27  8:48                   ` Bastien
2021-09-27  8:50                     ` Emily Bourke
     [not found]                     ` <DB6PR02MB3174059E6DD21014657284A0DAA79@DB6PR02MB3174.eurprd02.prod.outlook.com>
     [not found]                       ` <87czotpyk0.fsf@bzg.fr>
     [not found]                         ` <A2476131-8275-48D6-AF10-902CF347C1F9@whil.se>
     [not found]                           ` <874ka5pwxo.fsf@gnu.org>
2021-10-03  1:50                             ` Fwd: " Gustav Wikström
2021-01-07  1:11   ` Dr. Arne Babenhauserheide

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='J1sBspsasXyFOFV3343q4ncANvrd2CE0dVJExZZseZdLsM3gKcFenmfjb-Xix30RbgoU2te7WczcNPWyK2Md75V_ponyXWV-uhR3InFKTbo=@protonmail.com' \
    --to=undergroundquizscene@protonmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).