From: "Gustav Wikström" <email@example.com> To: Matt Lundin <firstname.lastname@example.org>, Org Mode List <email@example.com> Subject: RE: [Bug] org-store-link should not insert a document level ID property Date: Fri, 10 Apr 2020 08:08:50 +0000 [thread overview] Message-ID: <HE1PR02MB3033ACE623CBD990195591E2DADE0@HE1PR02MB3033.eurprd02.prod.outlook.com> (raw) In-Reply-To: <HE1PR02MB3033C126946CA3EDC1D10CE4DAC50@HE1PR02MB3033.eurprd02.prod.outlook.com> Hi, Just wanted to say that the patch is applied on master. It's solving the problem. Regarding user-configuration that can be added later if needed. It's not wrong right now per se. Cheers! Gustav > -----Original Message----- > From: Gustav Wikström > Sent: den 5 april 2020 17:50 > To: Matt Lundin <firstname.lastname@example.org>; Org Mode List <email@example.com> > Subject: RE: [Bug] org-store-link should not insert a document level ID > property > > Hi again, > > Patch is attached. It's not applied yet as it doesn't include anything about > user-configuration yet. @Matt Lundin, care to elaborate what you had in mind > in terms of that? > > With this patch a link before first headline is stored with the filename (no > path) as description. Following the link does what you'd expect. Tests ran > fine with the patch applied. > > Regards > Gustav > > > Hi, > > > > > -----Original Message----- > > > From: Matt Lundin <firstname.lastname@example.org> > > > Sent: den 5 april 2020 00:13 > > > To: Org Mode List <email@example.com> > > > Cc: Gustav Wikström <firstname.lastname@example.org> > > > Subject: [Bug] org-store-link should not insert a document level ID > property > > > > > > The introduction of document-level property drawers (commit > > > 1bdff9f73dc1e7ff625a90e3e61350bdea99f29c from May 2019) introduced > > > inconsistencies in the behavior of org-id and org-store-link. > > > > > > If org-id-link-to-org-use-id is set to t or 'create-if-interactive, > > > calling org-store-link above the first headline in an org file will > > > insert a PROPERTY drawer and an ID at top of the file, so that the file > > > (call it "~/test.org") looks like this: > > > > > > --8<---------------cut here---------------start------------->8--- > > > :PROPERTIES: > > > :ID: 1f43e860-9e7b-4c8f-82b9-6ed3352e589f > > > :END: > > > > > > * First headline > > > --8<---------------cut here---------------end--------------->8--- > > > > > > However, the link that Org actually stores is "[[file:~/test.org]]", so > > > the ID is irrelevant. > > > > > > In addition, a link to a document-level ID does not work. Following > > > "[[id:1f43e860-9e7b-4c8f-82b9-6ed3352e589f]]" results in this error: > > > > > > user-error: Before first headline at position 14 in buffer test.org > > > > > > So either: > > > > > > 1. org-id and org-store-link/org-open-link should support document level > > > ids in a user-configurable way, or > > > 2. org-id-get-create should detect whether it is above the first heading > > > and should not create an id > > > > > > Option #2 would obviously be the easier fix. > > > > > > Gustav: were IDs within the scope of your initial thinking about > > > document level properties? Or are these largely irrelevant? > > > > Yes, they were in scope and ID should mean something also before first > > headline. I'll have a look to see what can be done. Thanks for finding > this! > > > > > > > > Best, > > > Matt
next prev parent reply other threads:[~2020-04-10 8:14 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-04 22:13 Matt Lundin 2020-04-04 23:07 ` Gustav Wikström 2020-04-05 15:50 ` Gustav Wikström 2020-04-10 8:08 ` Gustav Wikström [this message] 2020-05-07 21:41 ` Matthew Lundin 2020-05-13 8:33 ` Nicolas Goaziou 2020-05-13 13:26 ` Matthew Lundin 2020-05-13 16:45 ` Nicolas Goaziou 2020-05-14 19:27 ` Gustav Wikström 2020-05-14 21:20 ` Nicolas Goaziou 2020-05-14 22:06 ` Gustav Wikström 2020-05-14 19:11 ` Gustav Wikström
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=HE1PR02MB3033ACE623CBD990195591E2DADE0@HE1PR02MB3033.eurprd02.prod.outlook.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='RE: [Bug] org-store-link should not insert a document level ID property' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).