emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: "Gustav Wikström" <gustav@whil.se>
To: Bastien <bzg@gnu.org>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: New startup options, show<n>levels
Date: Sat, 12 Dec 2020 18:56:27 +0000	[thread overview]
Message-ID: <HE1PR0202MB2857FAF4C0FD37346E7637B7DAC90@HE1PR0202MB2857.eurprd02.prod.outlook.com> (raw)
In-Reply-To: <87y2i2ap0y.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 2074 bytes --]

Hi Bastien,

Thanks for the feedback.

Regarding naming, there may ofc be other possibilities. I considered spelling the level out but discarded that option due to its verbosity. I find this quite elegant actually. One might argue that it's not general enough, with 2 to 5 hard-coded. But thinking of the use-case a bit more, I struggled to find a reason for more dynamics.

I don't object to the mailing list RFC method of doing things, but in this case it felt like a too small contribution for that trouble. Had there been a more streamlined pull-request workflow than the list I'm sure I'd have taken another decision. In this case the option was to just not do it due to time and energy constraints.

Nitpick noted, I'll try to care better with ending sentences moving forward!

Best
Gustav
________________________________
From: Bastien <bzg@gnu.org>
Sent: Saturday, December 12, 2020 6:54:21 PM
To: Gustav Wikström <gustav@whil.se>
Cc: emacs-orgmode@gnu.org <emacs-orgmode@gnu.org>
Subject: Re: New startup options, show<n>levels

Hi Gustav,

Gustav Wikström <gustav@whil.se> writes:

> Prompted by a question on StackOverflow,
> https://stackoverflow.com/questions/56536184/set-initial-visiblity-to-a-certain-level-in-org-mode,
> a few new options are added to the startup setting.

thanks -- in the future, I suggest discussing such additions on this
list before committing them.  In this case, I think we could come up
with better option names than "show2levels", even if I don't have a
better suggestion right now.

> Patch is applied to master as this is non-critical and it is
> communicated here and now for full transparency. See commit hash
> a71ac14e4,
> https://code.orgmode.org/bzg/org-mode/commit/a71ac14e46bb820abdbd2e6651c58179c50eb2fa

Mandatory nitpick: the log should contain proper sentences, ending
with a dot.  I'm mentioning this because your other commit has the
same small error.

> Hope these new options will be usable for some of you!

It sure is, thanks for taking care of this,

--
 Bastien

[-- Attachment #2: Type: text/html, Size: 3955 bytes --]

next prev parent reply	other threads:[~2020-12-12 20:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10  9:46 New startup options, show<n>levels Gustav Wikström
2020-12-12 17:54 ` Bastien
2020-12-12 18:56   ` Gustav Wikström [this message]
2020-12-13  9:48   ` Eric S Fraga
2020-12-13 10:19     ` TEC
2020-12-13 10:19     ` TEC
2020-12-13 15:36     ` Sv: " Gustav Wikström
2020-12-13 15:42       ` TEC

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=HE1PR0202MB2857FAF4C0FD37346E7637B7DAC90@HE1PR0202MB2857.eurprd02.prod.outlook.com \
    --to=gustav@whil.se \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).