From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Fix regexps in org-clock.el Date: Sat, 31 Dec 2011 09:06:34 +0100 Message-ID: References: <4EFEBAEB.2090808@gmail.com> Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([140.186.70.92]:38833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rgtxg-0006EV-7d for emacs-orgmode@gnu.org; Sat, 31 Dec 2011 03:06:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rgtxf-0006pJ-3M for emacs-orgmode@gnu.org; Sat, 31 Dec 2011 03:06:40 -0500 Received: from mail-ee0-f41.google.com ([74.125.83.41]:51242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rgtxe-0006p5-Tq for emacs-orgmode@gnu.org; Sat, 31 Dec 2011 03:06:39 -0500 Received: by eekc41 with SMTP id c41so15367559eek.0 for ; Sat, 31 Dec 2011 00:06:37 -0800 (PST) In-Reply-To: <4EFEBAEB.2090808@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Joe Vornehm Jr." Cc: emacs-orgmode@gnu.org Applied, thanks. But I have removed the regexp-quote again, because org-clock-string is used in many more regexps, and a more complete patch would be needed to make this change meaningful. - Carsten On 31.12.2011, at 08:34, Joe Vornehm Jr. wrote: > I have been seeing persistent errors of "Cannot restart clock because = task does not contain unfinished clock" when auto-resuming a saved = (persistent) clock. I believe I've tracked the error down to an = extraneous space in a regexp ("^[ \t]* " when it should be "^[ \t]*"). >=20 > This patch fixes the issue for me (in `org-clock-in'), and it makes = the same change in `org-clock-find-position'. I've tested this briefly = and it works for me; nothing about clocking-in behavior seems to break, = and persistent clocks work now. >=20 > I've also wrapped `regexp-quote' around instances where = org-clock-string is used to build a regexp, in case someone puts funny = characters in their org-clock-string. >=20 > Hopefully, the patch is attached correctly and Thunderbird didn't = mangle it. >=20 > Cheers! > Joe V. >=20 >=20 > <0001-Fix-regexps-in-org-clock.el.patch>