From: Carsten Dominik <dominik@uva.nl>
To: James TD Smith <ahktenzero@mohorovi.cc>
Cc: org-mode list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH 4/9] Fix link display in imenus and the refile interface
Date: Sun, 21 Sep 2008 08:25:14 +0200 [thread overview]
Message-ID: <F6A92091-9F3C-41C3-938B-3C780529DA04@uva.nl> (raw)
In-Reply-To: <20080920210901.19759.78844.stgit@nyarlathotep.internal.mohorovi.cc>
Hi James,
I am not accepting this particular patch in its current form. It does
not work for links to do not have a description part. Also, it relies
on replace-regexp-in-string, which does not exist in XEmacs I believe.
I am still thinking about %< patch (patch 7/9), need to test is a bit.
All the rest goes in for 6.08, thank you very much.
- Carsten
On Sep 20, 2008, at 11:09 PM, James TD Smith wrote:
> Replace links with their descriptions in when generating the items
> for imenus
> and the refile interface.
> ---
>
> lisp/ChangeLog | 4 ++++
> lisp/org.el | 8 +++++++-
> 2 files changed, 11 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/ChangeLog b/lisp/ChangeLog
> index 3896ddf..b52700d 100755
> --- a/lisp/ChangeLog
> +++ b/lisp/ChangeLog
> @@ -1,5 +1,9 @@
> 2008-09-20 James TD Smith <ahktenzero@mohorovi.cc>
>
> + * org.el (org-get-refile-targets): Replace links with their
> + descriptions
> + (org-imenu-get-tree): Replace links with their descriptions
> +
> * org-agenda.el (org-agenda-get-closed): show durations of clocked
> items as well as the start and end times.
>
> diff --git a/lisp/org.el b/lisp/org.el
> index cdbe7bb..99b62d0 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -7866,7 +7866,10 @@ on the system \"/user@host:\"."
> (while (re-search-forward descre nil t)
> (goto-char (point-at-bol))
> (when (looking-at org-complex-heading-regexp)
> - (setq txt (match-string 4)
> + (setq txt (save-match-data
> + (replace-regexp-in-string
> + org-bracket-link-analytic-regexp "\\5"
> + (match-string 4)))
> re (concat "^" (regexp-quote
> (buffer-substring (match-beginning 1)
> (match-end 4)))))
> @@ -14673,6 +14676,9 @@ Show the heading too, if it is currently
> invisible."
> (looking-at org-complex-heading-regexp)
> (setq head (org-match-string-no-properties 4)
> m (org-imenu-new-marker))
> + (setq head (replace-regexp-in-string
> + org-bracket-link-analytic-regexp
> + "\\5" head))
> (org-add-props head nil 'org-imenu-marker m 'org-imenu t)
> (if (>= level last-level)
> (push (cons head m) (aref subs level))
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
next prev parent reply other threads:[~2008-09-21 6:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-20 21:08 [PATCH 0/9] Update my last patchset James TD Smith
2008-09-20 21:08 ` [PATCH 1/9] Some improvements to the modeline clock display James TD Smith
2008-09-20 21:08 ` [PATCH 2/9] Fix X clipboard handling in emacs21 James TD Smith
2008-09-20 21:08 ` [PATCH 3/9] Show durations of clocked times in timeline James TD Smith
2008-09-20 21:09 ` [PATCH 4/9] Fix link display in imenus and the refile interface James TD Smith
2008-09-21 6:25 ` Carsten Dominik [this message]
2008-09-21 14:31 ` [PATCH] " James TD Smith
2008-09-21 19:40 ` Carsten Dominik
2008-09-20 21:09 ` [PATCH 5/9] Fix note insertion in entries with drawers James TD Smith
2008-10-16 4:50 ` Carsten Dominik
2008-09-20 21:09 ` [PATCH 6/9] Add some functions for handling checklists James TD Smith
2008-09-20 21:09 ` [PATCH 7/9] Add some new interaction between remember and clocked tasks James TD Smith
2008-09-20 21:09 ` [PATCH 8/9] Add a % expansion for inserting properties in remember buffers James TD Smith
2008-09-20 21:09 ` [PATCH 9/9] Some bugfixes for org-plot James TD Smith
2008-09-21 4:48 ` [PATCH 0/9] Update my last patchset Carsten Dominik
2008-09-21 12:21 ` James TD Smith
2008-09-21 12:43 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F6A92091-9F3C-41C3-938B-3C780529DA04@uva.nl \
--to=dominik@uva.nl \
--cc=ahktenzero@mohorovi.cc \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).