From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Git Store Link Broken? Date: Sat, 20 Feb 2010 20:34:52 +0100 Message-ID: References: <87hbpbki7r.wl%ded-law@ddoherty.net> <87r5of4uby.wl%maus.david@gmail.com> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Niv6U-0001ZS-0a for emacs-orgmode@gnu.org; Sat, 20 Feb 2010 14:35:02 -0500 Received: from [140.186.70.92] (port=58674 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Niv6T-0001XT-1z for emacs-orgmode@gnu.org; Sat, 20 Feb 2010 14:35:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Niv6S-0000ZY-Ev for emacs-orgmode@gnu.org; Sat, 20 Feb 2010 14:35:00 -0500 Received: from mail-ew0-f228.google.com ([209.85.219.228]:37364) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Niv6R-0000ZO-OI for emacs-orgmode@gnu.org; Sat, 20 Feb 2010 14:35:00 -0500 Received: by ewy28 with SMTP id 28so1233473ewy.8 for ; Sat, 20 Feb 2010 11:34:59 -0800 (PST) In-Reply-To: <87r5of4uby.wl%maus.david@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: David Maus Cc: Org Mode , "Daniel E. Doherty" , reimar.finken@gmx.de Applied, thanks. - Carsten On Feb 20, 2010, at 7:48 PM, David Maus wrote: > Hi Daniel, > > Daniel E. Doherty wrote: > >> Hello all, > >> I noticed when I upgraded org from 6.21 (which comes with Emacs) to >> the >> git version (6.34trans), org-store-link stopped working. When I >> try to >> store a link from dired, I get a stringp nil error, with this >> debugger >> output: > > It's a small glitch in `org-git-store-link': Orgmode calls all > registered store-link functions to see if one declares itself of being > responsible for the particular file or buffer. `org-git-store-link' > tries to make an assumption on whether the file that is currently > visited is inside a git repository w/o taking into consideration that > there are buffers that are not associated with a file -- like a dired > buffer. > > Attached patch fixes this. > > HTH > -- David > > -- > OpenPGP... 0x99ADB83B5A4478E6 > Jabber.... dmjena@jabber.org > Email..... maus.david@gmail.com > <0001-Avoid-trying-to-run-org-git-store-link-on-buffers- > th.patch>_______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode - Carsten