emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* problem with org-toggle-inline-images
@ 2019-12-23 23:42 Johannes Brauer
  2019-12-24 10:00 ` Marco Wahl
  2019-12-31 11:59 ` problem with org-toggle-inline-images Marco Wahl
  0 siblings, 2 replies; 10+ messages in thread
From: Johannes Brauer @ 2019-12-23 23:42 UTC (permalink / raw)
  To: emacs-orgmode@gnu.org

Hi!
Typing C-c C-x C-v the image is displayed in the org buffer correctly. Typing C-c C-x C-v again the image does not disappear and I get the error message:

org-toggle-inline-images: Symbol’s value as variable is void: image-map

Any hints what is going wrong?

I am using
Aquamacs 3.5  GNU Emacs 25.3.50.1 (x86_64-apple-darwin16.7.0, NS
macOs 10.15.2
Org mode version 9.3 (9.3-8-geab7c4-elpa

Johannes


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: problem with org-toggle-inline-images
  2019-12-23 23:42 problem with org-toggle-inline-images Johannes Brauer
@ 2019-12-24 10:00 ` Marco Wahl
  2019-12-24 13:03   ` Johannes Brauer
       [not found]   ` <A9079552-BC5E-4FE3-9AD1-363B3FDDACE1@nordakademie.de>
  2019-12-31 11:59 ` problem with org-toggle-inline-images Marco Wahl
  1 sibling, 2 replies; 10+ messages in thread
From: Marco Wahl @ 2019-12-24 10:00 UTC (permalink / raw)
  To: emacs-orgmode

Hi Johannes,

Thanks for the report.

> Typing C-c C-x C-v the image is displayed in the org buffer
> correctly. Typing C-c C-x C-v again the image does not disappear and I
> get the error message:
>
> org-toggle-inline-images: Symbol’s value as variable is void: image-map
>
> Any hints what is going wrong?

Possibly variable image-map is not used correctly in Org or should not
be used at all.  The easiest fix would be to drop the usage of that
variable within Org, I guess.

Does the issue disappear when you do

M-: (require 'image) RET

before the image toggling?


Ciao,
     Marco

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: problem with org-toggle-inline-images
  2019-12-24 10:00 ` Marco Wahl
@ 2019-12-24 13:03   ` Johannes Brauer
       [not found]   ` <A9079552-BC5E-4FE3-9AD1-363B3FDDACE1@nordakademie.de>
  1 sibling, 0 replies; 10+ messages in thread
From: Johannes Brauer @ 2019-12-24 13:03 UTC (permalink / raw)
  To: emacs-orgmode@gnu.org

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

Hi Marco,

thank for your answer

Am 24.12.2019 um 11:00 schrieb Marco Wahl <marcowahlsoft@gmail.com<mailto:marcowahlsoft@gmail.com>>:

The following message is a courtesy copy of an article
that has been posted to gmane.emacs.orgmode as well.

Hi Johannes,

Thanks for the report.

Typing C-c C-x C-v the image is displayed in the org buffer
correctly. Typing C-c C-x C-v again the image does not disappear and I
get the error message:

org-toggle-inline-images: Symbol’s value as variable is void: image-map

Any hints what is going wrong?

Possibly variable image-map is not used correctly in Org or should not
be used at all.  The easiest fix would be to drop the usage of that
variable within Org, I guess.

Does the issue disappear when you do

M-: (require 'image) RET

before the image toggling?
no, the behavior remains the same.

Johannes

[-- Attachment #2: Type: text/html, Size: 6302 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: problem with org-toggle-inline-images
       [not found]   ` <A9079552-BC5E-4FE3-9AD1-363B3FDDACE1@nordakademie.de>
@ 2019-12-24 13:08     ` Johannes Brauer
  2019-12-24 19:14       ` briangpowell .
  2019-12-30 17:33     ` BUG? - opening an org file containing #+STARTUP: inlineimages results in error message Johannes Brauer
  1 sibling, 1 reply; 10+ messages in thread
From: Johannes Brauer @ 2019-12-24 13:08 UTC (permalink / raw)
  To: Marco Wahl, emacs-orgmode@gnu.org

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

It seems that the problem arised since I’ve upgraded orgmode from version 9.2.6 (9.2.6-4-ge30905-elpa to version 9.3 (9.3-8-geab7c4-elpa.
On a system where the older version is installed, toggling works fine.

Johannes


Am 24.12.2019 um 11:30 schrieb Johannes Brauer <brauer@nordakademie.de<mailto:brauer@nordakademie.de>>:

Hi Marco,

thank for your answer

Am 24.12.2019 um 11:00 schrieb Marco Wahl <marcowahlsoft@gmail.com<mailto:marcowahlsoft@gmail.com>>:

The following message is a courtesy copy of an article
that has been posted to gmane.emacs.orgmode as well.

Hi Johannes,

Thanks for the report.

Typing C-c C-x C-v the image is displayed in the org buffer
correctly. Typing C-c C-x C-v again the image does not disappear and I
get the error message:

org-toggle-inline-images: Symbol’s value as variable is void: image-map

Any hints what is going wrong?

Possibly variable image-map is not used correctly in Org or should not
be used at all.  The easiest fix would be to drop the usage of that
variable within Org, I guess.

Does the issue disappear when you do

M-: (require 'image) RET

before the image toggling?
no, the behavior remains the same.

Johannes


[-- Attachment #2: Type: text/html, Size: 6135 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: problem with org-toggle-inline-images
  2019-12-24 13:08     ` Johannes Brauer
@ 2019-12-24 19:14       ` briangpowell .
  2019-12-25 12:38         ` Johannes Brauer
  0 siblings, 1 reply; 10+ messages in thread
From: briangpowell . @ 2019-12-24 19:14 UTC (permalink / raw)
  To: Johannes Brauer; +Cc: Marco Wahl, emacs-orgmode@gnu.org

[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]

I use iimage-mode

Have you tried iimage-mode?

Notice the 2 i's in iimage

Toggling works great with iimage-mode

On Tue, Dec 24, 2019 at 8:09 AM Johannes Brauer <brauer@nordakademie.de>
wrote:

> It seems that the problem arised since I’ve upgraded orgmode from version
> 9.2.6 (9.2.6-4-ge30905-elpa to version 9.3 (9.3-8-geab7c4-elpa.
> On a system where the older version is installed, toggling works fine.
>
> Johannes
>
>
> Am 24.12.2019 um 11:30 schrieb Johannes Brauer <brauer@nordakademie.de>:
>
> Hi Marco,
>
> thank for your answer
>
> Am 24.12.2019 um 11:00 schrieb Marco Wahl <marcowahlsoft@gmail.com>:
>
> The following message is a courtesy copy of an article
> that has been posted to gmane.emacs.orgmode as well.
>
> Hi Johannes,
>
> Thanks for the report.
>
> Typing C-c C-x C-v the image is displayed in the org buffer
> correctly. Typing C-c C-x C-v again the image does not disappear and I
> get the error message:
>
> org-toggle-inline-images: Symbol’s value as variable is void: image-map
>
> Any hints what is going wrong?
>
>
> Possibly variable image-map is not used correctly in Org or should not
> be used at all.  The easiest fix would be to drop the usage of that
> variable within Org, I guess.
>
> Does the issue disappear when you do
>
> M-: (require 'image) RET
>
> before the image toggling?
>
> no, the behavior remains the same.
>
> Johannes
>
>
>

[-- Attachment #2: Type: text/html, Size: 5056 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: problem with org-toggle-inline-images
  2019-12-24 19:14       ` briangpowell .
@ 2019-12-25 12:38         ` Johannes Brauer
  0 siblings, 0 replies; 10+ messages in thread
From: Johannes Brauer @ 2019-12-25 12:38 UTC (permalink / raw)
  To: briangpowell .; +Cc: Marco Wahl, emacs-orgmode@gnu.org

[-- Attachment #1: Type: text/plain, Size: 1689 bytes --]

I didn’t heard of image-mode. Perhaps I will give it a try.
But until orgmode version 9.2.6 worked  without it.


Am 24.12.2019 um 20:14 schrieb briangpowell . <briangpowellms@gmail.com<mailto:briangpowellms@gmail.com>>:

I use iimage-mode

Have you tried iimage-mode?

Notice the 2 i's in iimage

Toggling works great with iimage-mode

On Tue, Dec 24, 2019 at 8:09 AM Johannes Brauer <brauer@nordakademie.de<mailto:brauer@nordakademie.de>> wrote:
It seems that the problem arised since I’ve upgraded orgmode from version 9.2.6 (9.2.6-4-ge30905-elpa to version 9.3 (9.3-8-geab7c4-elpa.
On a system where the older version is installed, toggling works fine.

Johannes


Am 24.12.2019 um 11:30 schrieb Johannes Brauer <brauer@nordakademie.de<mailto:brauer@nordakademie.de>>:

Hi Marco,

thank for your answer

Am 24.12.2019 um 11:00 schrieb Marco Wahl <marcowahlsoft@gmail.com<mailto:marcowahlsoft@gmail.com>>:

The following message is a courtesy copy of an article
that has been posted to gmane.emacs.orgmode as well.

Hi Johannes,

Thanks for the report.

Typing C-c C-x C-v the image is displayed in the org buffer
correctly. Typing C-c C-x C-v again the image does not disappear and I
get the error message:

org-toggle-inline-images: Symbol’s value as variable is void: image-map

Any hints what is going wrong?

Possibly variable image-map is not used correctly in Org or should not
be used at all.  The easiest fix would be to drop the usage of that
variable within Org, I guess.

Does the issue disappear when you do

M-: (require 'image) RET

before the image toggling?
no, the behavior remains the same.

Johannes



[-- Attachment #2: Type: text/html, Size: 6417 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* BUG? - opening an org file containing #+STARTUP: inlineimages results in error message ...
       [not found]   ` <A9079552-BC5E-4FE3-9AD1-363B3FDDACE1@nordakademie.de>
  2019-12-24 13:08     ` Johannes Brauer
@ 2019-12-30 17:33     ` Johannes Brauer
  1 sibling, 0 replies; 10+ messages in thread
From: Johannes Brauer @ 2019-12-30 17:33 UTC (permalink / raw)
  To: emacs-orgmode@gnu.org

… File mode specification error: (void-variable image-map)

It seems that the problem arised since I’ve upgraded orgmode from version 9.2.6 (9.2.6-4-ge30905-elpa to version 9.3 resp. 9.3.1
On a system where the 9.2.6 is installed, images are shown.

Johannes



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: problem with org-toggle-inline-images
  2019-12-23 23:42 problem with org-toggle-inline-images Johannes Brauer
  2019-12-24 10:00 ` Marco Wahl
@ 2019-12-31 11:59 ` Marco Wahl
  2019-12-31 12:47   ` Nicolas Goaziou
  1 sibling, 1 reply; 10+ messages in thread
From: Marco Wahl @ 2019-12-31 11:59 UTC (permalink / raw)
  To: emacs-orgmode

Johannes Brauer <brauer@nordakademie.de> writes:

> Typing C-c C-x C-v the image is displayed in the org buffer
> correctly. Typing C-c C-x C-v again the image does not disappear and I
> get the error message:
>
> org-toggle-inline-images: Symbol’s value as variable is void: image-map
>
> Any hints what is going wrong?
>
> I am using
> Aquamacs 3.5  GNU Emacs 25.3.50.1 (x86_64-apple-darwin16.7.0, NS
> macOs 10.15.2
> Org mode version 9.3 (9.3-8-geab7c4-ELPA

IIUC variable image-map was introduced with Emacs 26.  This looks like a
good explanation of the behavior in your environment.

A natural fix is committed, I think.  Would be great if you could test
this fix.

If you want to use the image key map to rotate and zoom inline images in
Org you need to upgrade to Emacs 26, though.


Thanks again and best regards.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: problem with org-toggle-inline-images
  2019-12-31 11:59 ` problem with org-toggle-inline-images Marco Wahl
@ 2019-12-31 12:47   ` Nicolas Goaziou
  2019-12-31 13:10     ` Marco Wahl
  0 siblings, 1 reply; 10+ messages in thread
From: Nicolas Goaziou @ 2019-12-31 12:47 UTC (permalink / raw)
  To: Marco Wahl; +Cc: emacs-orgmode

Hello,

Marco Wahl <marcowahlsoft@gmail.com> writes:

> A natural fix is committed, I think.  Would be great if you could test
> this fix.

Thank you for the fix.

Could you refactor it so belongs to org-compat.el? For example, we could
create image-map keymap there if Emacs < 26.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: problem with org-toggle-inline-images
  2019-12-31 12:47   ` Nicolas Goaziou
@ 2019-12-31 13:10     ` Marco Wahl
  0 siblings, 0 replies; 10+ messages in thread
From: Marco Wahl @ 2019-12-31 13:10 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Marco Wahl <marcowahlsoft@gmail.com> writes:
>
>> A natural fix is committed, I think.  Would be great if you could test
>> this fix.
>
> Thank you for the fix.
>
> Could you refactor it so belongs to org-compat.el? For example, we could
> create image-map keymap there if Emacs < 26.

Okay, I make a TODO out of this and try to work on the task soon.  Right
now I'm on my way outside... :)


Ciao

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-12-31 13:10 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-23 23:42 problem with org-toggle-inline-images Johannes Brauer
2019-12-24 10:00 ` Marco Wahl
2019-12-24 13:03   ` Johannes Brauer
     [not found]   ` <A9079552-BC5E-4FE3-9AD1-363B3FDDACE1@nordakademie.de>
2019-12-24 13:08     ` Johannes Brauer
2019-12-24 19:14       ` briangpowell .
2019-12-25 12:38         ` Johannes Brauer
2019-12-30 17:33     ` BUG? - opening an org file containing #+STARTUP: inlineimages results in error message Johannes Brauer
2019-12-31 11:59 ` problem with org-toggle-inline-images Marco Wahl
2019-12-31 12:47   ` Nicolas Goaziou
2019-12-31 13:10     ` Marco Wahl

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).