From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH 2/2] set variables org-timer-timer[123] correctly Date: Thu, 5 Nov 2009 16:12:23 +0100 Message-ID: References: <1257415055-8120-1-git-send-email-drmabuse@cs.tu-berlin.de> <1257415055-8120-2-git-send-email-drmabuse@cs.tu-berlin.de> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N640m-000497-Nq for emacs-orgmode@gnu.org; Thu, 05 Nov 2009 10:12:32 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N640g-000424-VF for emacs-orgmode@gnu.org; Thu, 05 Nov 2009 10:12:31 -0500 Received: from [199.232.76.173] (port=48529 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N640g-00041m-PM for emacs-orgmode@gnu.org; Thu, 05 Nov 2009 10:12:26 -0500 Received: from mail-ew0-f228.google.com ([209.85.219.228]:61709) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N640g-0004sD-EA for emacs-orgmode@gnu.org; Thu, 05 Nov 2009 10:12:26 -0500 Received: by ewy28 with SMTP id 28so78420ewy.42 for ; Thu, 05 Nov 2009 07:12:25 -0800 (PST) In-Reply-To: <1257415055-8120-2-git-send-email-drmabuse@cs.tu-berlin.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Stephan Schmitt Cc: emacs-orgmode@gnu.org Applied, thanks. - Carsten On Nov 5, 2009, at 10:57 AM, Stephan Schmitt wrote: > before these variables were set to nil, and consequently > org-timer-last-timer as well. > --- > lisp/org-timer.el | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/lisp/org-timer.el b/lisp/org-timer.el > index 8a59c74..660312a 100644 > --- a/lisp/org-timer.el > +++ b/lisp/org-timer.el > @@ -312,12 +312,12 @@ VALUE can be `on', `off', or `pause'." > (t (error "Not in an Org buffer")))) > timer-set) > (mapcar (lambda(timer) > - (if (not (or (eval timer) timer-set)) > - (setq timer-set t > - timer > - (run-with-timer > - secs nil 'org-notify (format "%s: time out" hl) t) > - org-timer-last-timer timer))) > + (when (not (or (eval timer) timer-set)) > + (setq timer-set t) > + (setq org-timer-last-timer > + (run-with-timer > + secs nil 'org-notify (format "%s: time out" hl) t)) > + (set timer org-timer-last-timer))) > '(org-timer-timer1 > org-timer-timer2 > org-timer-timer3))))) > -- > 1.6.4.4 > > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode - Carsten