emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] fix polluting minibuffer-local-map
@ 2013-01-27  8:31 Leo Liu
  2013-01-27  9:06 ` Bastien
  2013-01-27  9:10 ` Carsten Dominik
  0 siblings, 2 replies; 3+ messages in thread
From: Leo Liu @ 2013-01-27  8:31 UTC (permalink / raw)
  To: emacs-orgmode

a/org.el
b/org.el
@@ -15578,57 +15578,57 @@
 (defvar org-read-date-minibuffer-local-map
   (let ((map (make-sparse-keymap)))
     (set-keymap-parent map minibuffer-local-map)
-    (org-defkey minibuffer-local-map [(meta shift left)]
+    (org-defkey map [(meta shift left)]
                 (lambda () (interactive)
                   (org-eval-in-calendar '(calendar-backward-month 1))))
-    (org-defkey minibuffer-local-map [(meta shift right)]
+    (org-defkey map [(meta shift right)]
                 (lambda () (interactive)
                   (org-eval-in-calendar '(calendar-forward-month 1))))
-    (org-defkey minibuffer-local-map [(meta shift up)]
+    (org-defkey map [(meta shift up)]
                 (lambda () (interactive)
                   (org-eval-in-calendar '(calendar-backward-year 1))))
-    (org-defkey minibuffer-local-map [(meta shift down)]
+    (org-defkey map [(meta shift down)]
                 (lambda () (interactive)
                   (org-eval-in-calendar '(calendar-forward-year 1))))
-    (org-defkey minibuffer-local-map [?\e (shift left)]
+    (org-defkey map [?\e (shift left)]
                 (lambda () (interactive)
                   (org-eval-in-calendar '(calendar-backward-month 1))))
-    (org-defkey minibuffer-local-map [?\e (shift right)]
+    (org-defkey map [?\e (shift right)]
                 (lambda () (interactive)
                   (org-eval-in-calendar '(calendar-forward-month 1))))
-    (org-defkey minibuffer-local-map [?\e (shift up)]
+    (org-defkey map [?\e (shift up)]
                 (lambda () (interactive)
                   (org-eval-in-calendar '(calendar-backward-year 1))))
-    (org-defkey minibuffer-local-map [?\e (shift down)]
+    (org-defkey map [?\e (shift down)]
                 (lambda () (interactive)
                   (org-eval-in-calendar '(calendar-forward-year 1))))
-    (org-defkey minibuffer-local-map [(shift up)]
+    (org-defkey map [(shift up)]
                 (lambda () (interactive)
                   (org-eval-in-calendar '(calendar-backward-week 1))))
-    (org-defkey minibuffer-local-map [(shift down)]
+    (org-defkey map [(shift down)]
                 (lambda () (interactive)
                   (org-eval-in-calendar '(calendar-forward-week 1))))
-    (org-defkey minibuffer-local-map [(shift left)]
+    (org-defkey map [(shift left)]
                 (lambda () (interactive)
                   (org-eval-in-calendar '(calendar-backward-day 1))))
-    (org-defkey minibuffer-local-map [(shift right)]
+    (org-defkey map [(shift right)]
                 (lambda () (interactive)
                   (org-eval-in-calendar '(calendar-forward-day 1))))
-    (org-defkey minibuffer-local-map "?"
+    (org-defkey map "?"
                 (lambda () (interactive)
                   (org-eval-in-calendar '(diary-view-entries))
                   (message "")))
-    (org-defkey minibuffer-local-map ">"
+    (org-defkey map ">"
                 (lambda () (interactive)
                   (org-eval-in-calendar '(scroll-calendar-left 1))))
-    (org-defkey minibuffer-local-map "<"
+    (org-defkey map "<"
                 (lambda () (interactive)
                   (org-eval-in-calendar '(scroll-calendar-right 1))))
-    (org-defkey minibuffer-local-map "\C-v"
+    (org-defkey map "\C-v"
                 (lambda () (interactive)
                   (org-eval-in-calendar
                    '(calendar-scroll-left-three-months 1))))
-    (org-defkey minibuffer-local-map "\M-v"
+    (org-defkey map "\M-v"
                 (lambda () (interactive)
                   (org-eval-in-calendar
                    '(calendar-scroll-right-three-months 1))))

Diff finished.  Sun Jan 27 16:29:52 2013

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fix polluting minibuffer-local-map
  2013-01-27  8:31 [PATCH] fix polluting minibuffer-local-map Leo Liu
@ 2013-01-27  9:06 ` Bastien
  2013-01-27  9:10 ` Carsten Dominik
  1 sibling, 0 replies; 3+ messages in thread
From: Bastien @ 2013-01-27  9:06 UTC (permalink / raw)
  To: Leo Liu; +Cc: emacs-orgmode

Hi Leo,

Leo Liu <sdl.web@gmail.com> writes:

> a/org.el
> b/org.el

Fixed, thanks.  

Please read this page on how to contribute patches:
http://orgmode.org/worg/org-contribute.html

-- 
 Bastien

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fix polluting minibuffer-local-map
  2013-01-27  8:31 [PATCH] fix polluting minibuffer-local-map Leo Liu
  2013-01-27  9:06 ` Bastien
@ 2013-01-27  9:10 ` Carsten Dominik
  1 sibling, 0 replies; 3+ messages in thread
From: Carsten Dominik @ 2013-01-27  9:10 UTC (permalink / raw)
  To: Leo Liu; +Cc: emacs-orgmode

Ouch what a bad bug.  Thanks for finding it Leo!

- Carsten

On 27.1.2013, at 09:31, Leo Liu <sdl.web@gmail.com> wrote:

> a/org.el
> b/org.el
> @@ -15578,57 +15578,57 @@
> (defvar org-read-date-minibuffer-local-map
>   (let ((map (make-sparse-keymap)))
>     (set-keymap-parent map minibuffer-local-map)
> -    (org-defkey minibuffer-local-map [(meta shift left)]
> +    (org-defkey map [(meta shift left)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-backward-month 1))))
> -    (org-defkey minibuffer-local-map [(meta shift right)]
> +    (org-defkey map [(meta shift right)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-forward-month 1))))
> -    (org-defkey minibuffer-local-map [(meta shift up)]
> +    (org-defkey map [(meta shift up)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-backward-year 1))))
> -    (org-defkey minibuffer-local-map [(meta shift down)]
> +    (org-defkey map [(meta shift down)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-forward-year 1))))
> -    (org-defkey minibuffer-local-map [?\e (shift left)]
> +    (org-defkey map [?\e (shift left)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-backward-month 1))))
> -    (org-defkey minibuffer-local-map [?\e (shift right)]
> +    (org-defkey map [?\e (shift right)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-forward-month 1))))
> -    (org-defkey minibuffer-local-map [?\e (shift up)]
> +    (org-defkey map [?\e (shift up)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-backward-year 1))))
> -    (org-defkey minibuffer-local-map [?\e (shift down)]
> +    (org-defkey map [?\e (shift down)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-forward-year 1))))
> -    (org-defkey minibuffer-local-map [(shift up)]
> +    (org-defkey map [(shift up)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-backward-week 1))))
> -    (org-defkey minibuffer-local-map [(shift down)]
> +    (org-defkey map [(shift down)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-forward-week 1))))
> -    (org-defkey minibuffer-local-map [(shift left)]
> +    (org-defkey map [(shift left)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-backward-day 1))))
> -    (org-defkey minibuffer-local-map [(shift right)]
> +    (org-defkey map [(shift right)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-forward-day 1))))
> -    (org-defkey minibuffer-local-map "?"
> +    (org-defkey map "?"
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(diary-view-entries))
>                   (message "")))
> -    (org-defkey minibuffer-local-map ">"
> +    (org-defkey map ">"
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(scroll-calendar-left 1))))
> -    (org-defkey minibuffer-local-map "<"
> +    (org-defkey map "<"
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(scroll-calendar-right 1))))
> -    (org-defkey minibuffer-local-map "\C-v"
> +    (org-defkey map "\C-v"
>                 (lambda () (interactive)
>                   (org-eval-in-calendar
>                    '(calendar-scroll-left-three-months 1))))
> -    (org-defkey minibuffer-local-map "\M-v"
> +    (org-defkey map "\M-v"
>                 (lambda () (interactive)
>                   (org-eval-in-calendar
>                    '(calendar-scroll-right-three-months 1))))
> 
> Diff finished.  Sun Jan 27 16:29:52 2013
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-01-27  9:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-27  8:31 [PATCH] fix polluting minibuffer-local-map Leo Liu
2013-01-27  9:06 ` Bastien
2013-01-27  9:10 ` Carsten Dominik

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).