emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Leo Liu <sdl.web@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] fix polluting minibuffer-local-map
Date: Sun, 27 Jan 2013 10:10:31 +0100	[thread overview]
Message-ID: <E7A6C3D0-EA49-43A5-A3A7-2734BC146148@gmail.com> (raw)
In-Reply-To: <m2k3qzm3h2.fsf@gmail.com>

Ouch what a bad bug.  Thanks for finding it Leo!

- Carsten

On 27.1.2013, at 09:31, Leo Liu <sdl.web@gmail.com> wrote:

> a/org.el
> b/org.el
> @@ -15578,57 +15578,57 @@
> (defvar org-read-date-minibuffer-local-map
>   (let ((map (make-sparse-keymap)))
>     (set-keymap-parent map minibuffer-local-map)
> -    (org-defkey minibuffer-local-map [(meta shift left)]
> +    (org-defkey map [(meta shift left)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-backward-month 1))))
> -    (org-defkey minibuffer-local-map [(meta shift right)]
> +    (org-defkey map [(meta shift right)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-forward-month 1))))
> -    (org-defkey minibuffer-local-map [(meta shift up)]
> +    (org-defkey map [(meta shift up)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-backward-year 1))))
> -    (org-defkey minibuffer-local-map [(meta shift down)]
> +    (org-defkey map [(meta shift down)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-forward-year 1))))
> -    (org-defkey minibuffer-local-map [?\e (shift left)]
> +    (org-defkey map [?\e (shift left)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-backward-month 1))))
> -    (org-defkey minibuffer-local-map [?\e (shift right)]
> +    (org-defkey map [?\e (shift right)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-forward-month 1))))
> -    (org-defkey minibuffer-local-map [?\e (shift up)]
> +    (org-defkey map [?\e (shift up)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-backward-year 1))))
> -    (org-defkey minibuffer-local-map [?\e (shift down)]
> +    (org-defkey map [?\e (shift down)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-forward-year 1))))
> -    (org-defkey minibuffer-local-map [(shift up)]
> +    (org-defkey map [(shift up)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-backward-week 1))))
> -    (org-defkey minibuffer-local-map [(shift down)]
> +    (org-defkey map [(shift down)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-forward-week 1))))
> -    (org-defkey minibuffer-local-map [(shift left)]
> +    (org-defkey map [(shift left)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-backward-day 1))))
> -    (org-defkey minibuffer-local-map [(shift right)]
> +    (org-defkey map [(shift right)]
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(calendar-forward-day 1))))
> -    (org-defkey minibuffer-local-map "?"
> +    (org-defkey map "?"
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(diary-view-entries))
>                   (message "")))
> -    (org-defkey minibuffer-local-map ">"
> +    (org-defkey map ">"
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(scroll-calendar-left 1))))
> -    (org-defkey minibuffer-local-map "<"
> +    (org-defkey map "<"
>                 (lambda () (interactive)
>                   (org-eval-in-calendar '(scroll-calendar-right 1))))
> -    (org-defkey minibuffer-local-map "\C-v"
> +    (org-defkey map "\C-v"
>                 (lambda () (interactive)
>                   (org-eval-in-calendar
>                    '(calendar-scroll-left-three-months 1))))
> -    (org-defkey minibuffer-local-map "\M-v"
> +    (org-defkey map "\M-v"
>                 (lambda () (interactive)
>                   (org-eval-in-calendar
>                    '(calendar-scroll-right-three-months 1))))
> 
> Diff finished.  Sun Jan 27 16:29:52 2013
> 
> 

      parent reply	other threads:[~2013-01-27  9:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-27  8:31 [PATCH] fix polluting minibuffer-local-map Leo Liu
2013-01-27  9:06 ` Bastien
2013-01-27  9:10 ` Carsten Dominik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E7A6C3D0-EA49-43A5-A3A7-2734BC146148@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).