From: Dror Atariah <drorata@gmail.com>
To: Emacs-orgmode@gnu.org
Subject: Re: Unable to push to org-mobile
Date: Sat, 14 Dec 2013 16:40:39 +0100 [thread overview]
Message-ID: <E5CA8532-5A6D-434C-8D51-4545012EC723@gmail.com> (raw)
In-Reply-To: 13008CFE-91B9-4221-9DBB-96157A4A2FC6@gmail.com
On Dec 13, 2013, at 23:08 PM, Nick Dokos wrote:
> Dror Atariah <drorata@gmail.com> writes:
>
>> Managed to get [backtrace] output...
>>
>> You can find it here: https://gist.github.com/drorata/7950857
>>
>> I could not find my way in this output... :(
>>
>
> If you look at the top of the backtrace it shows this:
>
> ,----
> | Debugger entered--Lisp error: (wrong-type-argument sequencep :grouptags)
> | mapconcat(identity ("PRIVATE" "{" "WORK" :grouptags "WORK@mittagseminar" "WORK@open_questions" "WORK@diss" "WORK@CV" "}" "{" "IT" :grouptags "IT@emacs" "IT@git" "IT@TeX" "}" "{" "PROG" :grouptags "PROG@mathematica" "PROG@cgal" "}" "}" "4freeTime" "bms_friday" "emacs" "interesting_questions" "mittagseminar" "Mittagsseminar" "NOTE" "private" "results" "work" "Yvinec" "Ziegler") " ")
> | (insert "#+TAGS: " (mapconcat (quote identity) tags " ") "\n")
> | ...
> | org-mobile-create-index-file()
> `----
>
> The mapconcat line can be evaluated on its own - it does not depend on
> anything else. If you cut and paste it into your *scratch* buffer and
> modify it slightly like this:
>
> --8<---------------cut here---------------start------------->8---
> (mapconcat 'identity '("PRIVATE" "{" "WORK" :grouptags "WORK@mittagseminar" "WORK@open_questions" "WORK@diss" "WORK@CV" "}" "{" "IT" :grouptags "IT@emacs" "IT@git" "IT@TeX" "}" "{" "PROG" :grouptags "PROG@mathematica" "PROG@cgal" "}" "}" "4freeTime" "bms_friday" "emacs" "interesting_questions" "mittagseminar" "Mittagsseminar" "NOTE" "private" "results" "work" "Yvinec" "Ziegler") " ")
> --8<---------------cut here---------------end--------------->8---
>
> and evaluate it with C-j, you get the exact error. Now look in
> org-mobile-create-index-file for the call
>
>
> (insert "#+TAGS: " (mapconcat 'identity tags " ") "\n")
>
> You'll find it on line 470 (at least in the version I'm using).
> Before this line there is this code:
>
> ...
> (setq def-tags (mapcar
> (lambda (x)
> (cond ((null x) nil)
> ((stringp x) x)
> ((eq (car x) :startgroup) "{")
> ((eq (car x) :endgroup) "}")
> ((eq (car x) :newline) nil)
> ((listp x) (car x))))
> def-tags))
> (setq def-tags (delq nil def-tags))
> (setq tags (org-delete-all def-tags tags))
> (setq tags (sort tags (lambda (a b) (string< (downcase a) (downcase b)))))
> (setq tags (append def-tags tags nil))
> (insert "#+TAGS: " (mapconcat 'identity tags " ") "\n")
> ...
>
> You'll notice that :startgroup is replaced by { , :endgroup is
> replaced by } and :newline is deleted - but there is no mention of
> :grouptags which leads me to suspect that there should be an extra
> line in there, perhaps
>
> ((eq (car x) :grouptags) nil)
>
> Maybe you can try it - better yet, maybe somebody who has some idea of
> how org-mobile works should take a look. I note that if I delete the
> :grouptags instances in the mapconcat call above, it completes without
> error.
Bingo! Adding this line allowed me to complete org-mobile-push successfully! Amazing. I have three closing questions:
1. What made you look into lines #460-464? Now when you pointed, it is somehow straightforward to check line #470, but there seems to be no indication regarding the broken code.
2. What's next? I believe this is a bug... How can I report it?
3. Finally, in the meanwhile, till the bug-fix is out, what is the best practice to maintain this patch locally?
Thanks a lot for your hand!!!! It was great having it!
Dror
>
> Nick
next parent reply other threads:[~2013-12-14 15:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <13008CFE-91B9-4221-9DBB-96157A4A2FC6@gmail.com>
2013-12-14 15:40 ` Dror Atariah [this message]
2013-12-14 19:50 ` Unable to push to org-mobile Nick Dokos
2013-12-14 21:06 ` Nick Dokos
2013-12-15 5:34 ` Dror Atariah
2013-12-15 14:17 ` Nick Dokos
2014-01-12 12:17 ` Dror Atariah
2014-01-12 12:53 ` Bastien
2014-01-12 12:58 ` Dror Atariah
2014-01-12 13:26 ` Bastien
2014-01-12 13:34 ` Dror Atariah
2014-01-12 23:30 ` Bastien
2014-01-13 3:48 ` Nick Dokos
2014-01-20 21:06 ` Dror Atariah
2014-01-20 22:20 ` Nick Dokos
2013-12-13 8:48 Dror Atariah
2013-12-13 15:08 ` Nick Dokos
2013-12-13 19:34 ` Dror Atariah
2013-12-13 19:51 ` Nick Dokos
2013-12-13 20:32 ` Dror Atariah
2013-12-13 22:08 ` Nick Dokos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E5CA8532-5A6D-434C-8D51-4545012EC723@gmail.com \
--to=drorata@gmail.com \
--cc=Emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).