From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uEnhOqVJa2MYywAAbAwnHQ (envelope-from ) for ; Wed, 09 Nov 2022 07:33:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iDrQOqVJa2Mt1wAAauVa8A (envelope-from ) for ; Wed, 09 Nov 2022 07:33:09 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7BE6939154 for ; Wed, 9 Nov 2022 07:33:09 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osecy-00049i-Bb; Wed, 09 Nov 2022 01:32:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osecc-00046e-UI for emacs-orgmode@gnu.org; Wed, 09 Nov 2022 01:31:53 -0500 Received: from smtp6-g21.free.fr ([2a01:e0c:1:1599::15]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osecb-0007r8-AB for emacs-orgmode@gnu.org; Wed, 09 Nov 2022 01:31:38 -0500 Received: from tosh-laptop (unknown [IPv6:2a01:e0a:505:3460:1a16:a0c4:3f89:c0d9]) by smtp6-g21.free.fr (Postfix) with ESMTPS id 3B4CE78035D; Wed, 9 Nov 2022 07:31:31 +0100 (CET) Received: by tosh-laptop (sSMTP sendmail emulation); Wed, 09 Nov 2022 07:37:27 +0100 From: Bruno Barbier To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] org-babel-insert-result: Fix wrong-type-argument markerp nil In-Reply-To: <87v8noc0wx.fsf@localhost> References: <87v8noc0wx.fsf@localhost> Date: Wed, 09 Nov 2022 07:37:26 +0100 MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a01:e0c:1:1599::15; envelope-from=perso.bruno.barbier@free.fr; helo=smtp6-g21.free.fr X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, MISSING_MID=0.497, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action Message-Id: X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667975589; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=1HHQz4Ku/codsX75/EqYD0W9+Ww/eNVr6SNU5m+TZCE=; b=LdtSDqPB3FrtvtD1aOO1cg0t9+5sRAnTStOTp7wwqFmp4PhBT7Nm079jufn34tQmsmdzLw wracZnZvnLSBPTsbInaI0X3qoBHINNTQiJSGWG7El/M/SDv3AusWioTxiWdP/aT7sTInr3 /mHsxiEF8FmvlT2TNKN5Lv0KVe/G7zbssgry+e8xrCeMcMmsiaQJQ8YDeKITbqMrshsDFe tYDkdj7R2jR0QH7+oZkyT48QdMMMk76QT6305HDUUZoM2987axL3/PKHbcwLtbD1+oMhwo sMj+nD3C4ynmwwCb/7duw6mwGi+mgbOspJ/tReemPna99iJq8JaTghXx8iZqgw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667975589; a=rsa-sha256; cv=none; b=mPDkSuv4nDvz68Idf++2RxvBljoHM+9NMySgOMGhPbcqCqsLdRgfQQ4hX9mZzSnZNTELM6 rHzCMJJMZ8EsiSosOiaWpfgX+4ur8y3OI/aEfzg6oiZrAVJqS19iHZT3BI210FOmR5wZB4 v4LNyDaEEOyprAJs05wv7SyvD1Vto20V8cDGl8zg41d8o4rRbp3H3cDraXXL9nPQNK8KEl wpN4d+9EYFBoWI5McLW3ZyoHZ4p8m8Tc0dolCAeJC+HQZXjfi5EB1NYwf4PnluyC2kG4Ex udoOolh0LiXDlyRhmXgHMQME3B83muqjMN8pJXH/K4Hu6lx7ae6oud9TYGsYNA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=free.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.18 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=free.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7BE6939154 X-Spam-Score: 2.18 X-Migadu-Scanner: scn1.migadu.com X-TUID: bcYtSpdTGkiY Ihor Radchenko writes: > Bruno Barbier writes: > >> Here is a small patch for a corner case in `org-babel-insert-result'. > > Thanks, but could you please explain a bit more about this corner case? > `end' must be always defined because > (setq end (copy-marker (point) t)) > must be executed. If the body of the unwind-protect throw an error, the variable 'end' might still be nil. It's set to nil when declared with the 'let' form. > > Your patch, if addressing a valid scenario, is not treating the root > cause; just the symptom. You're right. I was investigating an other bug. That 'wrong-type-argument markerp nil' was just hiding the real bug to me. Bruno