emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Pattch to org.texi: Document ":eval no"
@ 2011-07-28 12:10 Stephen Eglen
  2011-07-28 13:09 ` Sebastien Vauban
  2011-08-16 16:45 ` Bastien
  0 siblings, 2 replies; 5+ messages in thread
From: Stephen Eglen @ 2011-07-28 12:10 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: Stephen Eglen

Small patch attached, thanks Seb for pointing this out.

Stephen

diff --git a/doc/org.texi b/doc/org.texi
index 3ecf897..eb45885 100644
--- a/doc/org.texi
+++ b/doc/org.texi
@@ -12990,10 +12990,10 @@ permissions of the tangled file are set to make it executable.
 @subsubsection @code{:eval}
 The @code{:eval} header argument can be used to limit the evaluation of
 specific code blocks.  @code{:eval} accepts two arguments ``never'' and
-``query''.  @code{:eval never} will ensure that a code block is never
-evaluated, this can be useful for protecting against the evaluation of
-dangerous code blocks.  @code{:eval query} will require a query for every
-execution of a code block regardless of the value of the
+``query''.  @code{:eval never} (or @code{:eval no}) will ensure that a code
+block is never evaluated, this can be useful for protecting against the
+evaluation of dangerous code blocks.  @code{:eval query} will require a query
+for every execution of a code block regardless of the value of the
 @code{org-confirm-babel-evaluate} variable.
 
 If this header argument is not set then evaluation is determined by the value

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: Pattch to org.texi: Document ":eval no"
  2011-07-28 12:10 Pattch to org.texi: Document ":eval no" Stephen Eglen
@ 2011-07-28 13:09 ` Sebastien Vauban
  2011-07-28 22:57   ` Eric Schulte
  2011-08-16 16:45 ` Bastien
  1 sibling, 1 reply; 5+ messages in thread
From: Sebastien Vauban @ 2011-07-28 13:09 UTC (permalink / raw)
  To: emacs-orgmode-mXXj517/zsQ

Hi Stephen,

Stephen Eglen wrote:
> Small patch attached, thanks Seb for pointing this out.
>
> Stephen
>
> diff --git a/doc/org.texi b/doc/org.texi
> index 3ecf897..eb45885 100644
> --- a/doc/org.texi
> +++ b/doc/org.texi
> @@ -12990,10 +12990,10 @@ permissions of the tangled file are set to make it executable.
>  @subsubsection @code{:eval}
>  The @code{:eval} header argument can be used to limit the evaluation of
>  specific code blocks.  @code{:eval} accepts two arguments ``never'' and
> -``query''.  @code{:eval never} will ensure that a code block is never
> -evaluated, this can be useful for protecting against the evaluation of
> -dangerous code blocks.  @code{:eval query} will require a query for every
> -execution of a code block regardless of the value of the
> +``query''.  @code{:eval never} (or @code{:eval no}) will ensure that a code
> +block is never evaluated, this can be useful for protecting against the
> +evaluation of dangerous code blocks.  @code{:eval query} will require a query
> +for every execution of a code block regardless of the value of the
>  @code{org-confirm-babel-evaluate} variable.
>  
>  If this header argument is not set then evaluation is determined by the value

While this -- really! -- is an excellent initiative (to update the doc when
you notice something's missing).

Note that, would have better read my notes, instead of counting on my memory,
I would have told you ":eval never". Though, I just checked, and confirm that
":eval no" is (for the moment) equivalent to it: see ob.el, lines 218 and 226.

So, this patch makes sense -- except if Eric wants to let this option
disappear, and only supports it in the code for backward compatibility.

Best regards,
  Seb

-- 
Sebastien Vauban

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Pattch to org.texi: Document ":eval no"
  2011-07-28 13:09 ` Sebastien Vauban
@ 2011-07-28 22:57   ` Eric Schulte
  0 siblings, 0 replies; 5+ messages in thread
From: Eric Schulte @ 2011-07-28 22:57 UTC (permalink / raw)
  To: Sebastien Vauban; +Cc: emacs-orgmode

Applied, Thanks for the patch -- Eric

"Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes:

> Hi Stephen,
>
> Stephen Eglen wrote:
>> Small patch attached, thanks Seb for pointing this out.
>>
>> Stephen
>>
>> diff --git a/doc/org.texi b/doc/org.texi
>> index 3ecf897..eb45885 100644
>> --- a/doc/org.texi
>> +++ b/doc/org.texi
>> @@ -12990,10 +12990,10 @@ permissions of the tangled file are set to make it executable.
>>  @subsubsection @code{:eval}
>>  The @code{:eval} header argument can be used to limit the evaluation of
>>  specific code blocks.  @code{:eval} accepts two arguments ``never'' and
>> -``query''.  @code{:eval never} will ensure that a code block is never
>> -evaluated, this can be useful for protecting against the evaluation of
>> -dangerous code blocks.  @code{:eval query} will require a query for every
>> -execution of a code block regardless of the value of the
>> +``query''.  @code{:eval never} (or @code{:eval no}) will ensure that a code
>> +block is never evaluated, this can be useful for protecting against the
>> +evaluation of dangerous code blocks.  @code{:eval query} will require a query
>> +for every execution of a code block regardless of the value of the
>>  @code{org-confirm-babel-evaluate} variable.
>>  
>>  If this header argument is not set then evaluation is determined by the value
>
> While this -- really! -- is an excellent initiative (to update the doc when
> you notice something's missing).
>
> Note that, would have better read my notes, instead of counting on my memory,
> I would have told you ":eval never". Though, I just checked, and confirm that
> ":eval no" is (for the moment) equivalent to it: see ob.el, lines 218 and 226.
>
> So, this patch makes sense -- except if Eric wants to let this option
> disappear, and only supports it in the code for backward compatibility.
>
> Best regards,
>   Seb

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Pattch to org.texi: Document ":eval no"
  2011-07-28 12:10 Pattch to org.texi: Document ":eval no" Stephen Eglen
  2011-07-28 13:09 ` Sebastien Vauban
@ 2011-08-16 16:45 ` Bastien
  2011-08-16 21:40   ` Stephen Eglen
  1 sibling, 1 reply; 5+ messages in thread
From: Bastien @ 2011-08-16 16:45 UTC (permalink / raw)
  To: Stephen Eglen; +Cc: emacs-orgmode

Hi Stephen,

Stephen Eglen <S.J.Eglen@damtp.cam.ac.uk> writes:

> Small patch attached, thanks Seb for pointing this out.

Thanks for the patch -- I'm willing to apply it, but I'd rather apply a
complete patch, i.e. one with a ChangeLog entry.  Can you update it?

Put the cursor on your change in org.texi and use `C-x 4 a' to create a
proper ChangeLog entry, then copy this entry to the commit message.

Thanks in advance!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Pattch to org.texi: Document ":eval no"
  2011-08-16 16:45 ` Bastien
@ 2011-08-16 21:40   ` Stephen Eglen
  0 siblings, 0 replies; 5+ messages in thread
From: Stephen Eglen @ 2011-08-16 21:40 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode, Stephen Eglen

> > Small patch attached, thanks Seb for pointing this out.
> 
> Thanks for the patch -- I'm willing to apply it, but I'd rather apply a
> complete patch, i.e. one with a ChangeLog entry.  Can you update it?
> 
> Put the cursor on your change in org.texi and use `C-x 4 a' to create a
> proper ChangeLog entry, then copy this entry to the commit message.
> 
> Thanks in advance!

hi Bastien, thanks I'll remember that for future reference; for this
patch, it looks like Eric already applied it.  Stephen


commit c88c76b5519a27b3747344668d387f8561bf5fda
Author: Eric Schulte <schulte.eric@gmail.com>
Date:   Thu Jul 28 17:00:13 2011 -0600

    doc: flesh out description of ":eval" header argument
    
      Thanks to Stephen Eglen for this patch

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-08-16 21:40 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-28 12:10 Pattch to org.texi: Document ":eval no" Stephen Eglen
2011-07-28 13:09 ` Sebastien Vauban
2011-07-28 22:57   ` Eric Schulte
2011-08-16 16:45 ` Bastien
2011-08-16 21:40   ` Stephen Eglen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).