From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mario Martelli Subject: Re: [PATCH] org-protocol: fixes open-source and extends rewriting of URLs Date: Sun, 25 Jun 2017 10:21:36 +0200 Message-ID: References: <68E12968-9AF5-440A-B22C-AC55B70BA910@schnuddelhuddel.de> <87k248b6p8.fsf@nicolasgoaziou.fr> <7C76EDC3-CC7E-4AFE-B45B-867752C1B33A@schnuddelhuddel.de> <87a8519rlg.fsf@nicolasgoaziou.fr> <8760fp9mui.fsf@nicolasgoaziou.fr> <2FAD7DF2-2A0C-4703-A383-BA8D3346C691@schnuddelhuddel.de> <18D83D3C-C472-4614-988F-1F1DA5EB5CEC@schnuddelhuddel.de> <87efub7psj.fsf@nicolasgoaziou.fr> <8CE2CFE3-2911-4369-8E93-E80CD25FD7E4@schnuddelhuddel.de> <5442AC7A-D45E-46FE-A3A7-3AB25679B3FE@schnuddelhuddel.de> <4427263B-5534-4FFD-AFA0-211EDA489001@schnuddelhuddel.de> <8760fk4jur.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_9450C920-BF46-4DA4-B9D5-D9097E0E582B" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dP2nh-00030U-KI for emacs-orgmode@gnu.org; Sun, 25 Jun 2017 04:21:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dP2nc-0003nD-M9 for emacs-orgmode@gnu.org; Sun, 25 Jun 2017 04:21:45 -0400 Received: from mail-wr0-x22e.google.com ([2a00:1450:400c:c0c::22e]:35211) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dP2nc-0003mn-EA for emacs-orgmode@gnu.org; Sun, 25 Jun 2017 04:21:40 -0400 Received: by mail-wr0-x22e.google.com with SMTP id k67so114511023wrc.2 for ; Sun, 25 Jun 2017 01:21:40 -0700 (PDT) In-Reply-To: <8760fk4jur.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org --Apple-Mail=_9450C920-BF46-4DA4-B9D5-D9097E0E582B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > If all tests in "test-org-protocol.el" pass with your changes, I think > it is fine to apply them. Selector: "test-org-protocol/" Passed: 2 Failed: 0 Skipped: 0 Total: 2/2 > Another round of tests for the cases you solve > would be nice, too. I added the configuration part. That will be parsed during the tests I = suppose. Selector: "test-org-protocol/" Passed: 3 Failed: 0 Skipped: 0 Total: 3/3 --Apple-Mail=_9450C920-BF46-4DA4-B9D5-D9097E0E582B Content-Disposition: attachment; filename=0004-config-for-date-style-URL-is-added-to-org-protocol-t.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0004-config-for-date-style-URL-is-added-to-org-protocol-t.patch" Content-Transfer-Encoding: quoted-printable =46rom=204408f27e37f6578b3244a1ff7f4d7bd27720e1e6=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Mario=20Martelli=20=0A= Date:=20Sun,=2025=20Jun=202017=2010:14:40=20+0200=0ASubject:=20[PATCH=20= 4/4]=20config=20for=20date=20style=20URL=20is=20added=20to=20= org-protocol=20tests=0A=0A---=0A=20testing/lisp/test-org-protocol.el=20|=20= 6=20++++++=0A=201=20file=20changed,=206=20insertions(+)=0A=0Adiff=20= --git=20a/testing/lisp/test-org-protocol.el=20= b/testing/lisp/test-org-protocol.el=0Aindex=208f946864c..b11c72a68=20= 100644=0A---=20a/testing/lisp/test-org-protocol.el=0A+++=20= b/testing/lisp/test-org-protocol.el=0A@@=20-137,6=20+137,12=20@@=0A=20=09= =20=20=20=20=20:base-url=20"http://another.example.com/"=0A=20=09=20=20=20= =20=20:online-suffix=20".js"=0A=20=09=20=20=20=20=20:working-directory=20= ,(file-name-directory=20temp-file-name2))=0A+=09=20=20=20=20(test3=0A+=09= =20=20=20=20=20:base-url=20"https://blog-example.com/"=0A+=09=20=20=20=20= =20:working-directory=20,(file-name-directory=20temp-file-name2))=0A+=09=20= =20=20=20=20:online-suffix=20".html"=0A+=09=20=20=20=20=20= :working-suffix=20".md"=0A+=09=20=20=20=20=20:rewrites=20= (("\\(https://blog-example.com/[0-9]+/[0-9]+/[0-9]+/\\)"=20.=20".md"))=0A= =20=09=20=20=20=20))=0A=20=09=20(test-cases=0A=20=09=20=20(list=0A--=20=0A= 2.11.0=20(Apple=20Git-81)=0A=0A= --Apple-Mail=_9450C920-BF46-4DA4-B9D5-D9097E0E582B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Adding full test-coverage of my changes is beyond my abilities at the = moment, I must admit. But I will come back to it soon, I promise ;) Especially as there are succeeding tests for open-source using old-style = URIs. (old-style URIs are not working for me with open-source) That will be the next task for me after completing the documentation. Speaking of the documentation: is it right, that there is no more = support for =E2=80=9Cremember=E2=80=9D?=20 I would then remove that part from the documentation. Kind regards Mario =E2=80=94=20 --Apple-Mail=_9450C920-BF46-4DA4-B9D5-D9097E0E582B--