From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Highlighting bug with org-agenda-set-restriction-lock Date: Fri, 5 Apr 2013 16:12:19 +0200 Message-ID: References: <87bo9tyvdj.fsf@norang.ca> Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([208.118.235.92]:34769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO7NT-0003em-UU for emacs-orgmode@gnu.org; Fri, 05 Apr 2013 10:12:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UO7NN-0001Ix-1M for emacs-orgmode@gnu.org; Fri, 05 Apr 2013 10:12:27 -0400 Received: from ezel.ic.uva.nl ([146.50.108.158]:59580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO7NM-0001IV-PV for emacs-orgmode@gnu.org; Fri, 05 Apr 2013 10:12:20 -0400 In-Reply-To: <87bo9tyvdj.fsf@norang.ca> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bernt Hansen Cc: emacs-orgmode@gnu.org On 5 apr. 2013, at 15:12, Bernt Hansen wrote: > Hi, >=20 > The highlighting has changed for this functionality. I finally = updated > to master (1200+ commits) yesterday and when I use C-c C-x < the = entire > subtree is now highlighted in bright yellow on my Windows Emacs. >=20 > GNU Emacs 23.3.1 (i386-mingw-nt5.1.2600) of 2011-03-10 on 3249CTO >=20 > Org-mode version 7.9.2 (release_7.9.2-2030-g29a75d @ > d:/bin/org-mode/lisp/) >=20 > This used to highlight only the first heading of the subtree. > Highlighting the entire subtree is _very_ distracting and makes = working > in the org file on the narrowed subtree difficult (for me). >=20 > I can fix this by changing the face and completely removing the > highlight but I'd prefer the old functionality if that is possible. This is causes by this commit: commit aa0e0068de109eef2ac7897c4659d545b351de01 Author: Bastien Guerry Date: Sat Feb 16 23:09:57 2013 +0100 org-agenda.el (org-agenda-set-restriction-lock): Put the overlay = until the e =20 * org-agenda.el (org-agenda-set-restriction-lock): Put the overlay until the end of the subtree, not the end of the headline. =20 When the agenda restriction is on, user expect agenda views to check every entry in the subtree. If a user add an entry outside of the overlay without noticing it, this entry will not be checked and the user will wonder why. Put the end of the overlay at the end of the subtree so that the user always knows if the entries she is adding are within the current restriction. =20 We might need to find a less instrusive overlay color, though. So Bastien felt that the entire subtree should have an overlay, but maybe a softer color. I would also prefer the highlight just to be on the headline as it used to be. Bastien, how do you feel about reverting this change? I see why you did it, but it is not so practical after all if you want to work in this mode for extended time. - Carsten >=20 > I also noticed that the main heading is now also highlighted in the > agenda which is okay I guess but also different from how this used to > work :) >=20 > I haven't tried this on my Linux system at home yet. Will do that = this > weekend. >=20 > Thanks, > Bernt >=20