* Minor fix for org-attach-dir
@ 2019-09-02 21:26 Gustav Wikström
2019-09-02 21:57 ` Kyle Meyer
0 siblings, 1 reply; 3+ messages in thread
From: Gustav Wikström @ 2019-09-02 21:26 UTC (permalink / raw)
To: emacs-orgmode@gnu.org
For full transparency: An issue was found in org-brain [1] due to a
change in functionality of org-attach-dir in commit ae9cd4370.
I've given it some thought and figured that particular change in
functionality wasn't really needed and not obviously correct either.
So org-attach-dir will now check the filesystem (again) to see if the
attachment folder from DIR or ID property exist or not. The check can
be skipped with a new optional flag.
See commit 4b7eda1a2 for the fix.
[1] https://github.com/Kungsgeten/org-brain/pull/203
Regards
Gustav
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Minor fix for org-attach-dir
2019-09-02 21:26 Minor fix for org-attach-dir Gustav Wikström
@ 2019-09-02 21:57 ` Kyle Meyer
2019-09-03 20:20 ` Gustav Wikström
0 siblings, 1 reply; 3+ messages in thread
From: Kyle Meyer @ 2019-09-02 21:57 UTC (permalink / raw)
To: Gustav Wikström, emacs-orgmode@gnu.org
Hi Gustav,
Gustav Wikström <gustav@whil.se> writes:
> See commit 4b7eda1a2 for the fix.
This commit, as well as several other recent commits by you, do not
follow the project's convention regarding changelog-like entries in the
commit message. Regardless of your opinion on this convention (I
personally don't prefer it either), please try to follow it.
--
Kyle
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: Minor fix for org-attach-dir
2019-09-02 21:57 ` Kyle Meyer
@ 2019-09-03 20:20 ` Gustav Wikström
0 siblings, 0 replies; 3+ messages in thread
From: Gustav Wikström @ 2019-09-03 20:20 UTC (permalink / raw)
To: Kyle Meyer, emacs-orgmode@gnu.org
Ah, I'll read up a bit more on that to make the commits conform better,
Thanks
G
> -----Original Message-----
> From: Kyle Meyer <kyle@kyleam.com>
> Sent: den 2 september 2019 23:57
> To: Gustav Wikström <gustav@whil.se>; emacs-orgmode@gnu.org
> Subject: Re: [O] Minor fix for org-attach-dir
>
> Hi Gustav,
>
> Gustav Wikström <gustav@whil.se> writes:
>
> > See commit 4b7eda1a2 for the fix.
>
> This commit, as well as several other recent commits by you, do not
> follow the project's convention regarding changelog-like entries in the
> commit message. Regardless of your opinion on this convention (I
> personally don't prefer it either), please try to follow it.
>
> --
> Kyle
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-03 20:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-02 21:26 Minor fix for org-attach-dir Gustav Wikström
2019-09-02 21:57 ` Kyle Meyer
2019-09-03 20:20 ` Gustav Wikström
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).