Re: Re: org-mode stopped compiling recently

From: Carsten Dominik <carsten.dominik@gmail.com>
To: Eric Schulte <schulte.eric@gmail.com>
Cc: Daniel Mahler <dmahler@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: Re: org-mode stopped compiling recently
Date: Mon, 28 Jun 2010 18:12:08 +0200	[thread overview]
Message-ID: <CCD0B18D-0AEF-4C5D-B863-D31EA74F1CA4@gmail.com> (raw)
In-Reply-To: <87sk47b3iw.fsf@gmail.com>

On Jun 28, 2010, at 5:06 PM, Eric Schulte wrote:

> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> On Jun 28, 2010, at 8:15 AM, Eric Schulte wrote:
>>
>>> Thanks Daniel, I've just applied this fix. -- Eric
>>
>> Hi Eric,
>>
>> alternatively you could have done
>>
>> (require 'org-macs)
>> or
>> (require 'org)
>>
>> In fact, would it not be reasonable to require org in ob.el?
>>
>
> If I add (require 'org) to ob.el, I get the following error
>
>  In toplevel form:
>  lisp/org.el:115:1:Error: Recursive `require' for feature `ob'
>  make: *** [lisp/org.elc] Error 1

Ah, I see.

there are these solutions

1. require only org-macs, not org

2. Do not (require ob) in org-mode at all, but make it one of the  
modules
    in org-modules, default on.  Org modules works around the recursive
    require by only loading the files when org-mode is activted in
    a file for the first time.  By then, `org' was provided and no
    conflict occurs.

3. Put the require statement for ob after the (provide 'org)

I think either 1 or 2 are good solutions.

- Carsten

>
> as a consequence of requiring ob.el from within org.el.
>
> If there's a better solution please let me know what I should do.
>
> Thanks -- Eric
>
>>
>> - Carsten
>>
>>
>>>
>>> Daniel Mahler <dmahler@gmail.com> writes:
>>>
>>>> Hi Eric,
>>>>
>>>> Thanks for the looking into this.
>>>> It looks like the problem is the declare-function macro does not  
>>>> work
>>>> with emacs-22.1 (the one in ubuntu hardy)
>>>> It is defined, but undocumented.
>>>> Adding
>>>> (defmacro declare-function (FN FILE &optional ARGLIST FILEONLY)  
>>>> nil)
>>>> at the top of ob.el seems to fix everything.
>>>>
>>>> cheers
>>>> Daniel
>>>>
>>>>
>>>>
>>>> On Mon, Jun 28, 2010 at 3:01 AM, Eric Schulte
>>>> <schulte.eric@gmail.com> wrote:
>>>>> Hopefully once your make is completing without errors this problem
>>>>> will
>>>>> resolve itself.  Best -- Eric
>>>>>
>>>>> Daniel Mahler <dmahler@gmail.com> writes:
>>>>>
>>>>>> also to load the source i need to do (require 'org)
>>>>>> if i just (require 'org-install) and try to open my notes file
>>>>>> i get:
>>>>>>
>>>>>> Debugger entered--Lisp error: (void-variable org-default-notes-
>>>>>> file)
>>>>>>  (find-file org-default-notes-file)
>>>>>>
>>>>>> thanks
>>>>>> daniel
>>>>>>
>>>>>> On Mon, Jun 28, 2010 at 2:08 AM, Daniel Mahler
>>>>>> <dmahler@gmail.com> wrote:
>>>>>>> i get:
>>>>>>>
>>>>>>> ...
>>>>>>> In toplevel form:
>>>>>>> lisp/babel/ob-table.el:54:1:Error: Symbol's value as variable is
>>>>>>> void: show-all
>>>>>>> make: *** [lisp/babel/ob-table.elc] Error 1
>>>>>>>
>>>>>>> i have tried 'make clean; git pull; make'' over several days
>>>>>>> with no change.
>>>>>>> this must have happeed only last week or so,
>>>>>>> since i had a sucessful sync not long before this started.
>>>>>>>
>>>>>>> thanks
>>>>>>> daniel
>>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Emacs-orgmode mailing list
>>>>>> Please use `Reply All' to send replies to the list.
>>>>>> Emacs-orgmode@gnu.org
>>>>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>>>>
>>>
>>> _______________________________________________
>>> Emacs-orgmode mailing list
>>> Please use `Reply All' to send replies to the list.
>>> Emacs-orgmode@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>
>> - Carsten

- Carsten