From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: TODO progress regression in org-mode in Emacs pretest Date: Mon, 2 Feb 2009 22:04:37 +0100 Message-ID: References: <87fxiwlmgp.fsf@elehack.net> Mime-Version: 1.0 (Apple Message framework v930.3) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LU5yO-0003aH-UN for emacs-orgmode@gnu.org; Mon, 02 Feb 2009 16:04:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LU5yH-0003ZQ-Cn for emacs-orgmode@gnu.org; Mon, 02 Feb 2009 16:04:52 -0500 In-Reply-To: <87fxiwlmgp.fsf@elehack.net> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Michael Ekstrand Cc: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Hi Michael, I have fixed this bug and checked the changes into Emacs CVS, so they should be part of the next pretest. Thank you for the report! - Carsten On Feb 2, 2009, at 7:31 PM, Michael Ekstrand wrote: > I upgraded this morning from an Emacs CVS build from Jan 28 or 19 to > the > pretest release, and noticed a regression or undocumented change with > respect to org-after-todo-statistics-hook. I am using the org-mode > which is included in the pretest distribution. > > I have a function based on the code in section 5.5 of the Org manual > to > close projects when their subtasks are complete. Now, if I have a > headline which does not have a subtask counter in it and toggle one of > its children to DONE, my org-after-todo-statistics-hook function gets > called with n-done and n-not-done values of 0. The parent headline > thus > has its TODO status changed. > > I don't think it matters too much, as my code worked before, but my > hook > function is `org-summary-todo' from the following. The first case of > the cond is being activated. > > (defun mde-org-entry-is-project-p () > "Query whether the current headline is a project, returning > non-`nil' if it is and `nil' otherwise." > (member "PROJECT" (org-get-tags-at))) > > ;;; Taken from Org Mode manual chapter 5.5 > (defun org-summary-todo (n-done n-not-done) > "Switch entry to DONE when all subentries are done, to TODO > otherwise." > (let ((org-log-done nil) > (org-log-states nil)) > (cond > ((and (or (org-entry-is-todo-p) > (mde-org-entry-is-project-p)) > (= n-not-done 0)) > (org-todo > (if (mde-org-entry-is-project-p) > "FINISHED" > "DONE"))) > ;; Entry is a project that is marked done > ((and (mde-org-entry-is-project-p) > (not (org-entry-is-todo-p)) > (org-get-todo-state) > (> n-not-done 0)) > (org-todo 'none)) > ;; Entry is a task > ((and (not (mde-org-entry-is-project-p)) > (not (org-entry-is-todo-p)) > (org-get-todo-state) > (> n-not-done 0)) > (org-todo (org-get-todo-sequence-head)))))) > > There is a small chance that the problem was actually introduced a bit > earlier, perhaps since my Jan 20 build, but I think I would have > noticed > it after at least the Jan 28 build. > > I have CC'd bug-gnu-emacs to get this in as a bug report there as > well. > > - Michael > > -- > mouse, n: A device for pointing at the xterm in which you want to > type. > Confused by the strange files? I cryptographically sign my messages. > For more information see . > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode