From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nathaniel Flath Subject: Re: [PATCH] org-agenda tag completion works with ido Date: Sun, 16 Jul 2017 12:42:25 -0400 Message-ID: References: <87bmopdkcy.fsf@kyleam.com> <878tjsdxl4.fsf@kyleam.com> <87zic8cfg8.fsf@kyleam.com> <87wp7ccc4u.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="089e0822b3fca152dc055471f749" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWmcn-00015j-Qt for emacs-orgmode@gnu.org; Sun, 16 Jul 2017 12:42:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWmcm-00024E-KV for emacs-orgmode@gnu.org; Sun, 16 Jul 2017 12:42:29 -0400 Received: from mail-qt0-x234.google.com ([2607:f8b0:400d:c0d::234]:35959) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dWmcm-00020Q-F7 for emacs-orgmode@gnu.org; Sun, 16 Jul 2017 12:42:28 -0400 Received: by mail-qt0-x234.google.com with SMTP id 21so16482065qtx.3 for ; Sun, 16 Jul 2017 09:42:26 -0700 (PDT) In-Reply-To: <87wp7ccc4u.fsf@kyleam.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Kyle Meyer Cc: org-mode List --089e0822b3fca152dc055471f749 Content-Type: text/plain; charset="UTF-8" New patch attached. I have already signed the FSF copyright papers, so I haven't marked as TINYCHANGE - let me know if I still should. On Thu, Jul 13, 2017 at 4:31 PM, Kyle Meyer wrote: > Nathaniel Flath writes: > >> I suppose so. I still think this is a correct patch, since it doesn't >> make sense to filter for non-existent tags. > > I agreed that require-match should be t earlier in the thread, but it > turns out that that's not the source of your issue. I took time to > clarify this in order to a) help you solve your ido completion issue > everywhere, not just one specific case in one particular package, and b) > make the description in your commit message accurate, which it currently > isn't. > > Feel free to send a new patch with an updated commit message. Also, > based on the contributor list [*], you should mark it with a TINYCHANGE > cookie. It looks like you're hitting up against your TINYCHANGE code > limit, so please consider signing FSF copyright papers for future > patches. > > [*] http://orgmode.org/worg/org-contribute.html > > -- > Kyle --089e0822b3fca152dc055471f749 Content-Type: application/octet-stream; name="0001-completing-read-in-org-agenda-filter-by-tag-only-acc.patch" Content-Disposition: attachment; filename="0001-completing-read-in-org-agenda-filter-by-tag-only-acc.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j56y8s670 RnJvbSBhZjRmZTIyYzk2MmFhODNlMDM5YzRiYjg2MTFjMGU5YjlkN2Y3ZTE5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOYXRoYW5pZWwgRmxhdGggPGZsYXQwMTAzQGdtYWlsLmNvbT4K RGF0ZTogV2VkLCAxMiBKdWwgMjAxNyAxNzoxNTowNCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIGNv bXBsZXRpbmctcmVhZCBpbiBvcmctYWdlbmRhLWZpbHRlci1ieS10YWcgb25seSBhY2NlcHRzCiB2 YWxpZCB0YWdzLgoKKiBvcmctYWdlbmRhLmVsOgoob3JnLWFnZW5kYS1maWx0ZXItYnktdGFnKTog cGFzcyB0IHRvIHJlcXVpcmUtbWF0Y2ggYXJndW1lbnQgb2YgY29tcGxldGluZy1yZWFkLgpUaGlz IGNhdXNlcyBlbWFjcyB0byBhY2NlcHQgdGhlIGZ1bGwgdGFnIG5hbWUgd2hlbiBlbnRlcmluZyBh IHByZWZpeCBvZiBvbmUuCi0tLQogbGlzcC9vcmctYWdlbmRhLmVsIHwgMiArLQogMSBmaWxlIGNo YW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9v cmctYWdlbmRhLmVsIGIvbGlzcC9vcmctYWdlbmRhLmVsCmluZGV4IDlhYzRmNjU4My4uMjBkMTI4 ZDBkIDEwMDY0NAotLS0gYS9saXNwL29yZy1hZ2VuZGEuZWwKKysrIGIvbGlzcC9vcmctYWdlbmRh LmVsCkBAIC03NDk2LDcgKzc0OTYsNyBAQCBhbHNvIHByZXNzIGAtJyBvciBgKycgdG8gc3dpdGNo IGJldHdlZW4gZmlsdGVyaW5nIGFuZCBleGNsdWRpbmcuIgogCQkgICAgKG9yZy1nbG9iYWwtdGFn cy1jb21wbGV0aW9uLXRhYmxlKSkpCiAgICAgICAobGV0ICgoY29tcGxldGlvbi1pZ25vcmUtY2Fz ZSB0KSkKIAkoc2V0cSB0YWcgKGNvbXBsZXRpbmctcmVhZAotCQkgICAiVGFnOiAiIG9yZy1nbG9i YWwtdGFncy1jb21wbGV0aW9uLXRhYmxlKSkpKQorCQkgICAiVGFnOiAiIG9yZy1nbG9iYWwtdGFn cy1jb21wbGV0aW9uLXRhYmxlIG5pbCB0KSkpKQogICAgIChjb25kCiAgICAgICgoZXEgY2hhciA/ XHIpCiAgICAgICAob3JnLWFnZW5kYS1maWx0ZXItc2hvdy1hbGwtdGFnKQotLSAKMi4xMS4wIChB cHBsZSBHaXQtODEpCgo= --089e0822b3fca152dc055471f749--