From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nathaniel Flath Subject: Re: [PATCH] org-agenda tag completion works with ido Date: Thu, 13 Jul 2017 11:19:58 -0700 Message-ID: References: <87bmopdkcy.fsf@kyleam.com> <878tjsdxl4.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dViiX-0001or-Ic for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 14:20:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dViiW-00032B-B9 for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 14:20:01 -0400 Received: from mail-qt0-x234.google.com ([2607:f8b0:400d:c0d::234]:34224) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dViiW-00031v-6N for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 14:20:00 -0400 Received: by mail-qt0-x234.google.com with SMTP id 32so44844998qtv.1 for ; Thu, 13 Jul 2017 11:20:00 -0700 (PDT) In-Reply-To: <878tjsdxl4.fsf@kyleam.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Kyle Meyer Cc: org-mode List On Thu, Jul 13, 2017 at 11:02 AM, Kyle Meyer wrote: > Nathaniel Flath writes: > > [...] > >>> I'm not an ido user, but testing with >>> >>> (require 'ido-ubiquitous) >>> (ido-ubiquitous-mode 1) >>> >>> partial completion seems to work fine when I hit tab after calling >>> org-agenda-filter-by-tag. Are you using ido-ubiquitous, or are you >>> using some other package to get ido completion for non-file/buffer >>> completion? >> >> The issue is that that 'tab' is required - in the previous version of >> org, this was not required and 'enter' would do the completion for >> you. > > I'm only using tab right after calling org-agenda-filter-by-tag to get > to the initial tag prompt, following the instructions in the minibuffer. > Isn't that always needed? > > Here is how I'm testing (with emacs -Q): > > * list TODOs with the agenda (org-agenda, follow by "t") > * on an entry, hit "/" for org-agenda-filter-by-tag > * hit tab to get to the tag prompt > > Once in the prompt, I can select a partial completion by just hitting > enter. I follow the same steps: * list TODOs with the agenda (org-agenda, follow by "t") * on an entry, hit "/" for org-agenda-filter-by-tag * hit tab to get to the tag prompt * type 'ho' + enter - this causes everything to disappear, because it is trying to filter for 'ho' instead of 'home' ('ho' is not a valid tag) I've upgraded to the lastest version of ido-ubiquitous and this behaviour persists. (This is also my understanding of what the expected behaviour should be, based on testing of completing-read and reading the function docs). > > I've executed the above steps with two setups: > release_8.3.6/org-completion-use-ido and release_9.0.9/ido-ubiquitous. > I couldn't spot any differences. Hitting enter for partial completion > worked in both cases. > >>> In this particular case, your change looks OK because I think all useful >>> values should be in the collection. But I don't understand why you're >>> not able to do partial completion without this change. Are you running >>> into the same issue everywhere else that completing-read is called with >>> a nil value for require-match? >> >> I haven't checked everywhere else - presumably. > > It'd be good to figure out why you're seeing different behavior than I > am. Perhaps the steps I list above aren't the right steps to trigger > it. Or maybe you have some non-default ido configuration. Or maybe the > difference comes from an ido version mismatch. (I'm using the ido from > Emacs 25.2 and ido-ubiquitous checked out at v3.14-4-ga1c2965.) I'm on emacs 24.5.1 - I'll try updating, but I suspect the problem will persist. > > As it stands, I can't reproduce the problem described in your commit > message. > > -- > Kyle