From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pontus Michael Subject: Re: [PATCH] Source block fontification handling indentation Date: Wed, 26 Mar 2014 02:11:27 +0400 Message-ID: References: <87eh1wdkpe.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11c25d482d22e704f575a2db Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSZZC-00084O-L0 for emacs-orgmode@gnu.org; Tue, 25 Mar 2014 18:11:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSZZB-0007pU-DX for emacs-orgmode@gnu.org; Tue, 25 Mar 2014 18:11:30 -0400 In-Reply-To: <87eh1wdkpe.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org --001a11c25d482d22e704f575a2db Content-Type: multipart/alternative; boundary=001a11c25d482d22e104f575a2d9 --001a11c25d482d22e104f575a2d9 Content-Type: text/plain; charset=ISO-8859-1 Sorry, the code in last source block in my attachment got a little bit messed up. I corrected it in this attachment. On 21 March 2014 12:23, Bastien wrote: > Hi Michael, > > thanks for the patch. > > Pontus Michael writes: > > > Primary reason for this change is to fix the problem which I describe > > as > > follows: > > > > This function is not 100% compatible with a org-edit-src facility, > > which provides an option to have indentation added to the code inside > > the block after using command `org-edit-src-code' to edit it. This > > command also handles removal of indentation upon insertion of the > > code > > in temporary buffer where editing of the code will in relevant > > major-mode. > > I'm not sure I understand what the real problem is. > > Can you describe it against the behavior of the current version? > And maybe provide a minimal recipe to reproduce it? > > Did you catch any side-effect of your patch? > > Thanks, > > -- > Bastien > --001a11c25d482d22e104f575a2d9 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Sorry, the code in last source block in my attachment got = a little bit messed up. I corrected it in this attachment.


On 21 March 2014 12:= 23, Bastien <bzg@gnu.org> wrote:
Hi Michael,

thanks for the patch.

Pontus Michael <m.pontus@gmail.com= > writes:

> Primary reason for this change is to fix the problem which I describe<= br> > as
> follows:
>
> This function is not 100% compatible with a org-edit-src facility,
> which provides an option to have indentation added to the code inside<= br> > the block after using command `org-edit-src-code' to edit it. This=
> command also handles removal of indentation upon insertion of the
> code
> in temporary buffer where editing of the code will in relevant
> major-mode.

I'm not sure I understand what the real problem is.

Can you describe it against the behavior of the current version?
And maybe provide a minimal recipe to reproduce it?

Did you catch any side-effect of your patch?

Thanks,

--
=A0Bastien

--001a11c25d482d22e104f575a2d9-- --001a11c25d482d22e704f575a2db Content-Type: application/vnd.lotus-organizer; name="fontification-example.org" Content-Disposition: attachment; filename="fontification-example.org" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ht7qaa800 T2JzZXJ2ZSB0aGUgZGlmZmVyZW5jZSBpbiBiZWhhdmlvdXIgYnkgZXhlY3V0aW5nIGNvbW1hbmQK YG9yZy1zcmMtZm9udGlmeS1ibG9jaycgb24gc291cmNlIGJsb2NrcyBiZWxvdy4KIytCRUdJTl9T UkMgZW1hY3MtbGlzcCA6cmVzdWx0cyBzaWxlbnQKICAoc2F2ZS1leGN1cnNpb24KICAgICh3aGls ZSAoaWdub3JlLWVycm9ycyAob3JnLWJhYmVsLW5leHQtc3JjLWJsb2NrKSB0KQogICAgICAob3Jn LXNyYy1mb250aWZ5LWJsb2NrKSkpCiMrRU5EX1NSQwoKVGhpcyBpcyB3aGF0IGNvcnJlY3RseSBm b250aWZpZWQgYmxvY2sgc2hvdWxkIGxvb2sgbGlrZToKIytCRUdJTl9TUkMgZGlmZgpkaWZmIC0t Z2l0IGEvbGlzcC9vcmctc3JjLmVsIGIvbGlzcC9vcmctc3JjLmVsCmluZGV4IDZlMDFiOGEuLjhj ZTRhOGIgMTAwNjQ0Ci0tLSBhL2xpc3Avb3JnLXNyYy5lbAorKysgYi9saXNwL29yZy1zcmMuZWwK QEAgLTkyMiw2ICs5MjIsNyBAQCBmb250aWZpY2F0aW9uIG9mIGNvZGUgYmxvY2tzIHNlZSBgb3Jn LXNyYy1mb250aWZ5LWJsb2NrJyBhbmQKICAgICAgICAgICAgICAoZ2V0LWJ1ZmZlci1jcmVhdGUK ICAgICAgICAgICAgICAgKGNvbmNhdCAiIG9yZy1zcmMtZm9udGlmaWNhdGlvbjoiIChzeW1ib2wt bmFtZSBsYW5nLW1vZGUpKSkKICAgICAgICAgICAgKGRlbGV0ZS1yZWdpb24gKHBvaW50LW1pbikg KHBvaW50LW1heCkpCiAgICAgICAgICAgIChpbnNlcnQgc3RyaW5nICIgIikgOzsgc28gdGhlcmUn cyBhIGZpbmFsIHByb3BlcnR5IGNoYW5nZQorICAgICAgICAgICAodW5sZXNzIG9yZy1zcmMtcHJl c2VydmUtaW5kZW50YXRpb24gKG9yZy1kby1yZW1vdmUtaW5kZW50YXRpb24pKQogICAgICAgICAg ICAodW5sZXNzIChlcSBtYWpvci1tb2RlIGxhbmctbW9kZSkgKGZ1bmNhbGwgbGFuZy1tb2RlKSkK ICAgICAgICAgICAgKGZvbnQtbG9jay1mb250aWZ5LWJ1ZmZlcikKCiMrRU5EX1NSQwoKRm9udGlm aWNhdGlvbiBvbiB0aGlzIGJsb2NrIHdpbGwgZmFpbCBiZWNhdXNlIG9mIHByZXNlbnQgaW5kZW50 YXRpb246CiMrQkVHSU5fU1JDIGRpZmYKICBkaWZmIC0tZ2l0IGEvbGlzcC9vcmctc3JjLmVsIGIv bGlzcC9vcmctc3JjLmVsCiAgaW5kZXggNmUwMWI4YS4uOGNlNGE4YiAxMDA2NDQKICAtLS0gYS9s aXNwL29yZy1zcmMuZWwKICArKysgYi9saXNwL29yZy1zcmMuZWwKICBAQCAtOTIyLDYgKzkyMiw3 IEBAIGZvbnRpZmljYXRpb24gb2YgY29kZSBibG9ja3Mgc2VlIGBvcmctc3JjLWZvbnRpZnktYmxv Y2snIGFuZAogICAgICAgICAgICAgICAgKGdldC1idWZmZXItY3JlYXRlCiAgICAgICAgICAgICAg ICAgKGNvbmNhdCAiIG9yZy1zcmMtZm9udGlmaWNhdGlvbjoiIChzeW1ib2wtbmFtZSBsYW5nLW1v ZGUpKSkKICAgICAgICAgICAgICAoZGVsZXRlLXJlZ2lvbiAocG9pbnQtbWluKSAocG9pbnQtbWF4 KSkKICAgICAgICAgICAgICAoaW5zZXJ0IHN0cmluZyAiICIpIDs7IHNvIHRoZXJlJ3MgYSBmaW5h bCBwcm9wZXJ0eSBjaGFuZ2UKICArICAgICAgICAgICAodW5sZXNzIG9yZy1zcmMtcHJlc2VydmUt aW5kZW50YXRpb24gKG9yZy1kby1yZW1vdmUtaW5kZW50YXRpb24pKQogICAgICAgICAgICAgICh1 bmxlc3MgKGVxIG1ham9yLW1vZGUgbGFuZy1tb2RlKSAoZnVuY2FsbCBsYW5nLW1vZGUpKQogICAg ICAgICAgICAgIChmb250LWxvY2stZm9udGlmeS1idWZmZXIpCiMrRU5EX1NSQwoKWW91IHdpbGwg YmUgYWJsZSB0byBvYnNlcnZlIGNvcnJlY3QgZm9udGlmaWNhdGlvbiBvbiBib3RoIGJsb2NrcyBi eQphcHBseWluZyBuZXcgZGVmaW5pdGlvbiBvZiBmdW5jdGlvbiBgb3JnLXNyYy1mb250LWxvY2st Zm9udGlmeS1ibG9jaycKcHJvZHVjZWQgYnkgbXkgcGF0Y2g6CgojK0JFR0lOX1NSQyBlbWFjcy1s aXNwIDpyZXN1bHRzIHNpbGVudAogIChkZWZ1biBvcmctc3JjLWZvbnQtbG9jay1mb250aWZ5LWJs b2NrIChsYW5nIHN0YXJ0IGVuZCkKICAgICJGb250aWZ5IGNvZGUgYmxvY2suCiAgVGhpcyBmdW5j dGlvbiBpcyBjYWxsZWQgYnkgZW1hY3MgYXV0b21hdGljIGZvbnRpZmljYXRpb24sIGFzIGxvbmcK ICBhcyBgb3JnLXNyYy1mb250aWZ5LW5hdGl2ZWx5JyBpcyBub24tbmlsLiAgRm9yIG1hbnVhbAog IGZvbnRpZmljYXRpb24gb2YgY29kZSBibG9ja3Mgc2VlIGBvcmctc3JjLWZvbnRpZnktYmxvY2sn IGFuZAogIGBvcmctc3JjLWZvbnRpZnktYnVmZmVyJyIKICAgIChsZXQgKChsYW5nLW1vZGUgKG9y Zy1zcmMtZ2V0LWxhbmctbW9kZSBsYW5nKSkpCiAgICAgIChpZiAoZmJvdW5kcCBsYW5nLW1vZGUp CiAgICAgICAgICAobGV0ICgoc3RyaW5nIChidWZmZXItc3Vic3RyaW5nLW5vLXByb3BlcnRpZXMg c3RhcnQgZW5kKSkKICAgICAgICAgICAgICAgIChtb2RpZmllZCAoYnVmZmVyLW1vZGlmaWVkLXAp KQogICAgICAgICAgICAgICAgKG9yZy1idWZmZXIgKGN1cnJlbnQtYnVmZmVyKSkgcG9zIG5leHQp CiAgICAgICAgICAgIChyZW1vdmUtdGV4dC1wcm9wZXJ0aWVzIHN0YXJ0IGVuZCAnKGZhY2Ugbmls KSkKICAgICAgICAgICAgKHdpdGgtY3VycmVudC1idWZmZXIKICAgICAgICAgICAgICAgIChnZXQt YnVmZmVyLWNyZWF0ZQogICAgICAgICAgICAgICAgIChjb25jYXQgIiBvcmctc3JjLWZvbnRpZmlj YXRpb246IiAoc3ltYm9sLW5hbWUgbGFuZy1tb2RlKSkpCiAgICAgICAgICAgICAgKGRlbGV0ZS1y ZWdpb24gKHBvaW50LW1pbikgKHBvaW50LW1heCkpCiAgICAgICAgICAgICAgKGluc2VydCBzdHJp bmcgIiAiKSA7OyBzbyB0aGVyZSdzIGEgZmluYWwgcHJvcGVydHkgY2hhbmdlCiAgICAgICAgICAg ICAgKHVubGVzcyBvcmctc3JjLXByZXNlcnZlLWluZGVudGF0aW9uIChvcmctZG8tcmVtb3ZlLWlu ZGVudGF0aW9uKSkKICAgICAgICAgICAgICAodW5sZXNzIChlcSBtYWpvci1tb2RlIGxhbmctbW9k ZSkgKGZ1bmNhbGwgbGFuZy1tb2RlKSkKICAgICAgICAgICAgICAoZm9udC1sb2NrLWZvbnRpZnkt YnVmZmVyKQogICAgICAgICAgICAgIChzZXRxIHBvcyAocG9pbnQtbWluKSkKICAgICAgICAgICAg ICAod2hpbGUgKHNldHEgbmV4dCAobmV4dC1zaW5nbGUtcHJvcGVydHktY2hhbmdlIHBvcyAnZmFj ZSkpCiAgICAgICAgICAgICAgICAodW5sZXNzIG9yZy1zcmMtcHJlc2VydmUtaW5kZW50YXRpb24K ICAgICAgICAgICAgICAgICAgKGxldCAoKGVvbCAoc2F2ZS1leGN1cnNpb24gKGdvdG8tY2hhciBw b3MpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChsaW5lLWVu ZC1wb3NpdGlvbikpKSkKICAgICAgICAgICAgICAgICAgICAod2l0aC1jdXJyZW50LWJ1ZmZlciBv cmctYnVmZmVyCiAgICAgICAgICAgICAgICAgICAgICAoZ290by1jaGFyICgrIHN0YXJ0ICgxLSBw b3MpKSkKICAgICAgICAgICAgICAgICAgICAgIChzZXRxIHN0YXJ0ICgtIChsaW5lLWVuZC1wb3Np dGlvbikgKDEtIGVvbCkpKSkKICAgICAgICAgICAgICAgICAgICAod2hlbiAoPCBlb2wgbmV4dCkK ICAgICAgICAgICAgICAgICAgICAgIChzZXRxIG5leHQgKDErIGVvbCkpKSkpCiAgICAgICAgICAg ICAgICAocHV0LXRleHQtcHJvcGVydHkKICAgICAgICAgICAgICAgICAoKyBzdGFydCAoMS0gcG9z KSkgKDEtICgrIHN0YXJ0IG5leHQpKSAnZmFjZQogICAgICAgICAgICAgICAgIChnZXQtdGV4dC1w cm9wZXJ0eSBwb3MgJ2ZhY2UpIG9yZy1idWZmZXIpCiAgICAgICAgICAgICAgICAoc2V0cSBwb3Mg bmV4dCkpKQogICAgICAgICAgICAoYWRkLXRleHQtcHJvcGVydGllcwogICAgICAgICAgICAgc3Rh cnQgZW5kCiAgICAgICAgICAgICAnKGZvbnQtbG9jay1mb250aWZpZWQgdCBmb250aWZpZWQgdCBm b250LWxvY2stbXVsdGlsaW5lIHQpKQogICAgICAgICAgICAoc2V0LWJ1ZmZlci1tb2RpZmllZC1w IG1vZGlmaWVkKSkpKSkKIytFTkRfU1JDCg== --001a11c25d482d22e704f575a2db--