From mboxrd@z Thu Jan 1 00:00:00 1970 From: Abhishek Chandratre Subject: [PATCHATTACHED] Fixing org-store-link for eshell Date: Tue, 20 Aug 2019 22:55:11 -0700 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000005b04805909a3884" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:60644) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0Jaf-0005oQ-HF for emacs-orgmode@gnu.org; Wed, 21 Aug 2019 01:55:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0Jae-0008Hh-IB for emacs-orgmode@gnu.org; Wed, 21 Aug 2019 01:55:25 -0400 Received: from mail-yb1-xb2c.google.com ([2607:f8b0:4864:20::b2c]:41098) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i0Jae-0008H8-Cf for emacs-orgmode@gnu.org; Wed, 21 Aug 2019 01:55:24 -0400 Received: by mail-yb1-xb2c.google.com with SMTP id 1so122413ybj.8 for ; Tue, 20 Aug 2019 22:55:23 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org --00000000000005b04805909a3884 Content-Type: multipart/alternative; boundary="00000000000005b04505909a3882" --00000000000005b04505909a3882 Content-Type: text/plain; charset="UTF-8" Hello all, Thank you for supporting and maintaining org mode. I wanted to use org-store-link for eshell, but it failed. Looked like dired-directory was nil, I fixed it by calling (eshell/pwd) to get pwd. I tested with and without TRAMP, works like a charm. The patch did not create new test case failures, but for master branch on my machine I saw 6 test case failure (not related to patch). 6 unexpected results: FAILED ob-sed-test/cmd-line-header-argument FAILED ob-shell/bash-uses-assoc-arrays FAILED ob-tangle/jump-to-org FAILED test-ob-shell/session FAILED test-org-attach/dir FAILED test-org-table/sort-lines I will try investigate and address them in another patch. Thanks, -Abhishek --00000000000005b04505909a3882 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello all,
Thank you= for supporting and maintaining org mode.

I wa= nted to use org-store-link for eshell, but it failed.
Looked like= dired-directory was nil, I fixed it by calling (eshell/pwd) to get pwd.
I tested with and without TRAMP, works like a charm.

=
The patch did not create new test case failures, but for master = branch on my machine I saw 6 test case failure (not related to patch).

6 unexpected results:
=C2=A0 =C2=A0FAIL= ED =C2=A0ob-sed-test/cmd-line-header-argument
=C2=A0 =C2=A0FAILED= =C2=A0ob-shell/bash-uses-assoc-arrays
=C2=A0 =C2=A0FAILED =C2=A0= ob-tangle/jump-to-org
=C2=A0 =C2=A0FAILED =C2=A0test-ob-shell/ses= sion
=C2=A0 =C2=A0FAILED =C2=A0test-org-attach/dir
=C2= =A0 =C2=A0FAILED =C2=A0test-org-table/sort-lines

=
I will try investigate and address them in another patch.
Thanks,
-Abhishek


<= br>
=C2=A0=C2=A0
--00000000000005b04505909a3882-- --00000000000005b04805909a3884 Content-Type: application/octet-stream; name="0001-ol-eshell.el-Fix-org-store-link-for-eshell.patch" Content-Disposition: attachment; filename="0001-ol-eshell.el-Fix-org-store-link-for-eshell.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jzku5ia00 RnJvbSAzN2M3N2Q4ZTU2MzQyOGRjYzQ0YzY5ZmE0Y2QzNzc2Mzk3MzA3MzRmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYmhpc2hlayBDaGFuZHJhdHJlIDxhYmhpc2hlay5jaGFuZHJh dHJlQGdtYWlsLmNvbT4KRGF0ZTogVHVlLCAyMCBBdWcgMjAxOSAyMjoyNjozMCAtMDcwMApTdWJq ZWN0OiBbUEFUQ0hdIG9sLWVzaGVsbC5lbDogRml4IG9yZy1zdG9yZS1saW5rIGZvciBlc2hlbGwK Cmxpc3Avb2wtZXNoZWxsLmVsIChvcmctZXNoZWxsLXN0b3JlLWxpbmspOiBSZXBsYWNlIGBkaXJl ZC1kaXJlY3RvcnknCnZhcmlhYmxlIHdpdGggYGVzaGVsbC9wd2QnIGZ1bmN0aW9uIHRvIGZpbmQg Y3VycmVudCBkaXJlY3RvcnkuCgpEdXJpbmcgb3JnLXN0b3JlLWxpbmsgYGRpcmVkLWRpcmVjdG9y eScgdmFyaWFibGUgcmV0dXJucyBuaWwuClRodXMgcmVwbGFjaW5nIGl0IHdpdGggKGVzaGVsbC9w d2QpLCB3aGljaCByZXR1cm5zIHB3ZC4KClRJTllDSEFOR0UKLS0tCiBsaXNwL29sLWVzaGVsbC5l bCB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoK ZGlmZiAtLWdpdCBhL2xpc3Avb2wtZXNoZWxsLmVsIGIvbGlzcC9vbC1lc2hlbGwuZWwKaW5kZXgg NGRlNjU3NDYxLi5hOWE3MmE1MzQgMTAwNjQ0Ci0tLSBhL2xpc3Avb2wtZXNoZWxsLmVsCisrKyBi L2xpc3Avb2wtZXNoZWxsLmVsCkBAIC01NSw3ICs1NSw3IEBACiAgICJTdG9yZSBhIGxpbmsgdGhh dCwgd2hlbiBvcGVuZWQsIHN3aXRjaGVzIGJhY2sgdG8gdGhlIGN1cnJlbnQgZXNoZWxsIGJ1ZmZl cgogICAgYW5kIHRoZSBjdXJyZW50IHdvcmtpbmcgZGlyZWN0b3J5LiIKICAgKHdoZW4gKGVxIG1h am9yLW1vZGUgJ2VzaGVsbC1tb2RlKQotICAgIChsZXQqICgoY29tbWFuZCAoY29uY2F0ICJjZCAi IGRpcmVkLWRpcmVjdG9yeSkpCisgICAgKGxldCogKChjb21tYW5kIChjb25jYXQgImNkICIgKGVz aGVsbC9wd2QpKSkKICAgICAgICAgICAgKGxpbmsgIChjb25jYXQgKGJ1ZmZlci1uYW1lKSAiOiIg Y29tbWFuZCkpKQogICAgICAgKG9yZy1saW5rLXN0b3JlLXByb3BzCiAgICAgICAgOmxpbmsgKGNv bmNhdCAiZXNoZWxsOiIgbGluaykKLS0gCjIuMjAuMSAoQXBwbGUgR2l0LTExNykKCg== --00000000000005b04805909a3884--