emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Takafumi Arakaki <aka.tkf@gmail.com>
To: Bastien <bzg@altern.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Support hour in repeated task cookie
Date: Thu, 26 Apr 2012 16:38:24 +0200	[thread overview]
Message-ID: <CAPM+gBRhvAcebErUbwroYGW+AhyaFpzkradkMRt2WTtSPOLCJw@mail.gmail.com> (raw)
In-Reply-To: <87bomi7fwr.fsf@altern.org>

Hi, Bastien

Thanks for the patch and I am sorry for this late reply (especially
because I pushed maintainers to review my patch before...).

Anyway, I tried the head of master
(580add2f4148fea949a4db5550577911ee6d756e) and it works fine for me.
But I couldn't reproduce this behavior:

> Note that timestamps need to be well formatted.  If there is
> a +3d repeat cookie and the original timestamp doesn have any
> indication for the hour, it will produce an error.

(BTW, you mean +3h, right?)  There is no change in the SCHEDULE time
stamp, but I've got state change log and LAST_REPEAT in PROPERTIES.
Note that I have `(setq org-log-into-drawer t)' in my configuration.
Resulting tree was something like this (I changed the state to DONE
three times):

* TODO Test
  SCHEDULED: <2012-04-26 Thu +3h>
  - State "DONE"       from "TODO"        [2012-04-26 Thu 16:16]
  - State "DONE"       from "TODO"        [2012-04-26 Thu 16:16]
  - State "DONE"       from "TODO"        [2012-04-26 Thu 16:16]
  :LAST_REPEAT: [2012-04-26 Thu 16:16]

Regarding not using constant for "dwmy".

> I didn't replace "dwmy" by a constant though, this is not expected
> to change anymore.

I think somebody may want to have minute cookie.  And in that case,
repeating the same task is tiresome.  I didn't put minute in my patch
simply because I didn't know what letter I should use.  I guess no one
wants second or century though.  So maybe we should decide what letter
to use for minute and change "dwmy" again, if you don't like the
constant solution?


  reply	other threads:[~2012-04-26 14:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27 21:22 [PATCH] Support hour in repeated task cookie Takafumi Arakaki
2012-03-31 20:54 ` Takafumi Arakaki
2012-04-01  8:25   ` Bastien
2012-04-23 13:10   ` Bastien
2012-04-26 14:38     ` Takafumi Arakaki [this message]
2012-04-27 21:34       ` Bastien
2012-04-20 14:57 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPM+gBRhvAcebErUbwroYGW+AhyaFpzkradkMRt2WTtSPOLCJw@mail.gmail.com \
    --to=aka.tkf@gmail.com \
    --cc=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).