From: Michael Dauer <mick.dauer@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: BUG: org-cut-special on inlinetask kill until point-max
Date: Thu, 17 Aug 2023 15:05:55 +0200 [thread overview]
Message-ID: <CAP7OBxJpjA-oJwUEd8jcm4uD47_3d-OCanr1qoSnPNurraCuTQ@mail.gmail.com> (raw)
In-Reply-To: <87fs4hrjmn.fsf@localhost>
[-- Attachment #1: Type: text/plain, Size: 2858 bytes --]
I understand your view. From the user perspective inline task are still
more a specialization of a task, which is a specialisation of a heading.
Here is my implementation of how I see it that it should behave:
(defun pm-cut-special ()
"Like org-cut-special but also works on inlinetask."
(interactive)
(if (not (eq 'inlinetask (save-excursion (org-back-to-heading t)
(org-element-type (org-element-context)))))
(funcall-interactively 'org-cut-special)
(org-inlinetask-goto-beginning)
(let ((begin (point)))
(org-inlinetask-goto-end)
(kill-region begin (point))
(message "Cut: Inline Task"))))
(defun pm-copy-special ()
"Like org-copy-special but also works on inlinetask."
(interactive)
(if (not (eq 'inlinetask (save-excursion (org-back-to-heading t)
(org-element-type (org-element-context)))))
(funcall-interactively 'org-cut-special)
(org-inlinetask-goto-beginning)
(let ((begin (point)))
(org-inlinetask-goto-end)
(copy-region-as-kill begin (point))
(message "Copied: Inline Task"))))
(defun pm-paste-special (arg)
"Like org-paste-special but also works on inlinetask."
(interactive "P")
(if (not (eq 'inlinetask
(with-temp-buffer
(org-mode)
(insert (current-kill 0 t))
(goto-char (point-min))
(org-element-type (org-element-context)))))
(funcall-interactively 'org-paste-special arg)
(unless (eq (point) (pos-bol))
(forward-line))
(yank)))
There is a fine-tuning outstanding: The criteria whether to paste before or
after the current line should not be the point on the begin-of-line but the
beginning of the actual heading (after the asterisks).
Am Do., 17. Aug. 2023 um 13:30 Uhr schrieb Ihor Radchenko <
yantar92@posteo.net>:
> Michael Dauer <mick.dauer@gmail.com> writes:
>
> > I probably mis-interpreted the code. Because then I would also fail for
> > normal headings. Just thinking about the symptoms I think the issue Is
> that
> > (org-end-of-subtree) works with type 'headline. And inlinetask is a
> > different type, right?
>
> Yes. Inlinetask is not considered a subtree of its own.
> Just like other foldable elements (lists/drawers/blocks) are not
> considered subtrees.
>
> > IMO org-mode should consistently treat inlinetasks including the END line
> > as a branch. Then org-cut-special would do something useful on them, i.e.
> > cutting the inlinetask includinging its contents and the END line.
>
> It would not be consistent. We already do not treat, for example, lists
> special in `org-cut-special'.
>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>
>
[-- Attachment #2: Type: text/html, Size: 3913 bytes --]
next prev parent reply other threads:[~2023-08-17 13:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 11:14 BUG: org-cut-special on inlinetask kill until point-max Michael Dauer
2023-08-16 11:48 ` Ihor Radchenko
2023-08-16 11:57 ` Michael Dauer
2023-08-16 12:12 ` Ihor Radchenko
2023-08-16 15:55 ` Michael Dauer
2023-08-16 16:02 ` Ihor Radchenko
2023-08-17 8:42 ` Michael Dauer
2023-08-17 8:56 ` Ihor Radchenko
2023-08-17 9:00 ` Michael Dauer
2023-08-17 11:30 ` Ihor Radchenko
2023-08-17 13:05 ` Michael Dauer [this message]
2023-08-17 17:50 ` [POLL] Should org-copy/cut/paste-special handle inlinetasks specially? (was: BUG: org-cut-special on inlinetask kill until point-max) Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP7OBxJpjA-oJwUEd8jcm4uD47_3d-OCanr1qoSnPNurraCuTQ@mail.gmail.com \
--to=mick.dauer@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).