emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bill Wishon <bill@wishon.org>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] fix hook calling in org-export-remove-or-extract-drawers
Date: Tue, 1 May 2012 07:46:56 -0700	[thread overview]
Message-ID: <CAP2uJAspdydP+nGc27yWW642Lk8WhScNwSmjoJ0-s-KvhxzxaA@mail.gmail.com> (raw)
In-Reply-To: <87aa1sw78b.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

Hi Bastien,

I'll try to find a different mail client next time.

On Tue, May 1, 2012 at 3:01 AM, Bastien <bzg@gnu.org> wrote:

> I don't really understand why `run-hook-with-args-until-success' is
> needed here.  Or `org-export-format-drawer-function' returns a string,
> or it returns nil, in case we fall back on `org-export-format-drawer'.
>

My thought was that you could have multiple hooks in
org-export-format-drawer-function and each one could be checking for things
like "is this html export", "is the drawer name == PROPERTIES" and could
decide to take action and return a string, or perhaps take no action,
return nil, and let another hook have a shot at the drawer.  The other
thing with funcall here is that if you use add-hook to add your function to
that hook it creates a list of functions, and when funcall is called on a
list of functions instead of an individual function it is an error.

Best,
~>Bill

[-- Attachment #2: Type: text/html, Size: 1246 bytes --]

  reply	other threads:[~2012-05-01 14:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-01  1:20 [PATCH] fix hook calling in org-export-remove-or-extract-drawers Bill Wishon
2012-05-01 10:01 ` Bastien
2012-05-01 14:46   ` Bill Wishon [this message]
2012-05-01 17:58     ` Bastien
2012-05-01 18:02       ` Bill Wishon
2012-05-01 18:18       ` Nicolas Goaziou
2012-05-01 18:29         ` Bill Wishon
2012-05-02 12:35           ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP2uJAspdydP+nGc27yWW642Lk8WhScNwSmjoJ0-s-KvhxzxaA@mail.gmail.com \
    --to=bill@wishon.org \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).