emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Jay Bosamiya <jaybosamiya@gmail.com>
To: Bastien <bzg@gnu.org>, Timothy <tecosaur@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Add org-meta*-final-hook
Date: Sat, 22 May 2021 22:29:48 -0400	[thread overview]
Message-ID: <CAOywxZjejAzbhjvAgA-d0NwzZyxyYwaSvnu1WVeZHY3APUMJFQ@mail.gmail.com> (raw)
In-Reply-To: <87zgwwcep2.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]

Hi Bastien and Timothy,

Thanks for taking a look at this. Apologies for the delay in getting back
to you.

First: I've started the FSF assignment process. I'd be happy to ping again
on this thread again once I hear back from there, if we need to wait for
that to complete.

Second: I indeed do use this patch regularly. I use these final hooks to
provide the same windmove bindings that I use regularly outside org-mode
too. Specifically, I use windmove with `(windmove-default-keybindings
'meta)` which means that rather than the "standard" default (of
shift-direction keys for which the solution for the keybinding conflict in
https://orgmode.org/manual/Conflicts.html is to use the
shift*-final-hooks), I use meta-direction keys, and thus need to have a
meta*-final-hooks, to be able to continue using windmove alongside org-mode.

Thanks again!

Cheers,
Jay



On Sat, May 15, 2021 at 9:24 AM Bastien <bzg@gnu.org> wrote:

> Hi,
>
> Jay Bosamiya <jaybosamiya@gmail.com> writes:
>
> > Similar to org-shiftup-final-hook, org-shiftdown-final-hook, etc, I
> > have added org-metaup-final-hook, org-metadown-final-hook, etc.
>
> Without a concrete example of why this would be needed, I suggest to
> set this aside (i.e. no need to add this code just for consistency.)
>
> Jay, if you actually use this patch for your own needs, let us know
> with an example.
>
> Thanks,
>
> --
>  Bastien
>

[-- Attachment #2: Type: text/html, Size: 2056 bytes --]

      reply	other threads:[~2021-05-23  2:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28 22:37 Jay Bosamiya
2021-04-25  6:31 ` Timothy
2021-04-27 20:37 ` Bastien
2021-05-15 13:24 ` Bastien
2021-05-23  2:29   ` Jay Bosamiya [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOywxZjejAzbhjvAgA-d0NwzZyxyYwaSvnu1WVeZHY3APUMJFQ@mail.gmail.com \
    --to=jaybosamiya@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=tecosaur@gmail.com \
    --subject='Re: [PATCH] Add org-meta*-final-hook' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).