From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pip Cet Subject: Re: re-search-forward hang in org-link-search Date: Fri, 14 Aug 2015 16:55:34 +0000 Message-ID: References: <87614ig3p4.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a113ed2f80b109e051d48527e Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQIGZ-000189-Qn for emacs-orgmode@gnu.org; Fri, 14 Aug 2015 12:55:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZQIGW-0006bU-6A for emacs-orgmode@gnu.org; Fri, 14 Aug 2015 12:55:39 -0400 Received: from mail-io0-x231.google.com ([2607:f8b0:4001:c06::231]:34272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQIGV-0006aW-Oc for emacs-orgmode@gnu.org; Fri, 14 Aug 2015 12:55:36 -0400 Received: by iodb91 with SMTP id b91so90528640iod.1 for ; Fri, 14 Aug 2015 09:55:34 -0700 (PDT) In-Reply-To: <87614ig3p4.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Pip Cet , Matthew MacLean , emacs-orgmode@gnu.org --001a113ed2f80b109e051d48527e Content-Type: text/plain; charset=UTF-8 Hi Nicolas, On Thu, Aug 13, 2015 at 11:37 PM, Nicolas Goaziou wrote: > Hello, > > Pip Cet writes: > >> Can you try this patch? That appears to fix the issue here, at least >> for this one file, at the cost of yet another shy group added to the >> regular expression. > > Thanks for the patch. > > Would you mind providing a proper commit message and send it again using > "git format-patch"? Of course, here we go. Please let me know if there's anything wrong with it still. (I don't think gmail copy-and-paste preserves tabs, so this is sent as an attachment. Is that okay, for future reference?) It would be great if README_contribute could be updated no longer to refer to ChangeLog files, and instead refer to the Emacs CONTRIBUTE file (it would also be great if the special git commit messages could be generated as easily as C-x 4 a does for ChangeLog entries. What do people use for that?); I've attached a patch to change that as well, but I'm not sure whether it's still properly a TINYCHANGE. Again, it would be great if you could let me know if there's anything wrong with it so I can avoid making the same mistake for future contributions. Thanks! Pip --001a113ed2f80b109e051d48527e Content-Type: text/x-patch; charset=US-ASCII; name="0001-org.el-fix-recursive-regular-expression-backtracking.patch" Content-Disposition: attachment; filename="0001-org.el-fix-recursive-regular-expression-backtracking.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_idbvk11j0 RnJvbSA0ZGFjMDQ3ODQ5YmRiNDRiNjMxZjBiOGQ3MDEzZWIwZTE1YTBmNTEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXAgPHBpcGNldEBnbWFpbC5jb20+CkRhdGU6IFRodSwg MTMgQXVnIDIwMTUgMTg6NDk6NTYgKzAwMDAKU3ViamVjdDogW1BBVENIIDEvMl0gb3JnLmVsOiBm aXggcmVjdXJzaXZlIHJlZ3VsYXIgZXhwcmVzc2lvbiBiYWNrdHJhY2tpbmcKCgkqIG9yZy5lbCAo b3JnLWxpbmstc2VhcmNoKTogQXZvaWQgcmVjdXJzaXZlIHJlZ2V4cAoJYmFja3RyYWNraW5nIGJl aGF2aW91ciB3aGVuIGZvbGxvd2luZyBzZWFyY2ggbGlua3MuCgoJPGh0dHA6Ly9hcnRpY2xlLmdt YW5lLm9yZy9nbWFuZS5lbWFjcy5vcmdtb2RlLzEwMDAxMD4KCglUSU5ZQ0hBTkdFCi0tLQogbGlz cC9vcmcuZWwgfCA4ICsrKystLS0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avb3JnLmVsIGIvbGlzcC9vcmcuZWwKaW5k ZXggYTkwOGQ5ZS4uN2Y0NjY4NyAxMDA3NTUKLS0tIGEvbGlzcC9vcmcuZWwKKysrIGIvbGlzcC9v cmcuZWwKQEAgLTExMTI4LDE4ICsxMTEyOCwxOCBAQCBvZiBtYXRjaGVkIHJlc3VsdCwgd2l0aCBp cyBlaXRoZXIgYGRlZGljYXRlZCcgb3IgYGZ1enp5Jy4iCiAJCQkJICAgICAgIlxcW1swLTldKlxc KD86JVxcfC9bMC05XSpcXClcXF0iCiAJCQkJICAgICAgd3NwYWNlb3B0CiAJCQkJICAgICAgIlxc KSIpKQotCQkgICAgICAoc2VwIChjb25jYXQgIlxcKD86IiB3c3BhY2UgIitcXHwiIGNvb2tpZSAi K1xcKSIpKQorCQkgICAgICAoc2VwIChjb25jYXQgIlxcKD86XFwoPzoiIHdzcGFjZSAiXFx8IiBj b29raWUgIlxcKStcXCkiKSkKIAkJICAgICAgKHJlIChjb25jYXQKIAkJCSAgIG9yZy1vdXRsaW5l LXJlZ2V4cC1ib2wKIAkJCSAgICJcXCg/OiIgb3JnLXRvZG8tcmVnZXhwICJbIFx0XStcXCk/Igog CQkJICAgIlxcKD86XFxbIy5cXF1bIFx0XStcXCk/IgogCQkJICAgIlxcKD86IiBvcmctY29tbWVu dC1zdHJpbmcgIlsgXHRdK1xcKT8iCi0JCQkgICBzZXAgIioiCisJCQkgICBzZXAgIj8iCiAJCQkg ICAobGV0ICgodGl0bGUgKG1hcGNvbmNhdCAjJ3JlZ2V4cC1xdW90ZQogCQkJCQkJICAgd29yZHMK LQkJCQkJCSAgIChjb25jYXQgc2VwICIrIikpKSkKKwkJCQkJCSAgIHNlcCkpKQogCQkJICAgICAo aWYgc3RhcnJlZCAoc3Vic3RyaW5nIHRpdGxlIDEpIHRpdGxlKSkKLQkJCSAgIHNlcCAiKiIKKwkJ CSAgIHNlcCAiPyIKIAkJCSAgIChvcmctcmUgIlxcKD86WyBcdF0rOltbOmFsbnVtOl1fQCMlJTpd KzpcXCk/IikKIAkJCSAgICJbIFx0XSokIikpKQogCQkgKGdvdG8tY2hhciAocG9pbnQtbWluKSkK LS0gCjIuNS4wCgo= --001a113ed2f80b109e051d48527e Content-Type: text/x-patch; charset=US-ASCII; name="0002-Remove-references-to-ChangeLog.patch" Content-Disposition: attachment; filename="0002-Remove-references-to-ChangeLog.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_idbvk5zs1 RnJvbSBmNTJmMmU0MjhkNWQ5ODFhZDZkYjQzY2Q4YzczNzI0YzhkNjJiMDM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXAgPHBpcGNldEBnbWFpbC5jb20+CkRhdGU6IEZyaSwg MTQgQXVnIDIwMTUgMTY6NDI6MDIgKzAwMDAKU3ViamVjdDogW1BBVENIIDIvMl0gCVJlbW92ZSBy ZWZlcmVuY2VzIHRvIENoYW5nZUxvZy4KCgkqIFJFQURNRV9jb250cmlidXRlOiByZW1vdmUgcmVm ZXJlbmNlcyB0byBDaGFuZ2VMb2cuICBJbnN0ZWFkLAoJcmVmZXJlbmNlIHRoZSBFbWFjcyBgQ09O VFJJQlVURScgZmlsZSB3aGljaCBkb2N1bWVudHMgaG93IHRvCglmb3JtYXQgZ2l0IGNvbW1pdCBt ZXNzYWdlcy4KCiAgICAgICAgVElOWUNIQU5HRQotLS0KIFJFQURNRV9jb250cmlidXRlIHwgOCAr KysrLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9SRUFETUVfY29udHJpYnV0ZSBiL1JFQURNRV9jb250cmlidXRlCmluZGV4 IDNlMWVmNmQuLjYzZWQwYmQgMTAwNjQ0Ci0tLSBhL1JFQURNRV9jb250cmlidXRlCisrKyBiL1JF QURNRV9jb250cmlidXRlCkBAIC01OCwxMCArNTgsMTAgQEAgZGV2ZWxvcG1lbnQuCiAgICAgIG5l dyBtZWNoYW5pc20gdG8gbWFrZSBzdXJlIGFsbCBjaGFuZ2VzIGVuZCB1cCBpbiB0aGUgcmlnaHQK ICAgICAgcGxhY2UuCiAKLSAgIC0gQ3JlYXRpbmcgYW5kIHB1c2hpbmcgYSBjaGFuZ2UgdG8gdGhl IE9yZy1tb2RlIGNvcmUgcmVxdWlyZXMKLSAgICAgeW91IGFsc28gdG8gcHJvdmlkZSBDaGFuZ2VM b2cgZW50cmllcy4gIEp1c3QgcHJlc3MgYEMteCA0IGEnCi0gICAgIGluIGVhY2ggZnVuY3Rpb24g b3IgdmFyaWFibGUgeW91IGhhdmUgbW9kaWZpZWQgYW5kIGRlc2NyaWJlCi0gICAgIHRoZSBjaGFu Z2UgeW91IG1hZGUgaW4gdGhlIENoYW5nZUxvZyBidWZmZXIvZmlsZS4KKyAgIC0gT3JnLW1vZGUg bm8gbG9uZ2VyIHVzZXMgQ2hhbmdlTG9nIGVudHJpZXMgdG8gZG9jdW1lbnQKKyAgICAgY2hhbmdl cy4gSW5zdGVhZCwgc3BlY2lhbCBjb21taXQgbWVzc2FnZXMgYXJlIHVzZWQsIGFzCisgICAgIGRl c2NyaWJlZCBpbiB0aGUgYENPTlRSSUJVVEUnIGZpbGUgaW4gdGhlIG1haW4gRW1hY3MKKyAgICAg cmVwb3NpdG9yeS4KIAogICAgLSBBbW9uZyBvdGhlciB0aGluZ3MsIE9yZy1tb2RlIGlzIHdpZGVs eSBhcHByZWNpYXRlZCBiZWNhdXNlCiAgICAgIG9mIGl0cyBzaW1wbGljaXR5LCBjbGVhbm5lc3Mg YW5kIGNvbnNpc3RlbmN5LiAgV2Ugc2hvdWxkIHRyeQotLSAKMi41LjAKCg== --001a113ed2f80b109e051d48527e--