From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Joe Vornehm Jr." Subject: Re: [PATCH] Fix regexps in org-clock.el Date: Sat, 31 Dec 2011 18:21:33 -0500 Message-ID: References: <4EFEBAEB.2090808@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=20cf303dd5886da7e704b56b9df1 Return-path: Received: from eggs.gnu.org ([140.186.70.92]:56496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rh8FP-0001Rr-R4 for emacs-orgmode@gnu.org; Sat, 31 Dec 2011 18:21:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rh8FO-0006at-Qx for emacs-orgmode@gnu.org; Sat, 31 Dec 2011 18:21:55 -0500 Received: from mail-yx0-f169.google.com ([209.85.213.169]:41078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rh8FO-0006ap-KV for emacs-orgmode@gnu.org; Sat, 31 Dec 2011 18:21:54 -0500 Received: by yenq10 with SMTP id q10so9416719yen.0 for ; Sat, 31 Dec 2011 15:21:54 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org --20cf303dd5886da7e704b56b9df1 Content-Type: text/plain; charset=UTF-8 Thanks -- understood. I checked org-clock.el for uses of org-clock-string in regexps but failed to check other files. Joe V. On Sat, Dec 31, 2011 at 3:06 AM, Carsten Dominik wrote: > Applied, thanks. > > But I have removed the regexp-quote again, because org-clock-string > is used in many more regexps, and a more complete patch would be > needed to make this change meaningful. > > - Carsten > > On 31.12.2011, at 08:34, Joe Vornehm Jr. wrote: > > > I have been seeing persistent errors of "Cannot restart clock because > task does not contain unfinished clock" when auto-resuming a saved > (persistent) clock. I believe I've tracked the error down to an extraneous > space in a regexp ("^[ \t]* " when it should be "^[ \t]*"). > > > > This patch fixes the issue for me (in `org-clock-in'), and it makes the > same change in `org-clock-find-position'. I've tested this briefly and it > works for me; nothing about clocking-in behavior seems to break, and > persistent clocks work now. > > > > I've also wrapped `regexp-quote' around instances where org-clock-string > is used to build a regexp, in case someone puts funny characters in their > org-clock-string. > > > > Hopefully, the patch is attached correctly and Thunderbird didn't mangle > it. > > > > Cheers! > > Joe V. > > > > > > <0001-Fix-regexps-in-org-clock.el.patch> > > --20cf303dd5886da7e704b56b9df1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks -- understood.=C2=A0 I checked org-clock.el for uses of org-clock-st= ring in regexps but failed to check other files.

Joe V.

On Sat, Dec 31, 2011 at 3:06 AM, Carsten Dominik <carsten.domi= nik@gmail.com> wrote:
Applied, thanks.

But I have removed the regexp-quote again, because org-clock-string
is used in many more regexps, and a more complete patch would be
needed to make this change meaningful.

- Carsten

On 31.12.2011, at 08:34, Joe Vornehm Jr. wrote:

> I have been seeing persistent errors of "Cannot restart clock bec= ause task does not contain unfinished clock" when auto-resuming a save= d (persistent) clock. =C2=A0I believe I've tracked the error down to an= extraneous space in a regexp ("^[ \t]* " when it should be "= ;^[ \t]*").
>
> This patch fixes the issue for me (in `org-clock-in'), and it make= s the same change in `org-clock-find-position'. =C2=A0I've tested t= his briefly and it works for me; nothing about clocking-in behavior seems t= o break, and persistent clocks work now.
>
> I've also wrapped `regexp-quote' around instances where org-cl= ock-string is used to build a regexp, in case someone puts funny characters= in their org-clock-string.
>
> Hopefully, the patch is attached correctly and Thunderbird didn't = mangle it.
>
> Cheers!
> Joe V.
>
>
> <0001-Fix-regexps-in-org-clock.el.patch>


--20cf303dd5886da7e704b56b9df1--