From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0HmBEYob2GCAJAAAgWs5BA (envelope-from ) for ; Sun, 27 Jun 2021 08:32:42 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 0FshDYob2GCuMgAAbx9fmQ (envelope-from ) for ; Sun, 27 Jun 2021 06:32:42 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 97AE9176DA for ; Sun, 27 Jun 2021 08:32:41 +0200 (CEST) Received: from localhost ([::1]:46008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxOLP-0008HR-BL for larch@yhetil.org; Sun, 27 Jun 2021 02:32:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxOKy-0008HJ-7v for emacs-orgmode@gnu.org; Sun, 27 Jun 2021 02:32:12 -0400 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:35552) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lxOKv-0001rA-9X for emacs-orgmode@gnu.org; Sun, 27 Jun 2021 02:32:11 -0400 Received: by mail-lf1-x136.google.com with SMTP id u13so25261218lfk.2 for ; Sat, 26 Jun 2021 23:32:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z0Wk6GAHt1hGx8bczYaGP8fGPpl8SgzJ3KTub7wpVi4=; b=La2IauXMY7fk5dQ32aRUAU4gazpA2ky3I/qJb8PvbCSBtjTCVhD2mGnW/FnUM18TE/ D/0cVorV01YX/QqEVoDi8zGlhHLNoP7GErE1Dbu+9HlhAqzAhOcBd3QAzr4xLtcq37ir 3C7QUJh/NBOA3r3dDFioROcC079qDv7RPp3sE0rRRnr3xL+vFoE2bQx3r4eq+/0Q4kb1 2jYu8ABU4Nirx8RtI3SA/+9lkmcwLYZja/MmyKwPjL42oYLstljD76Gl2XrkJ36TXR5c iN8cQxsvMCPgLZ6ca7XPULVIuZhrAWtBkpmZLjjPKmsgx8AJihYAf4dctZqxior4Ovra xLtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z0Wk6GAHt1hGx8bczYaGP8fGPpl8SgzJ3KTub7wpVi4=; b=amTdS+YWg46D7M2EPjg5GbH8u+uAlXFQ4bMhDW2H7Cr/kKPvGdfDYNRS6uYLZq6wcS ZGCQWuPyau0DlHMvPmJZDgBZRLo2qXaSVT7ApjVQs/PLHKhuhNaHiTWpUpLvUZgv6ofi CUOgA5lQA11W60WBJoChiBuLJ/muQ8Aec0ytcxIlHlgOczSykF1aUWuucs3zav81PAJ2 Uljgt3wLHeVjvXYtkaMqeYGHOjMGPJpyaC5d1x68AJqEawJJQ9MYQsMIl7nWs06mnCa2 e7GHZiOIbZtTBZS+TytWyacmx0H7kBrTfmAveIOMo61LoeV4XwCQLhLHjhRQFEdbzY7T P2Fw== X-Gm-Message-State: AOAM531moTpX5A6i4qHj+xkizO/J9DLSNRyJYLnKb+rwWHKH2EBSEoIS NQlrMc7/UnoHGWYPsF9pEhJZLRXO+9FQi9Hehp4= X-Google-Smtp-Source: ABdhPJyh8ynQqRObR3i3PvzAE2IOkQRMauapLcMgJrWzR9RZaywOY63bRDblyCahFe9Ni5FUJxaL1TYB+2Ek5o7Y97I= X-Received: by 2002:a05:6512:1683:: with SMTP id bu3mr15155213lfb.520.1624775526637; Sat, 26 Jun 2021 23:32:06 -0700 (PDT) MIME-Version: 1.0 References: <87fsxgd420.fsf@gmail.com> <87o8bs59dq.fsf@gmail.com> In-Reply-To: <87o8bs59dq.fsf@gmail.com> From: Bhavin Gandhi Date: Sun, 27 Jun 2021 12:01:38 +0530 Message-ID: Subject: Re: Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)] To: Gustavo Barros Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::136; envelope-from=bhavin7392@gmail.com; helo=mail-lf1-x136.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org, Jeff Kowalski Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624775562; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=z0Wk6GAHt1hGx8bczYaGP8fGPpl8SgzJ3KTub7wpVi4=; b=jtv2xtHIy5WhO9y+oZlScmz3wQ1egDov/yNO6DSDZr4wJPz/2eybdzJolBey+NtFIYFVKr dGfZ0OnaUvqtilVQljnqrDjEQPiBXsweNG8EDTx3/gtWNr515tSVF7+uftHwF243urreAT k9dc0SNQou+AH6zW3cAonjO4MppLBEX3VYthb20i1XMmxlNXpcetSQZqJ6coukwOS6Jezc 0hCRghMzCmlR5/sTfczgQH/t4LApqU11hKiglf9Ai6egIRv0KRo5z6AiDFQw79T4h36z+/ zJ5p0BqZ9AjRstq/5vI023nZ/WA7cXfWiSaTd6B90hVgD3KzUmKB+8/kJ04njQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624775562; a=rsa-sha256; cv=none; b=lDjLJFoY3vChw5FJFtxD3kSC9I4w2za0r9TEDGS8QYzvJcpY+Jt70GzeAjGiZVJfEw7qLb qjSsJo0k3Y2Oy4TsjcA/TPQpFijLbCoYo/2mwzXGBvPsW8+BCQXT1FVDwMbGSd93OUj0mO BcwH2aHsfpLShwcfkPFLwj0W4F2/Z7v15kG4sejl+sidOpvbHr2Su3nlEvRUU+zkCAQRkU K+V9HrduU/AU4hNiF62280H1CSiP4/OVAsBa3LPUuJ0FUysb8e56v0d80CuIUAkAIRhRj/ ohi2HZcLCyZLabxH+UGgyiz4whn8BE+Va6m3tMxStbqVerKZf+Wme+YJxbU07A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=La2IauXM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=La2IauXM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 97AE9176DA X-Spam-Score: -1.33 X-Migadu-Scanner: scn1.migadu.com X-TUID: 0DWIa+SjKA6t On Sat, 26 Jun 2021 at 00:13, Jeff Kowalski wrote: > While I don't have a fix for the root issue, I did have a chance to > create > a lint for LOGBOOK duplicates, as you suggested. Thank you Jeff, I had no clue how to write something like that :) On Sun, 27 Jun 2021 at 07:58, Gustavo Barros wrote: > > I did some digging and, as far as I can tell, the commit which > introduces the bug is "c670379ad Fix `org-agenda-todo' undo behavior > when logging (not adding note)". > > I tested the ECM initially reported, and I don't find the behavior in > commit `b2be3dd0e', but I do find it in `59edcc27c', and what happened > in `master' between the two is `c670379ad'. You are right, I actually did a bisect last week and found that change has introduced this behavior. I should have posted that immediately, it would have saved some of your time. I'm trying to wrap my head around the `org-todo' code as well as the change from `c670379ad'. Till now I found that the function `org-add-log-setup' is getting called twice. Why that's happening, I'm not sure yet. I think running edebug will help here, I'm going to try that. -- Bhavin Gandhi (bhavin192) | https://geeksocket.in