From: Bhavin Gandhi <firstname.lastname@example.org> To: Gustavo Barros <email@example.com> Cc: firstname.lastname@example.org, Jeff Kowalski <email@example.com> Subject: Re: Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)] Date: Mon, 28 Jun 2021 22:55:46 +0530 [thread overview] Message-ID: <CAOn=hbdwS0ms0ekT+fNat3rcuhVYH8ferakLWQ8mFzTdY=dwKA@mail.gmail.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Sun, 27 Jun 2021 at 12:01, Bhavin Gandhi wrote: > > Till now I found that the function `org-add-log-setup' is getting > called twice. Why that's happening, I'm not sure yet. I think running > edebug will help here, I'm going to try that. > I found the reason for this behavior with the help of edebug. `org-todo' calls `org-add-log-setup' to log the state change, and then it calls `org-auto-repeat-maybe'. The `org-auto-repeat-maybe' then calls the `org-add-log-setup' again, I think this is for logging something related to repeated entries. Before the change `c670379ad', `org-add-log-setup' used to add `org-add-log-note' to post-command-hook instead of calling it directly. If I have understood the post-command-hooks correctly, it used to keep only one entry of `org-add-log-note'. This is because `add-hook' function makes sure that there are no duplicate entries in the hooks. I'm not sure how this can be fixed, I'm going to read the `org-auto-repeat-maybe' to understand what all it is doing.
next prev parent reply other threads:[~2021-06-28 17:26 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-17 2:22 Jeff Kowalski 2021-06-17 13:16 ` Gustavo Barros 2021-06-26 3:13 ` Jeff Kowalski 2021-06-26 10:53 ` Gustavo Barros 2021-06-27 2:28 ` Gustavo Barros 2021-06-27 6:31 ` Bhavin Gandhi 2021-06-27 10:28 ` Gustavo Barros 2021-06-28 17:25 ` Bhavin Gandhi [this message] -- strict thread matches above, loose matches on Subject: below -- 2021-06-14 13:39 Gustavo Barros 2021-06-14 18:01 ` Bhavin Gandhi 2021-06-14 18:41 ` Gustavo Barros
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAOn=hbdwS0ms0ekT+fNat3rcuhVYH8ferakLWQ8mFzTdY=dwKA@mail.gmail.com' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)]' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).