From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id qC2uHM/NwWJiAQEAbAwnHQ (envelope-from ) for ; Sun, 03 Jul 2022 19:11:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id wEGqHM/NwWLfcwEA9RJhRA (envelope-from ) for ; Sun, 03 Jul 2022 19:11:43 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0A9E41F640 for ; Sun, 3 Jul 2022 19:11:42 +0200 (CEST) Received: from localhost ([::1]:41658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o838H-0003Z9-QM for larch@yhetil.org; Sun, 03 Jul 2022 13:11:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o837Y-0003Yy-I1 for emacs-orgmode@gnu.org; Sun, 03 Jul 2022 13:10:56 -0400 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:46856) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o837W-0004lZ-BR for emacs-orgmode@gnu.org; Sun, 03 Jul 2022 13:10:56 -0400 Received: by mail-ed1-x536.google.com with SMTP id x10so1574403edd.13 for ; Sun, 03 Jul 2022 10:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C6XQ/CcHOc8fvVH7mfgjj6YTxDqqSeVzyW+RCEScHcw=; b=BxMN9drMRNPXcWbmaXwEKPq2i0hDSDpzMAa/OgJtFmoZuJuDK6nZO3b4w1U0Q+WHot hsbDxVHJUagsvqC7jaR+yXlFWeo+wvgregHc1gLX7atrMvLT/xak8sSx/3iDiuJHwamw 7ZyAKr7NwM1twX9W6hSs5OPU4MwGuR0zYJFKmKYJvJ68W3WHzNSGMEFbk72uEz+1H8vn fiWMfnoHOfgiPM2OXhisuVBqnKBiTxdk3/RGmEi09fECpEgGaBTzlpE13qSfZaTYnskd q7P9AMkSv6lYfRgCtmB3Hc3iiOQB6bYT/AYivccE16mhUiyUfgdWAQGMyuQ6QwncXUJv nyhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C6XQ/CcHOc8fvVH7mfgjj6YTxDqqSeVzyW+RCEScHcw=; b=dVCH3gowqj84hjZgivoB4CL7IMscAu7Gg6raW2fNknokb3iwF1bHAMAcgfIcl9MtCI YQI1h7f+8SuxKbBpzPohb1sBcQbVNtKS5fsKIItUEU3yxMi/7SfsLob0A7a3yVpESo9l 0w/ikSWkD4qhekUkjee0lVz6cLJ4bc/YdocELWRTDGDNn1CvdZHPytk/gTGKHTczWgZg Ig3GVwb4UwxU2gGyH6OWTP8z6T8EX+8X+/bQQ8umrRgGkdh0J8StYdtRdv9yz1YTfG7A dSi6SeRrXA/1wsSEbDBsIKx6N2PiII6na4J5avTRroNZmSkpyb1vu0+9zZZmZRu+5hdm 1AAA== X-Gm-Message-State: AJIora/VL1qKw/nOn+eV+SF+p07+HqnUzMSZMlRNZgc5OFdI6UBZYRcH aQljYatsI3n2ElWlnN2kfJ9HZ0KVvn/0U+hx8Uc= X-Google-Smtp-Source: AGRyM1vjLXmJPwJBAOy+TE+LWiQpHpqEwl6wn56mrt9L0FKU7IrZvAQ3ONo6z0cPdbHSORBhFCyu6Md/TvYGoY3nV40= X-Received: by 2002:a05:6402:4306:b0:435:a1c9:4272 with SMTP id m6-20020a056402430600b00435a1c94272mr33535058edc.205.1656868251352; Sun, 03 Jul 2022 10:10:51 -0700 (PDT) MIME-Version: 1.0 References: <413e82eb-db3b-8fac-7edb-35aded973dfd@ctpowe.net> <87y1xdk2a7.fsf@localhost> In-Reply-To: <87y1xdk2a7.fsf@localhost> From: Bhavin Gandhi Date: Sun, 3 Jul 2022 22:40:12 +0530 Message-ID: Subject: =?UTF-8?Q?Re=3A_=5BBUG=5D_org=2Dauto=2Drepeat=2Dmaybe=3A_error_=22Can=E2=80=99t_expa?= =?UTF-8?Q?nd_minibuffer_to_full_frame=22_and_missing_log_note?= To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=bhavin7392@gmail.com; helo=mail-ed1-x536.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656868303; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=C6XQ/CcHOc8fvVH7mfgjj6YTxDqqSeVzyW+RCEScHcw=; b=Oqs/A/vPxcC7X+dP7fRIKfp+f6vPgNvkxPDcRkOmO07k+LD/gDn0GStKzH5WofwxsZYRKK +Kl4B/i/mYC5PxGAKJ3WXjl3zHbVsRlEcjJa+vQdy8/RHFH/yJu4RDDJg18l3OCQmijMMT 8TpimZUafE9rU+cec94C6VXr+6UeqHnqjAqlR0v3c67Nm1hOP7Ym7b2CMtjACeYXV/tBjV XPtCc5ncCUi0q9HSXc7GKlEqvbh20DGjYyInF/4wev8SbgtaqJKXSnQAv0eEXjEu2CmP9M yNMF7YJ4Ws4oCoY+67H5qvMXS7/xyTNiVl/bASxraLMWXz9t2GnQmnH3+Jz33g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656868303; a=rsa-sha256; cv=none; b=hLJUvgLvdF1otQvUJEv4e0tYfrVdk8zfF3ijmSnBe8XGFs7FaSUTqankxwzIGrgV6jZUyt 2JivHLczIZjX8b8gW4HET/IEk620F+Y9OAiZikzSnB2DxQKLLWev2xEBy5svVyADEwcaRs A5Ouf64tyzyTF5Lig1uD7ff5z5lDwLw6z+xNkbxFuv/zwlgrWexZUBpWFHJYW/3m7j1b1X y97SUwjRxErNyD8Ch7zGNo0rMB51BXNmWhgtINmHh+oqBmgepQjoEsbIylpQeGUPBdRZXM sB3GkuO3Rwsw4NE6O1Hw3TdK8ytdNMp6hGk+unfhe2H4xlSY8hFEckS0/UTRgw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BxMN9drM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.75 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BxMN9drM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0A9E41F640 X-Spam-Score: -5.75 X-Migadu-Scanner: scn0.migadu.com X-TUID: ULzolsNm9ztC On Fri, 1 Jul 2022 at 07:43, Ihor Radchenko wrote: > > Currently, when we call `org-auto-repeat-maybe', it adds > > `org-add-log-note' to post-command-hook using `org-add-log-setup'. As > > soon as we reach the question about 10 repeater intervals (the call to > > `y-or-n-p' from `org-auto-repeat-maybe'), the post-command-hook gets > > executed.[1] > > Bhavin, did you have a chance to send a bug report on this to Emacs > devs? Haven't done that yet. But it seems like we will have to find a fix to make sure `delete-other-windows' is not called for the minibuffer. My modified example: (defvar my-hook-counter) (defun my-test-command () (interactive) (message "my-test-command: setting post-command-hook") (setq my-hook-counter 3) (add-hook 'post-command-hook 'my-own-hook) (y-or-n-p "Some question: ") (message "my-test-command: message after setting the hook") ) (defun my-own-hook () (print (format "hook: this: %s, real: %s, last: %s" this-command real-this-command last-command)) (message "my-own-hook: hopefully executing at the end") (setq my-hook-counter (- my-hook-counter 1)) (if (eq my-hook-counter 0) (remove-hook 'post-command-hook 'my-own-hook)) ) While looking at the *Messages* buffer, I came across the command y-or-n-p-insert-y. There are commands for n, and other keys. When we press y, M-p etc, these commands get executed. So, even if we manage to fix the initial example in Emacs, the hook will still run while one is in the minibuffer. -- Bhavin Gandhi (bhavin192) | https://geeksocket.in