From: Bhavin Gandhi <bhavin7392@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-element-at-point warning with org-timer in agenda [9.7-pre, release_N/A-N/A-b45b39 @ /home/bhavin/.emacs.d/elpa/org-9.7pre0.20240405.140341/, ]
Date: Tue, 9 Apr 2024 22:08:17 +0530 [thread overview]
Message-ID: <CAOn=hbdCGtVi3dku-iqaZ5FvdVBAiR1-+2i=tf=NyP8_JtedmA@mail.gmail.com> (raw)
In-Reply-To: <CAOn=hbez7-4wFG2M1-MSHqAwvV0mysvLAUYP9_GK6mrSbtz3CQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 41 bytes --]
Here is a patch which fixes the problem.
[-- Attachment #1.2: Type: text/html, Size: 66 bytes --]
[-- Attachment #2: 0001-org-timer-set-timer-Don-t-run-org-entry-get-in-non-O.patch --]
[-- Type: text/x-patch, Size: 1933 bytes --]
From d34e2cd1a1e830acc6d1575a32522f8e9e5b4d99 Mon Sep 17 00:00:00 2001
From: Bhavin Gandhi <bhavin192@geeksocket.in>
Date: Mon, 8 Apr 2024 23:33:29 +0530
Subject: [PATCH] org-timer-set-timer: Don't run `org-entry-get' in non Org
buffers
* lisp/org-timer.el (org-timer-set-timer): Avoid calling org-entry-get
when we are not in an Org buffer. In case of Agenda buffer, we jump to
the entry first.
It was triggering an org-element warning when used in Agenda buffer,
and was failing to find the value of Effort property.
This patch is based on a fix by Ihor
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=a1fa52197
Reported-by: Bhavin Gandhi <bhavin7392@gmail.com>
Link: https://list.orgmode.org/CAOn=hbez7-4wFG2M1-MSHqAwvV0mysvLAUYP9_GK6mrSbtz3CQ@mail.gmail.com/
---
lisp/org-timer.el | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/lisp/org-timer.el b/lisp/org-timer.el
index 8bb8be7be..23bb1c31c 100644
--- a/lisp/org-timer.el
+++ b/lisp/org-timer.el
@@ -424,9 +424,14 @@ using three \\[universal-argument] prefix arguments."
(if (numberp org-timer-default-timer)
(number-to-string org-timer-default-timer)
org-timer-default-timer))
- (effort-minutes (let ((effort (org-entry-get nil org-effort-property)))
- (when (org-string-nw-p effort)
- (floor (org-duration-to-minutes effort)))))
+ (effort-minutes
+ ;; When called from Org buffer, remain in position.
+ ;; When called from Agenda buffer, jump to headline position first.
+ (org-with-point-at (org-get-at-bol 'org-marker)
+ (if (derived-mode-p 'org-mode)
+ (let ((effort (org-entry-get nil org-effort-property)))
+ (when (org-string-nw-p effort)
+ (floor (org-duration-to-minutes effort)))))))
(minutes (or (and (numberp opt) (number-to-string opt))
(and (not (equal opt '(64)))
effort-minutes
--
2.44.0
next prev parent reply other threads:[~2024-04-09 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-07 17:47 [BUG] org-element-at-point warning with org-timer in agenda [9.7-pre, release_N/A-N/A-b45b39 @ /home/bhavin/.emacs.d/elpa/org-9.7pre0.20240405.140341/, ] Bhavin Gandhi
2024-04-09 16:38 ` Bhavin Gandhi [this message]
2024-04-10 8:51 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOn=hbdCGtVi3dku-iqaZ5FvdVBAiR1-+2i=tf=NyP8_JtedmA@mail.gmail.com' \
--to=bhavin7392@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).