emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] org-agenda.el: Add a M-, binding for org-priority-show
@ 2020-12-01 19:51 Adam Spiers
  2020-12-09  5:25 ` Kyle Meyer
  0 siblings, 1 reply; 5+ messages in thread
From: Adam Spiers @ 2020-12-01 19:51 UTC (permalink / raw)
  To: emacs-orgmode

This offers an easy way to check the internal numeric priority
used for sorting within the agenda.
---
 doc/org-manual.org | 8 ++++++++
 lisp/org-agenda.el | 1 +
 2 files changed, 9 insertions(+)

diff --git a/doc/org-manual.org b/doc/org-manual.org
index 5a84a6de6..e914af42d 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -9891,6 +9891,14 @@ the other commands, point needs to be in the desired line.
   Set tags for the current headline.  If there is an active region in
   the agenda, change a tag for all headings in the region.
 
+- {{{kbd(M-\,)}}} (~org-priority-show~) ::
+
+  #+kindex: M-,
+  #+findex: org-priority-show
+  Show the numeric priority for the current item.  This priority is
+  composed of the main priority given with the =[#A]= cookies, and by
+  additional input from the age of a schedules or deadline entry.
+
 - {{{kbd(\,)}}} (~org-agenda-priority~) ::
 
   #+kindex: ,
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index a482b3db4..40ea31fdc 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -2399,6 +2399,7 @@ (defun org-agenda-mode ()
 (org-defkey org-agenda-mode-map "\C-c\C-p" #'org-agenda-previous-date-line)
 (org-defkey org-agenda-mode-map "\C-c," #'org-agenda-priority)
 (org-defkey org-agenda-mode-map "," #'org-agenda-priority)
+(org-defkey org-agenda-mode-map [(meta ?,)] #'org-priority-show)
 (org-defkey org-agenda-mode-map "i" #'org-agenda-diary-entry)
 (org-defkey org-agenda-mode-map "c" #'org-agenda-goto-calendar)
 (org-defkey org-agenda-mode-map "C" #'org-agenda-convert-date)
-- 
2.28.0



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] org-agenda.el: Add a M-, binding for org-priority-show
  2020-12-01 19:51 [PATCH] org-agenda.el: Add a M-, binding for org-priority-show Adam Spiers
@ 2020-12-09  5:25 ` Kyle Meyer
  2020-12-11 22:17   ` Samuel Wales
  2021-05-01 10:45   ` Bastien
  0 siblings, 2 replies; 5+ messages in thread
From: Kyle Meyer @ 2020-12-09  5:25 UTC (permalink / raw)
  To: Adam Spiers; +Cc: emacs-orgmode

[ Sorry, all, for the recent string of duplicate messages from me :x ]

Adam Spiers writes:

> This offers an easy way to check the internal numeric priority
> used for sorting within the agenda.

Thanks for the patch.  Please include a changelog entry in your commit
message.

> ---
>  doc/org-manual.org | 8 ++++++++
>  lisp/org-agenda.el | 1 +
>  2 files changed, 9 insertions(+)
>
> diff --git a/doc/org-manual.org b/doc/org-manual.org
> index 5a84a6de6..e914af42d 100644
> --- a/doc/org-manual.org
> +++ b/doc/org-manual.org
> @@ -9891,6 +9891,14 @@ the other commands, point needs to be in the desired line.
>    Set tags for the current headline.  If there is an active region in
>    the agenda, change a tag for all headings in the region.
>  
> +- {{{kbd(M-\,)}}} (~org-priority-show~) ::
> +
> +  #+kindex: M-,
> +  #+findex: org-priority-show
> +  Show the numeric priority for the current item.  This priority is
> +  composed of the main priority given with the =[#A]= cookies, and by
> +  additional input from the age of a schedules or deadline entry.
> +
>  - {{{kbd(\,)}}} (~org-agenda-priority~) ::

With a C-u, org-agenda-priority calls org-priority-show.  So perhaps
instead of adding a new binding, the documentation should be improved.
What do you think?


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] org-agenda.el: Add a M-, binding for org-priority-show
  2020-12-09  5:25 ` Kyle Meyer
@ 2020-12-11 22:17   ` Samuel Wales
  2021-05-01 10:45   ` Bastien
  1 sibling, 0 replies; 5+ messages in thread
From: Samuel Wales @ 2020-12-11 22:17 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-orgmode

off topic, but as a separate change, perhaps the 2 things named
priority could have separate names?

On 12/8/20, Kyle Meyer <kyle@kyleam.com> wrote:
> [ Sorry, all, for the recent string of duplicate messages from me :x ]
>
> Adam Spiers writes:
>
>> This offers an easy way to check the internal numeric priority
>> used for sorting within the agenda.
>
> Thanks for the patch.  Please include a changelog entry in your commit
> message.
>
>> ---
>>  doc/org-manual.org | 8 ++++++++
>>  lisp/org-agenda.el | 1 +
>>  2 files changed, 9 insertions(+)
>>
>> diff --git a/doc/org-manual.org b/doc/org-manual.org
>> index 5a84a6de6..e914af42d 100644
>> --- a/doc/org-manual.org
>> +++ b/doc/org-manual.org
>> @@ -9891,6 +9891,14 @@ the other commands, point needs to be in the
>> desired line.
>>    Set tags for the current headline.  If there is an active region in
>>    the agenda, change a tag for all headings in the region.
>>
>> +- {{{kbd(M-\,)}}} (~org-priority-show~) ::
>> +
>> +  #+kindex: M-,
>> +  #+findex: org-priority-show
>> +  Show the numeric priority for the current item.  This priority is
>> +  composed of the main priority given with the =[#A]= cookies, and by
>> +  additional input from the age of a schedules or deadline entry.
>> +
>>  - {{{kbd(\,)}}} (~org-agenda-priority~) ::
>
> With a C-u, org-agenda-priority calls org-priority-show.  So perhaps
> instead of adding a new binding, the documentation should be improved.
> What do you think?
>
>


-- 
The Kafka Pandemic

Please learn what misopathy is.
https://thekafkapandemic.blogspot.com/2013/10/why-some-diseases-are-wronged.html


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] org-agenda.el: Add a M-, binding for org-priority-show
  2020-12-09  5:25 ` Kyle Meyer
  2020-12-11 22:17   ` Samuel Wales
@ 2021-05-01 10:45   ` Bastien
  2021-05-01 19:25     ` Adam Spiers
  1 sibling, 1 reply; 5+ messages in thread
From: Bastien @ 2021-05-01 10:45 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-orgmode

Hi Kyle and Adam,

Kyle Meyer <kyle@kyleam.com> writes:

> With a C-u, org-agenda-priority calls org-priority-show.  So perhaps
> instead of adding a new binding, the documentation should be improved.

I pushed a small enhancement for org-agenda-priority's docstring
with commit e080eb759.

I am reluctant adding another keybinding to the agenda especially
since there is no keybinding for `org-priority-show'.

Thanks,

-- 
 Bastien


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] org-agenda.el: Add a M-, binding for org-priority-show
  2021-05-01 10:45   ` Bastien
@ 2021-05-01 19:25     ` Adam Spiers
  0 siblings, 0 replies; 5+ messages in thread
From: Adam Spiers @ 2021-05-01 19:25 UTC (permalink / raw)
  To: Bastien; +Cc: Kyle Meyer, org-mode mailing list

On Sat, 1 May 2021 at 11:45, Bastien <bzg@gnu.org> wrote:
> Kyle Meyer <kyle@kyleam.com> writes:
> > With a C-u, org-agenda-priority calls org-priority-show.  So perhaps
> > instead of adding a new binding, the documentation should be improved.
>
> I pushed a small enhancement for org-agenda-priority's docstring
> with commit e080eb759.
>
> I am reluctant adding another keybinding to the agenda especially
> since there is no keybinding for `org-priority-show'.

Thanks, that sounds like a better approach.


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-05-01 19:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-01 19:51 [PATCH] org-agenda.el: Add a M-, binding for org-priority-show Adam Spiers
2020-12-09  5:25 ` Kyle Meyer
2020-12-11 22:17   ` Samuel Wales
2021-05-01 10:45   ` Bastien
2021-05-01 19:25     ` Adam Spiers

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).